Closed Bug 1190720 Opened 5 years ago Closed 5 years ago

IP version check for TCP sockets from bug 1186339 doesn't work with DNS names

Categories

(Core :: WebRTC: Networking, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla42
Tracking Status
firefox39 --- unaffected
firefox40 --- unaffected
firefox41 --- unaffected
firefox42 --- fixed
Blocking Flags:

People

(Reporter: drno, Assigned: drno)

References

Details

Attachments

(1 file)

No description provided.
Bug 1190720: only check IP version for STUN server IPs. r?bwc
Attachment #8642871 - Flags: review?(docfaraday)
Comment on attachment 8642871 [details]
MozReview Request: Bug 1190720: only check IP version for STUN server IPs. r?bwc

https://reviewboard.mozilla.org/r/14975/#review13395

Ship It!
Attachment #8642871 - Flags: review?(docfaraday) → review+
Nils -- Do this bug and bug 1186339 (the bug this one depends on) need to get uplifted, or is only Fx42 affected?
backlog: --- → webRTC+
Rank: 15
Flags: needinfo?(drno)
Priority: -- → P1
I think non of these are release critical as the underlying network layers will complain without these fixes. So this is mostly preventing wasting cycles and creating mis-leading log messages.

Also we only have IPv6 in 42 anything regarding IP version check needs no uplift.
Flags: needinfo?(drno)
Try run looks green.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/253c0c166893
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.