Closed
Bug 1190968
Opened 9 years ago
Closed 9 years ago
Update Wikipedia search asset
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox41 verified, firefox42 verified, firefox43 verified)
VERIFIED
FIXED
Firefox 43
People
(Reporter: antlam, Assigned: mcomella)
Details
Attachments
(4 files)
6.45 KB,
application/zip
|
Details | |
175.25 KB,
image/png
|
Details | |
40 bytes,
text/x-review-board-request
|
Margaret
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details |
16.05 KB,
image/png
|
Details |
Wikipedia put in a request that the "w" needs to be updated. Will attach asset shortly
Reporter | ||
Comment 1•9 years ago
|
||
thanks mike! :D (sebastian nominated you heh)
Flags: needinfo?(michael.l.comella)
Assignee | ||
Comment 2•9 years ago
|
||
I'm a little skeptical because the new asset seems to be missing many base64 encoded characters over the previous one, but it looks like the changes were made successfully.
Assignee: nobody → michael.l.comella
Flags: needinfo?(michael.l.comella)
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Bug 1190968 - Update Wikipedia search asset. r=margaret
Attachment #8645243 -
Flags: review?(margaret.leibovic)
Comment 5•9 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #2) > I'm a little skeptical because the new asset seems to be missing many base64 > encoded characters over the previous one, but it looks like the changes were > made successfully. Maybe it's simpler to compress? If it looks alright, works for me! :)
Comment 6•9 years ago
|
||
Comment on attachment 8645243 [details] MozReview Request: Bug 1190968 - Update Wikipedia search asset. r=margaret https://reviewboard.mozilla.org/r/15477/#review13979 Ship It!
Attachment #8645243 -
Flags: review?(margaret.leibovic) → review+
Comment 7•9 years ago
|
||
This is what the iOS search bar currently looks like. I don't see a difference (if anything, the iOS one looks higher-res and altogether more pleasant). UXers: if you do, could you file a bug in Firefox for iOS :: Theme & Visual Design to make the same change there? If not, please just clear your flags and enjoy your Tuesday :)
Flags: needinfo?(randersen)
Flags: needinfo?(alam)
Updated•9 years ago
|
Status: NEW → ASSIGNED
Component: General → Theme and Visual Design
Assignee | ||
Comment 8•9 years ago
|
||
(In reply to Richard Newman [:rnewman] from comment #7) > I don't see a difference (if anything, the iOS one looks higher-res and > altogether more pleasant). fwict, the new asset is slightly shorter (by a few pixels) and the serif at the top of the W's are wider.
Reporter | ||
Comment 9•9 years ago
|
||
I'm not sure about the iOS one, so I'm going to leave this to Robin
Flags: needinfo?(alam)
Comment 10•9 years ago
|
||
(In reply to Richard Newman [:rnewman] from comment #7) > Created attachment 8646147 [details] > iOS current state > > This is what the iOS search bar currently looks like. > > I don't see a difference (if anything, the iOS one looks higher-res and > altogether more pleasant). > > UXers: if you do, could you file a bug in Firefox for iOS :: Theme & Visual > Design to make the same change there? > > If not, please just clear your flags and enjoy your Tuesday :) The difference is slight, http://c.tecgirl.com/cCtl, and since I made the iOS asset, I can certainly update it to match the negative space and baseline. Filed: bug 1193421
Flags: needinfo?(randersen)
Assignee | ||
Comment 11•9 years ago
|
||
url: https://hg.mozilla.org/integration/fx-team/rev/9b4fa1dc91fd42a5ecc095bcf194ed98f51209d9 changeset: 9b4fa1dc91fd42a5ecc095bcf194ed98f51209d9 user: Michael Comella <michael.l.comella@gmail.com> date: Fri Aug 07 16:51:21 2015 -0700 description: Bug 1190968 - Update Wikipedia search asset. r=margaret
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9b4fa1dc91fd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Comment 13•9 years ago
|
||
Comment on attachment 8645243 [details] MozReview Request: Bug 1190968 - Update Wikipedia search asset. r=margaret Going ahead and asking for approval on other branches. Approval Request Comment [Feature/regressing bug #]: icon currently used for Wikipedia searchplugin doesn't met Wikimedia's branding guidelines [User impact if declined]: they'll get one icon for 2 cycles (larger icons are in fx41, not fx40), then the correct one in Firefox 43 [Describe test coverage new/current, TreeHerder]: landed in m-c, no code changes involved. [Risks and why]: - [String/UUID change made/needed]: -
Attachment #8645243 -
Flags: approval-mozilla-beta?
Attachment #8645243 -
Flags: approval-mozilla-aurora?
Michael, when I was reviewing this patch for uplift I noticed that the xml file that has changed is specific to en-us locale (mobile/locales/en-US/searchplugins/wikipedia.xml). Is the searchplugin image change applicable to other locales that FF ships with? Thanks.
Flags: needinfo?(michael.l.comella)
Assignee | ||
Comment 15•9 years ago
|
||
Redirect comment 14 to antlam.
Flags: needinfo?(michael.l.comella) → needinfo?(alam)
status-firefox41:
--- → affected
status-firefox42:
--- → affected
Comment 16•9 years ago
|
||
(In reply to Ritu Kothari (:ritu) from comment #14) > Michael, when I was reviewing this patch for uplift I noticed that the xml > file that has changed is specific to en-us locale > (mobile/locales/en-US/searchplugins/wikipedia.xml). Is the searchplugin > image change applicable to other locales that FF ships with? Thanks. That is covered by bug 1179109. Sadly updating searchplugins for localizations takes a lot longer. I don't plan to uplift up to Beta, but most of the locales are already fixed on both aurora and central.
Flags: needinfo?(alam)
(In reply to Francesco Lodolo [:flod] from comment #16) > (In reply to Ritu Kothari (:ritu) from comment #14) > > Michael, when I was reviewing this patch for uplift I noticed that the xml > > file that has changed is specific to en-us locale > > (mobile/locales/en-US/searchplugins/wikipedia.xml). Is the searchplugin > > image change applicable to other locales that FF ships with? Thanks. > > That is covered by bug 1179109. > > Sadly updating searchplugins for localizations takes a lot longer. I don't > plan to uplift up to Beta, but most of the locales are already fixed on both > aurora and central. Great! Thanks Flod. I will approve for uplift to Beta.
Comment on attachment 8645243 [details] MozReview Request: Bug 1190968 - Update Wikipedia search asset. r=margaret Approved for uplift to Aurora and Beta. Patch seems safe as it's a image replacement only.
Attachment #8645243 -
Flags: approval-mozilla-beta?
Attachment #8645243 -
Flags: approval-mozilla-beta+
Attachment #8645243 -
Flags: approval-mozilla-aurora?
Attachment #8645243 -
Flags: approval-mozilla-aurora+
Requesting QE team to verify the updated icon for wikipedia search. Thanks!
Flags: qe-verify+
Comment 22•9 years ago
|
||
Verified as fixed on Firefox 41 Beta 2, on latest Aurora, and latest Nightly.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•