Closed Bug 1179109 Opened 9 years ago Closed 7 years ago

[tracking] Firefox for Android: update search icons to high resolution

Categories

(Mozilla Localizations :: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: flod, Assigned: flod)

References

()

Details

Attachments

(1 file)

20.96 KB, application/zip
Details
Bug 1156917 is going to fix English, which means we have assets for Amazon, DuckDuckGo, Twitter, Wikipedia, Yahoo.

Bing and Google are already covered since we use en-US XML files.

The current format is PGN, 96x96 pixel. Remember that % breaks the icon.
Blocks: 1156917
Also note that the en-US icons were modified by our antlam to have rounded corners (and then verified with the search providers that these icons were acceptable).

Anthony, is there a metric you can share for how rounded the corners are?
Flags: needinfo?(alam)
(In reply to Michael Comella (:mcomella) from comment #1)
> Also note that the en-US icons were modified by our antlam to have rounded
> corners (and then verified with the search providers that these icons were
> acceptable).

Good point.

> Anthony, is there a metric you can share for how rounded the corners are?

I would also be interested in the process used to make them, we have several of those icons
https://l10n.mozilla-community.org/~flod/p12n/collage/?channel=aurora&product=mobile
(In reply to Michael Comella (:mcomella) from comment #1)
> Also note that the en-US icons were modified by our antlam to have rounded
> corners (and then verified with the search providers that these icons were
> acceptable).
> 
> Anthony, is there a metric you can share for how rounded the corners are?

2dp/px!

(In reply to Francesco Lodolo [:flod] from comment #2)
> I would also be interested in the process used to make them, we have several
> of those icons
> https://l10n.mozilla-community.org/~flod/p12n/collage/
> ?channel=aurora&product=mobile

First, I look at each brand's color and brand guidelines to determine the background. The bounding box is then made to be 32px square with the 2px radius. Finally, I chose their logo that is (as determined by their brand guidelines/team) meant to appear on color/black backdrops.

Hope that helps!
Flags: needinfo?(alam)
Assignee: nobody → francesco.lodolo
Started cleaning up Amazon, Wikipedia, Yahoo for locales working on Pootle (or not active).
Will still have to do a second pass on some of them as soon as we have assets for eBay and Yandex.

Status before starting the process: 131 wrong icons for Amazon, Wikipedia, Yahoo.
Down to 55 after this run.

http://hg.mozilla.org/releases/l10n/mozilla-aurora/an/rev/afbb7a0b8d29
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ar/rev/79e47abcafe7
http://hg.mozilla.org/releases/l10n/mozilla-aurora/as/rev/7e27bfa3a879
http://hg.mozilla.org/releases/l10n/mozilla-aurora/az/rev/a1691af77fce
http://hg.mozilla.org/releases/l10n/mozilla-aurora/be/rev/9a7283fa1571
http://hg.mozilla.org/releases/l10n/mozilla-aurora/bn-IN/rev/50dbc95258c0
http://hg.mozilla.org/releases/l10n/mozilla-aurora/br/rev/469acf41e0f5
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ca/rev/7c59e55b80ef
http://hg.mozilla.org/releases/l10n/mozilla-aurora/cy/rev/b0a6c28aee4d
http://hg.mozilla.org/releases/l10n/mozilla-aurora/dsb/rev/498712852107
http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-MX/rev/fb8f86f11979
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fa/rev/e85640bd8073
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ga-IE/rev/2b92e8d1e08f
http://hg.mozilla.org/releases/l10n/mozilla-aurora/gd/rev/dfaf2ed1aa95
http://hg.mozilla.org/releases/l10n/mozilla-aurora/gu-IN/rev/08a71d5190de
http://hg.mozilla.org/releases/l10n/mozilla-aurora/hi-IN/rev/4da005a9035b
http://hg.mozilla.org/releases/l10n/mozilla-aurora/hsb/rev/e0638a96affd
http://hg.mozilla.org/releases/l10n/mozilla-aurora/hy-AM/rev/9882b0884f0a
http://hg.mozilla.org/releases/l10n/mozilla-aurora/id/rev/c98f0ddfdf2c
http://hg.mozilla.org/releases/l10n/mozilla-aurora/is/rev/110ac2230c6a
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ka/rev/45f310227fdc
http://hg.mozilla.org/releases/l10n/mozilla-aurora/kk/rev/3ff349a17b40
http://hg.mozilla.org/releases/l10n/mozilla-aurora/km/rev/51e344ff9157
http://hg.mozilla.org/releases/l10n/mozilla-aurora/kn/rev/151a2e40e5f0
http://hg.mozilla.org/releases/l10n/mozilla-aurora/lt/rev/71c58eadb9ae
http://hg.mozilla.org/releases/l10n/mozilla-aurora/lv/rev/802e6de96b7c
http://hg.mozilla.org/releases/l10n/mozilla-aurora/mai/rev/c1ff0daa056a
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ml/rev/0c914f9c9805
http://hg.mozilla.org/releases/l10n/mozilla-aurora/mr/rev/4cc38c673b01
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ms/rev/1375f3192a28
http://hg.mozilla.org/releases/l10n/mozilla-aurora/my/rev/1dbb051c2d55
http://hg.mozilla.org/releases/l10n/mozilla-aurora/or/rev/3130e4547aa4
http://hg.mozilla.org/releases/l10n/mozilla-aurora/pt-BR/rev/e133aaed7dd6
http://hg.mozilla.org/releases/l10n/mozilla-aurora/pt-PT/rev/02eb51cf7145
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/rev/11ba9cd09f61
http://hg.mozilla.org/releases/l10n/mozilla-aurora/son/rev/ad3d10aed745
http://hg.mozilla.org/releases/l10n/mozilla-aurora/sv-SE/rev/6e4aa5c1e07b
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ta/rev/d0e7e6f8f9de
http://hg.mozilla.org/releases/l10n/mozilla-aurora/th/rev/6ce2586f2a98
http://hg.mozilla.org/releases/l10n/mozilla-aurora/tr/rev/db532251f6ef
http://hg.mozilla.org/releases/l10n/mozilla-aurora/uz/rev/8e5af6a9a2ef
http://hg.mozilla.org/releases/l10n/mozilla-aurora/vi/rev/b964a6e4b04f

Also updated Wikipedia for Italian
http://hg.mozilla.org/releases/l10n/mozilla-aurora/it/rev/58e9c64f0b1a
Depends on: 1186996
Reminder: please make sure to file a bug and ask for review if you're changing images not available in en-US. Slovenian already post-reviewed.
emailed Prisjakt earlier today, will post here if they get back to me during the week
(In reply to Francesco Lodolo [:flod] from comment #16)
> Reminder: please make sure to file a bug and ask for review if you're
> changing images not available in en-US. Slovenian already post-reviewed.

Got a file too you from Prisjakt for SV-SE via email now yesterday :)
https://drive.google.com/file/d/0B_AQuzrnw133c0lNVkx5clhIbEk/view
they wrote they rather not have a black bacground tough
Got a file from Prisjakt for you to check on during the week :), if you need more help on this just needinfo me :)
Flags: needinfo?(francesco.lodolo)
Black is not mandatory, it just doesn't need to be white ;-)
File looks good, thanks.
Flags: needinfo?(francesco.lodolo)
Depends on: 1192836
Depends on: 1193140
We have an updated icon for Wikipedia in bug 1190968, the one that landed didn't conform to their style guidelines.

I'll send an email to dev-l10n as soon as it lands on hg.
I've fixed Wikipedia for all locales that I've updated before

https://hg.mozilla.org/releases/l10n/mozilla-aurora/an/rev/b4b74ab1d5d5
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ar/rev/0690a37f830c
https://hg.mozilla.org/releases/l10n/mozilla-aurora/as/rev/fd49db2a6de4
https://hg.mozilla.org/releases/l10n/mozilla-aurora/az/rev/b02a1bb2033a
https://hg.mozilla.org/releases/l10n/mozilla-aurora/be/rev/6f185eef3d29
https://hg.mozilla.org/releases/l10n/mozilla-aurora/bn-IN/rev/7f43e736f72d
https://hg.mozilla.org/releases/l10n/mozilla-aurora/br/rev/b8537773f276
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ca/rev/f27acbebb170
https://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/6888d893a302
https://hg.mozilla.org/releases/l10n/mozilla-aurora/cy/rev/4c8182a41999
https://hg.mozilla.org/releases/l10n/mozilla-aurora/dsb/rev/ca3b524d748a
https://hg.mozilla.org/releases/l10n/mozilla-aurora/es-AR/rev/35bb17f35dfe
https://hg.mozilla.org/releases/l10n/mozilla-aurora/es-MX/rev/6763ce88f95b
https://hg.mozilla.org/releases/l10n/mozilla-aurora/fa/rev/d73eb6f74d81
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ff/rev/089bb247eb02
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ga-IE/rev/a93ca0bbc03d
https://hg.mozilla.org/releases/l10n/mozilla-aurora/gd/rev/44a968bbb85b
https://hg.mozilla.org/releases/l10n/mozilla-aurora/gl/rev/0be401c50573
https://hg.mozilla.org/releases/l10n/mozilla-aurora/gu-IN/rev/d1c65a6133c0
https://hg.mozilla.org/releases/l10n/mozilla-aurora/he/rev/93e9ca6c5f62
https://hg.mozilla.org/releases/l10n/mozilla-aurora/hi-IN/rev/ab494fa78af8
https://hg.mozilla.org/releases/l10n/mozilla-aurora/hsb/rev/d6429622656e
https://hg.mozilla.org/releases/l10n/mozilla-aurora/hy-AM/rev/124e62511b37
https://hg.mozilla.org/releases/l10n/mozilla-aurora/id/rev/51179c6c7bbd
https://hg.mozilla.org/releases/l10n/mozilla-aurora/is/rev/db38f62c94d8
https://hg.mozilla.org/releases/l10n/mozilla-aurora/it/rev/5d938b64f3e7
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ka/rev/6dd8289b61cc
https://hg.mozilla.org/releases/l10n/mozilla-aurora/kk/rev/19d4bcf33ee9
https://hg.mozilla.org/releases/l10n/mozilla-aurora/km/rev/1c2f18457b3d
https://hg.mozilla.org/releases/l10n/mozilla-aurora/kn/rev/2a3e83b786d3
https://hg.mozilla.org/releases/l10n/mozilla-aurora/lt/rev/c8cd52508bb0
https://hg.mozilla.org/releases/l10n/mozilla-aurora/lv/rev/e1922c72acec
https://hg.mozilla.org/releases/l10n/mozilla-aurora/mai/rev/df0b90538f33
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ml/rev/f03b0f0465c1
https://hg.mozilla.org/releases/l10n/mozilla-aurora/mr/rev/6e990cd6037e
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ms/rev/8596cb630a7e
https://hg.mozilla.org/releases/l10n/mozilla-aurora/my/rev/c58a4368051e
https://hg.mozilla.org/releases/l10n/mozilla-aurora/or/rev/f5a35d77c6ad
https://hg.mozilla.org/releases/l10n/mozilla-aurora/pt-BR/rev/cdab4bf97343
https://hg.mozilla.org/releases/l10n/mozilla-aurora/pt-PT/rev/34549532011d
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/rev/a466cfea8a2f
https://hg.mozilla.org/releases/l10n/mozilla-aurora/son/rev/8d11ee7a076c
https://hg.mozilla.org/releases/l10n/mozilla-aurora/sq/rev/351006fc2637
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ta/rev/760fd2a15881
https://hg.mozilla.org/releases/l10n/mozilla-aurora/th/rev/fb9bff6322ac
https://hg.mozilla.org/releases/l10n/mozilla-aurora/tr/rev/71045ad0beaa
https://hg.mozilla.org/releases/l10n/mozilla-aurora/uk/rev/194c4906bc5b
https://hg.mozilla.org/releases/l10n/mozilla-aurora/uz/rev/67f96c102918
https://hg.mozilla.org/releases/l10n/mozilla-aurora/vi/rev/4c2ffb9a2265
Missed one
https://hg.mozilla.org/releases/l10n/mozilla-aurora/nn-NO/rev/ab2b6456473f

Also updated l10n-central (pulled aurora's changesets) for en-GB, ja, ja-JP-mac, and transplanted changesets for nl and fy-NL.

If you work on l10n-central, please make sure that searchplugins are in sync.
url:        https://hg.mozilla.org/releases/l10n/mozilla-aurora/ru/rev/d6f8bcd52c79bc601b9a8d26f113eaf054b96257
changeset:  d6f8bcd52c79bc601b9a8d26f113eaf054b96257
user:       Alexander Slovesnik <unghost@mozilla-russia.org>
date:       Sat Aug 22 16:57:50 2015 +0300
description:
Bug 1179109 - [Android] Update searchplugin icon for Wikipedia (2nd version)
url:        https://hg.mozilla.org/releases/l10n/mozilla-beta/ru/rev/2455eaf7b3d1ad45d317182401218e6318af3a47
changeset:  2455eaf7b3d1ad45d317182401218e6318af3a47
user:       Alexander Slovesnik <unghost@mozilla-russia.org>
date:       Sat Aug 22 16:57:50 2015 +0300
description:
Bug 1179109 - [Android] Update searchplugin icon for Wikipedia (2nd version)
Depends on: 1208377
Hi Folks!
I have updated the search icons for Hungarian translation:
https://l10n.mozilla-community.org/~flod/p12n/bug1179109_highres_fennec/?channel=aurora

Is it possible to push it to beta or is it to late to do this?
(In reply to Kami from comment #44)
> Hi Folks!
> I have updated the search icons for Hungarian translation:
> https://l10n.mozilla-community.org/~flod/p12n/bug1179109_highres_fennec/
> ?channel=aurora
> 
> Is it possible to push it to beta or is it to late to do this?

@kami
I'm going to revert your last changeset: you can't make changes to your searchplugins without review, especially adding new ones.

Please file a bug and we can discuss the changes. In particular adding DDG like you did is just wrong, you're already shipping DDG through other systems.

Leaving a NI to make sure you're aware of the backout
Flags: needinfo?(kami911)
(In reply to Francesco Lodolo [:flod] from comment #45)
> Leaving a NI to make sure you're aware of the backout

Actually, filing a new bug directly since you made changes in basically all the projects.
Flags: needinfo?(kami911)
Attached file mozilla-hu.zip
Added hi-res icon form mobile search icons.
Depends on: 1218743
Depends on: 1250860
ca: Updated diec2.xml since they have a 256px favicon on the website (just centered the image and added rounded corners)
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ca/rev/eb525168fb95

hy-AM: same for list-am.xml (Armenian)
https://hg.mozilla.org/releases/l10n/mozilla-aurora/hy-AM/rev/413f29f370db

ko: found high-res icons at http://design.naver.com/viewContentsDetail?contentsId=22&barGubun=w
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ko/rev/4a9a3fbabe3b
ko: Fixed also daum.net starting from their 64px favicon. Will need to file a bug for danawa.com, since the icon on the website is completely different
https://hg.mozilla.org/releases/l10n/mozilla-aurora/ko/rev/bdea766e4252
Depends on: 1256283
lv: updated icons for salidzini.lv and ss.lv using assets available in their Facebook/Google Play pages
https://hg.mozilla.org/releases/l10n/mozilla-aurora/lv/rev/ea080de4657e

Will also file a bug to update icon for ss.lv on desktop, since the favicon is completely outdated.
Depends on: 1256369
Updated rediff.com. I tried to contact them but they haven't been responsive, used a suitable icon they're using in one of their Twitter accounts (the favicon only reaches 32px).
https://hg.mozilla.org/releases/l10n/mozilla-aurora/bn-IN/rev/af8673d186c1
https://hg.mozilla.org/releases/l10n/mozilla-aurora/mr/rev/56c88e7f6abc
Depends on: 1259461
Depends on: 1259907
Finally out of the way \o/
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.