119098 - NSPR tests don't build on OS/2

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Julien Pierre]

FYI, I was testing this on the tip of NSPR, not necessarily exactly the 
same as the browser branch.

When going to the obj directory and pr/tests, it's not possible to 
build the NSPR tests. The $(LINK) macro is not defined so linking 
cannot proceed.

In addition, the parameters passed on the link line are a mix of flags 
for icc and LINK386 that aren't all compatible.

It would be a good thing to get these tests to build and run as it is 
much easier to isolate and fix NSPR problems in small test cases than 
in a big application like the client.

Comment 1

[Julien Pierre]

I tried some quick hacks, hardcoding ILINK in place of $(LINK) in the generated
Makefile. That got some of the tests to link, but not all, in particular not the
tests that use multi-threaded library functions, as the default library that is
linked in is the single-threaded library.

Ideally we want to be using the ICC compiler to link, so some work has to be
done on the flags that are passed. I'm not certain where the origin of these
flags is in the source tree.

Comment 2

[timeless]

see also bug 118984.

Comment 3

[jhp (no longer active)]

Attachment: patch to build pr/tests

This patch correctly builds tests under OS/2 and Linux.  Removed include of
config.mk, since we already include the (newer) autoconf.mk.  Also, fixed up
the cleaning rules.

Comment 4

[Julien Pierre]

Javier,
Could you make your patch work with the tip of NSPR, rather than for the branch
used in the client ? This way I'll be able to test it and it will make it to the
next NSPR release.

Thanks

Comment 5

[Wan-Teh Chang]

Julien,

The tip and client branch of NSPR are pretty close right now,
so it's not necessary for Javier to generate a patch against
the tip of NSPR.

Comment 6

[Julien Pierre]

Wan-Teh,

They weren't close enough for this patch to merge unfortunately. I'll have to
take a more careful look to fix it.

Comment 7

[Mike Kaply [:mkaply]]

The only thing that is needed here is a one line change:

http://bugzilla.mozilla.org/attachment.cgi?id=90005&action=view

Please check it in.

Thanks

Comment 8

[Julien Pierre]

Attachment: Patch that applies to the NSPR tip

This follows's Mike's latest one-line patch suggestion and allows the tests to
build successfully on OS/2.

Comment 9

[Julien Pierre]

Attachment: patch to include debug information

Some of the compiler flags weren't getting passed properly. This patch includes
both the previous patch and a fix for that problem. Wan-Teh, please check it in
to the NSPR tip.

Comment 10

[Wan-Teh Chang]

Comment on attachment 90554 [details] [diff] [review]
patch to include debug information

mozilla/nsprpub/configure.in defines OS_EXE_CFLAGS but
the definition is not passed to mozilla/nsprpub/autoconf.mk.in,
so that definition is effectively a no-op.

I found that the values of CFLAGS and OS_EXE_CFLAGS
are identical in mozilla/nsprpub/configure.in, so it
seems that we should also remove the OS_EXE_CFLAGS line
in mozilla/nsprpub/configure.in.  (Similarly we should
remove the OS_CFLAGS line in mozilla/nsprpub/configure.in.)

Comment 11

[Wan-Teh Chang]

The patch has been checked into the tip and
NSPRPUB_PRE_4_2_CLIENT_BRANCH of NSPR.

I also recommend checking in this patch, which
removed the unused definitions of OS_CFLAGS and
OS_EXE_CFLAGS in mozilla/nsprpub/configure.in.
Could someone test it on OS/2?

Index: configure.in
===================================================================
RCS file: /cvsroot/mozilla/nsprpub/configure.in,v
retrieving revision 1.113
diff -u -r1.113 configure.in
--- configure.in        14 Jun 2002 05:05:59 -0000      1.113
+++ configure.in        9 Jul 2002 00:12:54 -0000
@@ -1747,8 +1747,6 @@
         AR_FLAGS='/NOL /NOI /O:$(subst /,\\,$@)'
         CFLAGS='/Q /qlibansi /Gd+ /Gm+ /Su4 /Mp /Tl9'
         HOST_CFLAGS="$CFLAGS"
-        OS_CFLAGS='/Q /qlibansi /Gd+ /Gm+ /Su4 /Mp /Tl9'
-        OS_EXE_CFLAGS='/Q /qlibansi /Gd+ /Gm+ /Su4 /Mp /Tl9'
         CXXFLAGS='/Q /qlibansi /Gd+ /Gm+ /Su4 /Mp /Tl9'
         OS_LIBS='so32dll.lib tcp32dll.lib'
         LD='-ilink'