1190988 - Hit testing appears to return incorrect positions when --enable-android-apz is specified.

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Randall Barker [:rbarker]]

Using the test page: http://bluemarvin.github.io/html/grid.html which will draw an 'X' where ever it is tapped, it appears that the hit testing is returning incorrect values when --enable-android-apz is specified because the 'X' is not drawn in the location of the tap. It seems that zoom may be a factor. When the page is zoomed all the way out. The tapping seems to work for the upper left quarter of the screen but not for the rest of the screen.

Comment 1

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1190988-Hit-testing-appears-to-return-incorrect-positions-when-enable-android-apz-is-specified-15080610-4271620.patch

Comment 2

[Randall Barker [:rbarker]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5350520180a

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8644461 [details] [diff] [review]
0001-Bug-1190988-Hit-testing-appears-to-return-incorrect-positions-when-enable-android-apz-is-specified-15080610-4271620.patch

Review of attachment 8644461 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/browser.js
@@ +441,5 @@
>      dump("zerdatime " + Date.now() + " - browser chrome startup finished.");
>  
>      this.deck = document.getElementById("browsers");
>  
> +    // This check and BrowserEventHandler should be removed once we have switched over to NAPZ

s/NAPZ/the C++ APZ code/

Comment 4

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1190988-Hit-testing-appears-to-return-incorrect-positions-when-enable-android-apz-is-specified-15080611-27fd153.patch

Carry forward r+ from :kats

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/90d854c1fb68

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/90d854c1fb68