1191038 - Remove the sound playing icon when the browser crashes

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[(no longer active)]

Currently after a crash, the sound playing icon stays there in the tab.  We should remove it.  See bug 1188548 comment 7.

Comment 1

[(no longer active)]

Attachment: Remove the sound playing icon from a tab when it crashes

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8643234 [details] [diff] [review]
Remove the sound playing icon from a tab when it crashes

Review of attachment 8643234 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/tabbrowser.xml
@@ +4252,5 @@
>            browser.docShell.displayLoadError(Cr.NS_ERROR_CONTENT_CRASHED, uri, null);
>            browser.removeAttribute("crashedPageTitle");
>            let tab = this.getTabForBrowser(browser);
>            tab.setAttribute("crashed", true);
> +          tab.removeAttribute("soundplaying");

Shouldn't the "muted" attribute be removed as well?

Comment 3

[(no longer active)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> Comment on attachment 8643234 [details] [diff] [review]
> Remove the sound playing icon from a tab when it crashes
> 
> Review of attachment 8643234 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/base/content/tabbrowser.xml
> @@ +4252,5 @@
> >            browser.docShell.displayLoadError(Cr.NS_ERROR_CONTENT_CRASHED, uri, null);
> >            browser.removeAttribute("crashedPageTitle");
> >            let tab = this.getTabForBrowser(browser);
> >            tab.setAttribute("crashed", true);
> > +          tab.removeAttribute("soundplaying");
> 
> Shouldn't the "muted" attribute be removed as well?

No, see bug 1188548.

I have filed bug 1191081 for the muted case.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a37ae6d18b39

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a37ae6d18b39

Comment 6

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Aurora 42.0a2 (buildID: 20150826004006).