Remove the sound playing icon when the browser crashes

VERIFIED FIXED in Firefox 42

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
Firefox 42
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 verified)

Details

Attachments

(1 attachment)

Assignee

Description

4 years ago
Currently after a crash, the sound playing icon stays there in the tab.  We should remove it.  See bug 1188548 comment 7.
Assignee

Updated

4 years ago
See Also: → 1188548
Assignee

Updated

4 years ago
Attachment #8643234 - Flags: review?(jaws)
Comment on attachment 8643234 [details] [diff] [review]
Remove the sound playing icon from a tab when it crashes

Review of attachment 8643234 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/tabbrowser.xml
@@ +4252,5 @@
>            browser.docShell.displayLoadError(Cr.NS_ERROR_CONTENT_CRASHED, uri, null);
>            browser.removeAttribute("crashedPageTitle");
>            let tab = this.getTabForBrowser(browser);
>            tab.setAttribute("crashed", true);
> +          tab.removeAttribute("soundplaying");

Shouldn't the "muted" attribute be removed as well?
Assignee

Comment 3

4 years ago
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> Comment on attachment 8643234 [details] [diff] [review]
> Remove the sound playing icon from a tab when it crashes
> 
> Review of attachment 8643234 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/base/content/tabbrowser.xml
> @@ +4252,5 @@
> >            browser.docShell.displayLoadError(Cr.NS_ERROR_CONTENT_CRASHED, uri, null);
> >            browser.removeAttribute("crashedPageTitle");
> >            let tab = this.getTabForBrowser(browser);
> >            tab.setAttribute("crashed", true);
> > +          tab.removeAttribute("soundplaying");
> 
> Shouldn't the "muted" attribute be removed as well?

No, see bug 1188548.

I have filed bug 1191081 for the muted case.
https://hg.mozilla.org/mozilla-central/rev/a37ae6d18b39
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using latest Aurora 42.0a2 (buildID: 20150826004006).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.