Closed Bug 1191153 Opened 5 years ago Closed 5 years ago

Use friendly reason names for GC causes

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

41 Branch
defect
Not set
normal

Tracking

(firefox42 fixed)

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Attachment #8644555 - Flags: review?(nfitzgerald)
Comment on attachment 8644555 [details] [diff] [review]
1191153-friendly-gc.patch

Review of attachment 8644555 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/test/unit/test_marker-utils.js
@@ +42,5 @@
> +  fields = Utils.getMarkerFields({ name: "GarbageCollection", cause: "ALLOC_TRIGGER" });
> +  equal(fields[0].value, "Too Many Allocations", "Uses L10N for GC reasons");
> +
> +  fields = Utils.getMarkerFields({ name: "GarbageCollection", cause: "NOT_A_GC_REASON" });
> +  equal(fields[0].value, "NOT_A_GC_REASON", "Defaults to enum for GC reasons when not L10N'd");

Good edge case for future compat, thanks!
Attachment #8644555 - Flags: review?(nfitzgerald) → review+
This landed this morning - https://hg.mozilla.org/mozilla-central/rev/a2bbe574dde2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.