Closed Bug 1191153 Opened 8 years ago Closed 8 years ago

Use friendly reason names for GC causes

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Version:
41 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file)

1191153-friendly-gc.patch
4.28 KB, patch
fitzgen
: review+
Details | Diff | Splinter Review 
      No description provided.

        Attachment #8644555 -
        Flags: review?(nfitzgerald)

    
    

    
  
Comment on attachment 8644555 [details] [diff] [review]
1191153-friendly-gc.patch

Review of attachment 8644555 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/performance/test/unit/test_marker-utils.js
@@ +42,5 @@
> +  fields = Utils.getMarkerFields({ name: "GarbageCollection", cause: "ALLOC_TRIGGER" });
> +  equal(fields[0].value, "Too Many Allocations", "Uses L10N for GC reasons");
> +
> +  fields = Utils.getMarkerFields({ name: "GarbageCollection", cause: "NOT_A_GC_REASON" });
> +  equal(fields[0].value, "NOT_A_GC_REASON", "Defaults to enum for GC reasons when not L10N'd");

Good edge case for future compat, thanks!

        Attachment #8644555 -
        Flags: review?(nfitzgerald) → review+

    
    

    
  
This landed this morning - https://hg.mozilla.org/mozilla-central/rev/a2bbe574dde2
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox42:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.