Closed
Bug 1191153
Opened 9 years ago
Closed 9 years ago
Use friendly reason names for GC causes
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Firefox 42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file)
|
4.28 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•9 years ago
|
Blocks: perf-allocations, perf-tools-fx42
Depends on: 1166524
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8644555 -
Flags: review?(nfitzgerald)
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8644555 [details] [diff] [review]
1191153-friendly-gc.patch
Review of attachment 8644555 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/performance/test/unit/test_marker-utils.js
@@ +42,5 @@
> + fields = Utils.getMarkerFields({ name: "GarbageCollection", cause: "ALLOC_TRIGGER" });
> + equal(fields[0].value, "Too Many Allocations", "Uses L10N for GC reasons");
> +
> + fields = Utils.getMarkerFields({ name: "GarbageCollection", cause: "NOT_A_GC_REASON" });
> + equal(fields[0].value, "NOT_A_GC_REASON", "Defaults to enum for GC reasons when not L10N'd");
Good edge case for future compat, thanks!
Attachment #8644555 -
Flags: review?(nfitzgerald) → review+
|
||
Comment 5•9 years ago
|
||
This landed this morning - https://hg.mozilla.org/mozilla-central/rev/a2bbe574dde2
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•