1191208 - KidFox: First-run screen for restricted profile

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Profile Handling, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

We'd like to show a different first-run screen if the user is using a restricted profile.

Bug 1180795 disabled the first-run screen for restricted profiles.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: restricted-first-run.png

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1191208-restricted-first-run.patch

This is a first WIP version. I return a different list of FirstrunPanels for a restricted profile. This way we can use a completely different layout for the first run screen but keep all the logic. Only requirement is that we keep the blue tab bar at the top (Title(s) can be different). We can even have multiple pages (later).

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: kidfox_firstrun_wip.png

This is an updated WIP version based on the UX work. Some of the metrics might need tweaking.

@Robin: Is this going into the right direction?

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: n7_firstrun.png

For comparison: This is the same screen on a smaller Nexus 7.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Depends on: bug 1189920 - I'll need the SUMO page for the "Learn more" link.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: kidfox_firstrun_white.png

White version.

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1191208_firstrun_wip.patch

This is the updated WIP patch (<-> kidfox_firstrun_white.png).

Already asking for feedback to reduce review time tomorrow. :)

Comment 8

[:Margaret Leibovic]

Comment on attachment 8644507 [details] [diff] [review]
1191208_firstrun_wip.patch

Chenxia knows this code well, so also asking her to take a look.

Comment 9

[Allison Naaktgeboren :ally]

All the kidfox specific bits look good to me. Deferring to Chenxia as the owner of first run. :)

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: kidfox_firstrun_n9.png

Screenshot of updated first run.

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1191208-kidfox-firstrun.patch

Final updated patch for review. :)

Comment 12

[:Margaret Leibovic]

Comment on attachment 8644885 [details] [diff] [review]
1191208-kidfox-firstrun.patch

Review of attachment 8644885 [details] [diff] [review]:
-----------------------------------------------------------------

In the spirit of rushing to land strings, I think this looks good enough to land, and we can address any feedback Chenxia has in a follow-up bug.

::: mobile/android/base/firstrun/RestrictedWelcomePanel.java
@@ +42,5 @@
> +
> +        root.findViewById(R.id.welcome_browse).setOnClickListener(new View.OnClickListener() {
> +            @Override
> +            public void onClick(View v) {
> +                Telemetry.sendUIEvent(TelemetryContract.Event.ACTION, TelemetryContract.Method.BUTTON, "firstrun-browser");

I don't think we should keep this probe the same as the probe for the browse link in the normal first run experience, since the context is different. Let's just remove this probe for now, and we can add in a probe if there's some explicit question we're trying to answer.

::: mobile/android/base/resources/layout/restricted_firstrun_welcome_fragment.xml
@@ +28,5 @@
> +            <TextView
> +                android:layout_width="350dp"
> +                android:layout_height="wrap_content"
> +                android:layout_gravity="center"
> +                android:background="#1aaa86"

Maybe we should add this to the color palette, in case we want to use it in other places in this restricted version of Firefox.

Comment 13

[Sebastian Kaspari (:sebastian; :pocmo)]

url:        https://hg.mozilla.org/integration/fx-team/rev/0d99513542f3233cccb0e04c7b337241b4dba68c
changeset:  0d99513542f3233cccb0e04c7b337241b4dba68c
user:       Sebastian Kaspari <[e-mail]>
date:       Fri Aug 07 21:01:00 2015 +0200
description:
Bug 1191208 - Custom first-run screen for restricted profiles. r=margaret

Comment 14

[Chenxia Liu [:liuche]]

Comment on attachment 8644885 [details] [diff] [review]
1191208-kidfox-firstrun.patch

Review of attachment 8644885 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/locales/en-US/android_strings.dtd
@@ +9,5 @@
>  <!ENTITY  onboard_start_message3 "Browse with &brandShortName;">
>  <!ENTITY  onboard_start_subtext3 "Make your mobile Web browsing experience truly your own.">
>  <!ENTITY  onboard_start_button_account "Sign in to &brandShortName;">
>  <!ENTITY  onboard_start_button_browser "Start Browsing">
> +<!ENTITY  onboard_start_restricted "Stay safe and in control with this simplified version of Firefox.">

We want this to match the channel right? In that case, we should use &brandName. I'll file and fix this, in bug 1192446.

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0d99513542f3

Comment 16

[Catalin Suciu [:csuciu]]

Verified that the first-run screen is displayed on Nightly and Aurora