1191276 - nodejs client should log the body of failed POSTs to Treeherder's API

Status: RESOLVED WONTFIX

(Tree Management Graveyard :: Treeherder: Client Libraries, defect, P3)

Description

[Ed Morley [:emorley]]

In bug 1187395, the logs in papertrail only included the URI for the POST to Treeherder's API.

If the response body had been printed in the log, the cause would have been clearer much earlier on.

ie when reproducing locally:

```
➜  treeherder git:(806b6f1) ✗ http post http://local.treeherder.mozilla.org/api/project/mozilla-inbound/jobs/ oauth_body_hash==abcdef oauth_consumer_key==abcdef oauth_nonce==abcdef oauth_signature_method==HMAC-SHA1 oauth_timestamp==1437751177 oauth_token== oauth_version==1.0 user==treeherder-node%200.5.0 oauth_signature==abcdef
HTTP/1.1 400 BAD REQUEST
Accept-Ranges: bytes
Age: 0
Allow: GET, POST, HEAD, OPTIONS
Connection: keep-alive
Content-Length: 60
Content-Type: application/json
Date: Tue, 04 Aug 2015 20:17:04 GMT
Server: WSGIServer/0.1 Python/2.7.10
Vary: Accept, Cookie
Via: 1.1 varnish
X-Varnish: 379080352

[
    "project treeherder-node%200.5.0 has no OAuth credentials"
]
```

...which is how Mauro discovered bug 1191252.

Comment 1

[Ed Morley [:emorley]]

Hmm I guess this needs to be fixed in the nodejs client?
In which case I'll move this to the Treeherder client's component (currently named for the python client, but due to be made generic in bug 1191241).

Comment 2

[MikeLing]

Hi Morley,

Actually, I found this bug from Bug 1196191 which depend on it. Could you tell me which part of code should I looking into if I want to work on this? I'm afraid I'm not very familiar with the codebase of treeherder client. Thank you!

Comment 3

[Ed Morley [:emorley]]

This bug is about the nodejs client (as opposed to the python client, which is in the main treeherder repo), which can be found at:
https://github.com/mozilla/treeherder-node

Comment 4

[Ed Morley [:emorley]]

 I think we should just deprecate the nodejs client.