Closed Bug 1191580 Opened 4 years ago Closed 4 years ago

Capitalize "Private Browsing" in about:privatebrowsing on normal tabs

Categories

(Firefox for Android :: Theme and Visual Design, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 42
Tracking Status
firefox42 --- verified

People

(Reporter: antlam, Assigned: mcomella)

References

Details

Attachments

(3 files)

Attached image prev_pb_aboutpb2.png
In bug 1157978, Matej Ok'd the copy but I noticed we capitalize "Private Browsing" in bug 1174242. 

I think we should update our about:privatebrowsing page to capitalize "Private Browsing" as well to be consistent. Is this something we should keep consistent Matej?
Flags: needinfo?(matej)
We should add localization notes as we update these strings, since capitalization conventions are different in different languages. In the note, we should verbalize what we're trying to achieve with the capitalization, so that localizers have more context to make the correct translation.
(In reply to Anthony Lam (:antlam) from comment #0)
> Created attachment 8644039 [details]
> prev_pb_aboutpb2.png
> 
> In bug 1157978, Matej Ok'd the copy but I noticed we capitalize "Private
> Browsing" in bug 1174242. 
> 
> I think we should update our about:privatebrowsing page to capitalize
> "Private Browsing" as well to be consistent. Is this something we should
> keep consistent Matej?

Yes. Good catch.

Alternately we could say "You are not in a private tab," which may be even more clear.
Flags: needinfo?(matej)
Awesome.

Martyn, since you touched this last, can we follow up? :D thanks!
Flags: needinfo?(mhaigh)
Pinging mcomella to get this moving :) for deadline concerns heh
Flags: needinfo?(michael.l.comella)
Bug 1191580 - Capitalize "Private Browsing" in about:privatebrowsing on non-private tabs. r=mfinkle
Attachment #8645176 - Flags: review?(mark.finkle)
Assignee: nobody → michael.l.comella
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(mhaigh)
Comment on attachment 8645176 [details]
MozReview Request: Bug 1191580 - Capitalize "Private Browsing" in about:privatebrowsing on non-private tabs. r=mfinkle

https://reviewboard.mozilla.org/r/15429/#review13813

Ship It!
Attachment #8645176 - Flags: review?(mark.finkle) → review+
url:        https://hg.mozilla.org/integration/fx-team/rev/30e0c3f20f2d7a8a8e75f191fe414ef57441bad6
changeset:  30e0c3f20f2d7a8a8e75f191fe414ef57441bad6
user:       Michael Comella <michael.l.comella@gmail.com>
date:       Fri Aug 07 14:05:55 2015 -0700
description:
Bug 1191580 - Capitalize "Private Browsing" in about:privatebrowsing on non-private tabs. r=mfinkle
https://hg.mozilla.org/mozilla-central/rev/30e0c3f20f2d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Verified as fixed using:
Device: Samsung S5 (Android 4.4.2)
Build: Firefox for Android 42.0a1 (2015-08-09)
flod, do you think this string would benefit from a localization note about the capitalization? Are notes okay to uplift? I believe this issue came up in the campaign call, but didn't make its way to this bug.
Flags: needinfo?(francesco.lodolo)
(In reply to :Margaret Leibovic from comment #10)
> flod, do you think this string would benefit from a localization note about
> the capitalization? Are notes okay to uplift? I believe this issue came up
> in the campaign call, but didn't make its way to this bug.

Uplifting localization notes is OK, it doesn't mess with tools and string freeze (you'll still need l10n=foo in the commit message to override the Mercurial hook).

As you wrote in comment 1, every language has (or should have) its own capitalization rules, unless they're blindly following en-US. For example we try to capitalize words as less as possible in Italian, sometimes we do for feature names, but it would eventually be the equivalent of "Private browsing", not "Private Browsing".

Having said that, a localization comment explaining the reasoning behind the en-US choice cannot hurt. Also useful to avoid any possible confusions about "brand" names (often when they see a capitalized name they think it's an untranslatable brand, like Sync or Hello).
Flags: needinfo?(francesco.lodolo)
Mike, can you land a follow-up note to explain the capitalization? Our l10n community will appreciate it! :)
Flags: needinfo?(michael.l.comella)
(In reply to :Margaret Leibovic from comment #12)
> Mike, can you land a follow-up note to explain the capitalization? Our l10n
> community will appreciate it! :)

bug 1196005.
Flags: needinfo?(michael.l.comella)
You need to log in before you can comment on or make changes to this bug.