1191580 - Capitalize "Private Browsing" in about:privatebrowsing on normal tabs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: prev_pb_aboutpb2.png

In bug 1157978, Matej Ok'd the copy but I noticed we capitalize "Private Browsing" in bug 1174242. 

I think we should update our about:privatebrowsing page to capitalize "Private Browsing" as well to be consistent. Is this something we should keep consistent Matej?

Comment 1

[:Margaret Leibovic]

We should add localization notes as we update these strings, since capitalization conventions are different in different languages. In the note, we should verbalize what we're trying to achieve with the capitalization, so that localizers have more context to make the correct translation.

Comment 2

[Matej Novak [:matej]]

(In reply to Anthony Lam (:antlam) from comment #0)
> Created attachment 8644039 [details]
> prev_pb_aboutpb2.png
> 
> In bug 1157978, Matej Ok'd the copy but I noticed we capitalize "Private
> Browsing" in bug 1174242. 
> 
> I think we should update our about:privatebrowsing page to capitalize
> "Private Browsing" as well to be consistent. Is this something we should
> keep consistent Matej?

Yes. Good catch.

Alternately we could say "You are not in a private tab," which may be even more clear.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Awesome.

Martyn, since you touched this last, can we follow up? :D thanks!

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Pinging mcomella to get this moving :) for deadline concerns heh

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1191580 - Capitalize "Private Browsing" in about:privatebrowsing on non-private tabs. r=mfinkle

Bug 1191580 - Capitalize "Private Browsing" in about:privatebrowsing on non-private tabs. r=mfinkle

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8645176 [details]
MozReview Request: Bug 1191580 - Capitalize "Private Browsing" in about:privatebrowsing on non-private tabs. r=mfinkle

https://reviewboard.mozilla.org/r/15429/#review13813

Ship It!

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

url:        https://hg.mozilla.org/integration/fx-team/rev/30e0c3f20f2d7a8a8e75f191fe414ef57441bad6
changeset:  30e0c3f20f2d7a8a8e75f191fe414ef57441bad6
user:       Michael Comella <[e-mail]>
date:       Fri Aug 07 14:05:55 2015 -0700
description:
Bug 1191580 - Capitalize "Private Browsing" in about:privatebrowsing on non-private tabs. r=mfinkle

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/30e0c3f20f2d

Comment 9

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-08-10-12-31-06.png

Verified as fixed using:
Device: Samsung S5 (Android 4.4.2)
Build: Firefox for Android 42.0a1 (2015-08-09)

Comment 10

[:Margaret Leibovic]

flod, do you think this string would benefit from a localization note about the capitalization? Are notes okay to uplift? I believe this issue came up in the campaign call, but didn't make its way to this bug.

Comment 11

[Francesco Lodolo [:flod]]

(In reply to :Margaret Leibovic from comment #10)
> flod, do you think this string would benefit from a localization note about
> the capitalization? Are notes okay to uplift? I believe this issue came up
> in the campaign call, but didn't make its way to this bug.

Uplifting localization notes is OK, it doesn't mess with tools and string freeze (you'll still need l10n=foo in the commit message to override the Mercurial hook).

As you wrote in comment 1, every language has (or should have) its own capitalization rules, unless they're blindly following en-US. For example we try to capitalize words as less as possible in Italian, sometimes we do for feature names, but it would eventually be the equivalent of "Private browsing", not "Private Browsing".

Having said that, a localization comment explaining the reasoning behind the en-US choice cannot hurt. Also useful to avoid any possible confusions about "brand" names (often when they see a capitalized name they think it's an untranslatable brand, like Sync or Hello).

Comment 12

[:Margaret Leibovic]

Mike, can you land a follow-up note to explain the capitalization? Our l10n community will appreciate it! :)

Comment 13

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to :Margaret Leibovic from comment #12)
> Mike, can you land a follow-up note to explain the capitalization? Our l10n
> community will appreciate it! :)

bug 1196005.