Closed Bug 1191606 Opened 4 years ago Closed 4 years ago

[Contacts][Import] Contact thumbnails are improperly cropped to the upper left portion of the image on the import screen.

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.5+, b2g-master verified)

VERIFIED FIXED
FxOS-S7 (18Sep)
blocking-b2g 2.5+
Tracking Status
b2g-master --- verified

People

(Reporter: Marty, Assigned: arcturus)

References

Details

(Whiteboard: [NG Gaia Contacts][patch][2.5-Daily-Testing][Spark])

Attachments

(3 files)

Attached image Import_Screenshots.jpg
Description:
When a contact with an associated image is imported (via Bluetooth or MMS), the import screen will show a thumbnail next to the contact, however the visible thumbnail will only be part of the upper left portion of the image. This is generally not a large enough portion of the image for the thumbnail to make any real sense to the user.

Note:
-The full image is still imported properly with the contact, and the list in the Contacts app will generate an appropriate thumbnail for the imported contact.

Repro Steps:
1) Update a Aries to 20150804120650
2) Enable Bluetooth in Settings
3) From another device, transfer a contact with a picture via Bluetooth to the DUT
4) View the contact import confirmation screen.

Actual:
The importing contact's thumbnail only shows the very upper left portion of the image.

Expected:
The importing contact's thumbnail properly displays the image the same way it will be displayed in the main Contact list after it has been imported.

Environmental Variables:
Device: Aries 2.5
Build ID: 20150804120650
Gaia: 67c38af8347f93ddc005a53f427d651b744b55c1
Gecko: 5cf4d2f7f2f2
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 10/10
See attached: screenshot, logcat
Attached file logcat_import.txt
This issue DOES occur on Flame 2.5 builds.
The importing contact's thumbnail only shows the very upper left portion of the image.

Environmental Variables:
Device: Flame 2.5
Build ID: 20150805030212
Gaia: c5425d9f1f5184731a59ed4bc99295acbde30390
Gecko: f3b757156f69
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

------------------------------------------------

This issue does NOT occur on Flame 2.2 builds.
This issue occurs in a new version of the import screen that is not implemented in this branch.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
[Blocking Requested - why for this release]: Broken new feature.
blocking-b2g: --- → 2.5?
Assignee: nobody → fernando.campo
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
I have just verified that this bug is a regression introduced when landing bug 1184075, as part of the NGA work. Fernando will work on it to fix it.
Blocks: 1184075
Status: NEW → ASSIGNED
Whiteboard: [2.5-Daily-Testing][Spark] → [NG Gaia Contacts][2.5-Daily-Testing][Spark]
Target Milestone: --- → FxOS-S4 (07Aug)
Comms triage: Broken new feature.
blocking-b2g: 2.5? → 2.5+
Target Milestone: FxOS-S4 (07Aug) → FxOS-S5 (21Aug)
Any progress here?
Attachment #8650456 - Flags: review?(borja.bugzilla)
Assignee: fernando.campo → francisco
Whiteboard: [NG Gaia Contacts][2.5-Daily-Testing][Spark] → [NG Gaia Contacts][patch][2.5-Daily-Testing][Spark]
Target Milestone: FxOS-S5 (21Aug) → FxOS-S6 (04Sep)
Comment on attachment 8650456 [details] [review]
[gaia] arcturus:bug-1191606 > mozilla-b2g:master

Based on the CSS, should we define width&height as well?

On the other hand I can not see any picture in master... do you have any idea if there is any other bug colliding with this one? Thanks!
Attachment #8650456 - Flags: review?(borja.bugzilla)
Marking as a P2
Priority: -- → P2
Target Milestone: FxOS-S6 (04Sep) → FxOS-S7 (18Sep)
Don't see the need of defining with and height here.

I'm ni myself to double check this bug, it's been on the queue for a while and we could have any problem, but last time i tried this, on the importers we could see the pictures.
Flags: needinfo?(francisco)
Comment on attachment 8650456 [details] [review]
[gaia] arcturus:bug-1191606 > mozilla-b2g:master

I can see this working ok, the stk include importing a vcf file from bluetooth or via mms. The contact on the vcf must have a photo.

Then the list with the content of the vcf file should appear and you should see the images centered.
Flags: needinfo?(francisco)
Attachment #8650456 - Flags: review?(borja.bugzilla)
PR update with the changes requested.

Now we have a tiny css to share some properties.
Flags: needinfo?(borja.bugzilla)
Flags: needinfo?(borja.bugzilla)
Attachment #8650456 - Flags: review?(borja.bugzilla) → review+
This issue is verified fixed on the latest Flame and Aries 2.5 Master builds.
The full contact thumbnails are displayed when importing contacts via MMS or Bluetooth. These thumbnails display the same at the import screen as they do at the main Contacts menu.

Environmental Variables:
Device: Aries 2.5
BuildID: 20150918122511
Gaia: 4f22dfecdc046fe5223ee858dd06c11b75884740
Gecko: 37c7812ce0e6d10c7e7182f12e752832835e1d67
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Environmental Variables:
Device: Flame 2.5
BuildID: 20150918030223
Gaia: 4f22dfecdc046fe5223ee858dd06c11b75884740
Gecko: 11dc79e232110ba6de5179e46dfbda77b52a88c3
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(jmercado)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmercado)
You need to log in before you can comment on or make changes to this bug.