1184075 - [NGA][Contacts] Normalize behaviour for IMPORT and OPEN activities

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Fernando Campo (:fcampo)]

First step on the revamp is to make both activities follow the same guidelines when loading contacts from vcards.

Steps will be common for both, independently if the vcard comes from email, sms, nfc or BT, as follows:
- read all the contacts from the vcard (same as before)
- show all new contacts in a custom list (before was presenting info if multiple contacts detected, open 'details'/'new contact' if only one contact present)
- allow to import all, or none if cancel (same as OPEN before. for IMPORT was save first, show later)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] fcampo:open_import_normalize > mozilla-b2g:master

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8635248 [details] [review]
[gaia] fcampo:open_import_normalize > mozilla-b2g:master

Codewise is looking good to me, but when I try this:

- Go to sms and add an attachment.
- Select contacts, to attach a contact as a vcard
- Press on the vcard attachment in the sms app and select the comms app

Expected:
Opening the new import activity.

Result:
Unknown file is openend.

Comment 3

[Fernando Campo (:fcampo)]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #2)
> Comment on attachment 8635248 [details] [review]
> [gaia] fcampo:open_import_normalize > mozilla-b2g:master
> 
> Codewise is looking good to me, but when I try this:
> 
> - Go to sms and add an attachment.
> - Select contacts, to attach a contact as a vcard
> - Press on the vcard attachment in the sms app and select the comms app
> 
> Expected:
> Opening the new import activity.
> 
> Result:
> Unknown file is openend.
That is kinda weird, I tried and I can see the file opening as expected. I rebased the patch with latest master just in case.

Maybe the build can have something to do with it?

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8635248 [details] [review]
[gaia] fcampo:open_import_normalize > mozilla-b2g:master

I've just flashed latest m-c and cannot reproduce my previous comment.

Since that was the only thing that was stopping the r+ granting it now.

Comment 5

[Fernando Campo (:fcampo)]

After couple of retriggers, all green and merged - https://github.com/mozilla-b2g/gaia/commit/5e31fb6f88cd8c42e53214183defa2ffd455ea00

Comment 6

[Martin Shuman [:Marty]]

This issue is Verified Fixed on the latest Flame and Spark 2.5 builds.
Importing contacts from Email (single and multiple contacts), Downloads (single and multiple), Bluetooth (single and multiple), MMS, and NFC all produce the same Import confirmation screen upon opening the vcard.

Environmental Variables:
Device: Flame 2.5 (319MB)
Build ID: 20150804030213
Gaia: caba8b26c52d3c771e9ea6fe288acdaf74c7707e
Gecko: 5b54831761b1
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Environmental Variables:
Device: Aries 2.5
Build ID: 20150804120650
Gaia: 67c38af8347f93ddc005a53f427d651b744b55c1
Gecko: 5cf4d2f7f2f2
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0