1191748 - Add-on has no validator warnings that would prevent signing yet it is not auto approved

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Andreas Wagner [:TheOne] [use NI]]

This is the second occurrence I encouter (can't remember the first one), but https://addons.mozilla.org/en-US/editors/review/eastons-testing-agent pending prelim review is not auto-approved yet the validation report https://addons.mozilla.org/en-US/developers/addon/eastons-testing-agent/file/333940/validation does not show any warnings that would explain why.

Comment 1

[Andreas Wagner [:TheOne] [use NI]]

Also, that add-on suddenly appeared at the top of the unlisted prelim queue with a waiting time of 34 days, so I think the authors switched from listed to unlisted. Maybe that's why it did not get auto-approved?

Might that also be the reason for bug 1191752?

Comment 2

[Mathieu Agopian [:magopian]]

If they switched from listed to unlisted, they were not offered the automatic validation.

Comment 3

[Andreas Wagner [:TheOne] [use NI]]

(In reply to Mathieu Agopian [:magopian] from comment #2)
> If they switched from listed to unlisted, they were not offered the
> automatic validation.

Should we consider it? I've seen quite a few developers do that apparently because they hope their add-on will get reviewed faster...

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Switching to unlisted should be very similar to submitting a new unlisted entry, so I agree there should be automatic approval when appropriate.

Comment 5

[Kris Maglione [:kmag]]

I thought the plan was for any existing add-ons to be disabled, and then for every future submission to be treated as a normal unlisted submission.

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

If there's a version pending review, I think it makes sense to assume that it was intended to be submitted as unlisted when the developer does the switch. However, I don't think it would be terrible to disable that version as long as we tell the developer to submit again.

Comment 7

[Kris Maglione [:kmag]]

The problem is that listed and unlisted add-ons go through a different set of validations. Also, one is expected to have an updateURL while the other is forbidden, so I wouldn't expect a pending listed version to be accepted for signing, or vice versa.

Comment 8

[Andreas Wagner [:TheOne] [use NI]]

(In reply to Jorge Villalobos [:jorgev] from comment #6)
> If there's a version pending review, I think it makes sense to assume that
> it was intended to be submitted as unlisted when the developer does the
> switch. However, I don't think it would be terrible to disable that version
> as long as we tell the developer to submit again.

I think that would solve some side effects as well, for example that the pending version shows up in the "Updates" queue with a waiting time of the original submission date, rather than showing up at the bottom of the "Full" or "Preliminary" unlisted queue.

Comment 9

[Mathieu Agopian [:magopian]]

Closing this as it was decided we won't be implementing the switch from unlisted to listed, and will remove the switch from listed to unlisted.

See bug 1200777, bug 1200779 and bug 1200785