1191922 - comm-esr38 mozmill tests will not run

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

This is fallout from bug 917999. After we merged in the needed m-esr38 changesets to generate the right files, we are bitten by the fact that comm-esr38 is not using mozharness to run the mozmill builds.

There are two options, either we attempt to enable mozharness for comm-esr38, or I fix the buildbot code to download the right tests. This will most likely need to happen at http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#4239

I'd prefer trying the mozharness route though. I'd like someone to approve this before I attempt to do it though.

Comment 1

[Magnus Melin [:mkmelin]]

Sounds good to me. You know a lot more about this than I do, so I trust your judgement.

Comment 2

[Joshua Cranmer [:jcranmer]]

(In reply to Philipp Kewisch [:Fallen] from comment #0)
> This is fallout from bug 917999. After we merged in the needed m-esr38
> changesets to generate the right files, we are bitten by the fact that
> comm-esr38 is not using mozharness to run the mozmill builds.
> 
> There are two options, either we attempt to enable mozharness for
> comm-esr38, or I fix the buildbot code to download the right tests. This
> will most likely need to happen at
> http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#4239
> 
> I'd prefer trying the mozharness route though. I'd like someone to approve
> this before I attempt to do it though.

I know I moved to make mozmill support mozharness on TB 38 precisely so that we could enable mozharness tests on esr38 if need be. There might need to be a test fixup (see bug 1152287), but otherwise I think everything should work.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

This should do it. I was tempted to just remove the whole block, but I think we should rather clean up all of esr31 separately.

Comment 4

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8648410 [details] [diff] [review]
Fix - v1

Review of attachment 8648410 [details] [diff] [review]:
-----------------------------------------------------------------

I see no problem with this, but I strictly speaking don't have r+ authority over releng code...

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 8648410 [details] [diff] [review]
Fix - v1

Review of attachment 8648410 [details] [diff] [review]:
-----------------------------------------------------------------

xtra review from a relenger, for sanity

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Thanks, lets hope it works!

https://hg.mozilla.org/build/buildbot-configs/rev/9a7663d6a13e

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

This is merged to production now, running a build to verify.