Closed Bug 1191929 Opened 9 years ago Closed 9 years ago

Crash attempting to remove suggested sites

Categories

(Firefox for iOS :: Home screen, defect)

Product:
Firefox for iOS
Component:
Home screen
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: aaronmt, Assigned: atulagrwl)

References

Details

(Keywords: crash)

Attachments

(3 files, 1 obsolete file)

Screen Shot 2015-08-06 at 2.09.23 PM.png
100.50 KB, image/png
Details
Client 2015-08-06, 2-05 PM.crash
48.77 KB, text/plain
Details
Pull request
47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review 
While trying to reproduce Aurora #29 startup crashes I ran into another crash

* Have multiple top-sites on about:home
* Enter edit-mode on the top-site tiles
* Clear Private Data
* Return to about:home

See screenshot (shouldn't be able to nuke that default)

* Delete that default

* Crash *
Attached file Client 2015-08-06, 2-05 PM.crash (obsolete) — 

    
  

        Attachment #8644489 -
        Attachment is obsolete: true

    
    

    
  


  
re-symbolicated

          tracking-fxios:
          ? → +
Component: General → Home screen
Hardware: ARM → All
Summary: Crash in removing the default bookmarks → Crash attempting to remove suggested sites

    
    

    
  
Dupe of bug 1183856, except we tracking-minused that one...

    
    

    
  
Worthy of investigating if this kind of contributing to the #29 startup crashes (it was for me)

    
    

    
  
bkmunar and I can repro this crash, but there's no startup crash after. Might have just been an unlucky coincidence that you hit a startup crash with this -- would you mind trying again to verify?
Flags: needinfo?(aaron.train)

    
    

    
  
Looks to the be case
Flags: needinfo?(aaron.train)

    
  
Assignee: nobody → atulagrwl
Status: NEW → ASSIGNED

    
    

    
  

      
      
      
      

        Attached file
          
        Pull request
        — 
      

    


  

        Attachment #8645385 -
        Flags: review?(bnicholson)

    
    

    
  
Reason was the recycling of cell for suggested cell in which we were not remove remove button. 
Due to this button this cell can be removed and Crash was happening because number of cell after the deletion was not matching with number of cell which should collectionView(collectionView: UICollectionView, numberOfItemsInSection section: Int) was returning.

Fix is quite simple and created a pull request for the same.

    
    

    
  
Comment on attachment 8645385 [details] [review]
Pull request

Looks good. Thanks for the fix!

        Attachment #8645385 -
        Flags: review?(bnicholson) → review+

    
    

    
  
https://github.com/mozilla/firefox-ios/commit/12ae8d357272b073490cf5bd048dd3e6729337a1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: