1191931 - Add tests for using `pushManager` from a worker

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Comment 1

[Lina Butler (ex-Mozilla)]

Attachment: 1191931.patch

Comment 2

[Lina Butler (ex-Mozilla)]

Attachment: MozReview Request: Bug 1191931, Part 1 - Use tasks in the Push subscription tests. r?mt

Review commit: https://reviewboard.mozilla.org/r/32695/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32695/

Comment 3

[Lina Butler (ex-Mozilla)]

Attachment: MozReview Request: Bug 1191931, Part 2 - Test resubscribing from a worker. r?mt

Review commit: https://reviewboard.mozilla.org/r/32773/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32773/

Comment 4

[Martin Thomson [:mt:]]

Comment on attachment 8713220 [details]
MozReview Request: Bug 1191931, Part 1 - Use tasks in the Push subscription tests. r?mt

https://reviewboard.mozilla.org/r/32695/#review29605

::: dom/push/test/test_register.html:41
(Diff revision 1)
> -  function checkPermissionState(swr) {
> -    return swr.pushManager.permissionState().then(function(state) {
> -      ok(state === "granted", "permissionState() should resolve to granted.");
> +  var controlledFrame;
> +  add_task(function* createControlledIFrame() {
> +    controlledFrame = yield injectControlledIFrame();

I wonder if you might not go a little further with this change and make the "controlledFrame" variable a wrapper.  The call to controlledFrame.contentWindow.waitOnPushMessage() might be wrapped more cleanly, or even combined with the push itself.  And the controlledFrame.parentNode.removeChild() call might be turned into a .remove() function.

It's not much, so your call.

Comment 5

[Martin Thomson [:mt:]]

Comment on attachment 8713221 [details]
MozReview Request: Bug 1191931, Part 2 - Test resubscribing from a worker. r?mt

https://reviewboard.mozilla.org/r/32773/#review29607

::: dom/push/test/worker.js:93
(Diff revision 1)
> +    }).then(subscription => {
> +      return {
> +        endpoint: subscription.endpoint,
> +      };
>      }));

Hmm, this reminds me, are we able to structured clone subscriptions.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/02bcedf966fd
https://hg.mozilla.org/integration/mozilla-inbound/rev/6df33c3ef63b

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/02bcedf966fd
https://hg.mozilla.org/mozilla-central/rev/6df33c3ef63b

Comment 8

[Pulsebot]

Backout:
https://hg.mozilla.org/mozilla-central/rev/0bbe95efaa7f
https://hg.mozilla.org/mozilla-central/rev/4d224eb47901

Comment 9

[Carsten Book [:Tomcat]]

backed out since we still have perma failures like https://treeherder.mozilla.org/logviewer.html#?job_id=3216622&repo=mozilla-central

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e8c9326500b
https://hg.mozilla.org/integration/mozilla-inbound/rev/d95ddccaece5

Comment 11

[Lina Butler (ex-Mozilla)]

Re-landing for now. We might still see intermittent oranges, since we're talking to the production server. Bug 1244816 tracks the work to switch us to mocks. I'm sorry for the trouble, Tomcat.

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9e8c9326500b
https://hg.mozilla.org/mozilla-central/rev/d95ddccaece5

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1e1d298ce609
https://hg.mozilla.org/releases/mozilla-aurora/rev/20fd8603e83d