1191974 - Bad localization comment for "Send Feedback" string

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Plewako [:stef]]

The comment is probably completely wrong and describes an effect of using this piece of UI and not UI element itself.

https://github.com/mozilla/firefox-ios/commit/83a57d6e992f8fb5d9bc15ad288eb9e5a7cb5b2a#diff-6209ecb7e871159425f66f16eed90d7dR452

Comment 1

[Francesco Lodolo [:flod]]

Current comment: "Show an input.mozilla.org page where people can submit feedback"

Would "Menu item in settings used to open input.mozilla.org where people can submit feedback" work better?

As a general approach, it would be really helpful to propose an alternative of what would work better in your opinion.

Comment 2

[Stefan Plewako [:stef]]

(In reply to Francesco Lodolo [:flod] from comment #1)
> Current comment: "Show an input.mozilla.org page where people can submit
> feedback"
> 
> Would "Menu item in settings used to open input.mozilla.org where people can
> submit feedback" work better?

How would I know? From bug 1191866? Not really. From https://github.com/mozilla/firefox-ios/pull/873? Not really. If it is list item than fine, if it is a link than absolutely not.

> As a general approach, it would be really helpful to propose an alternative
> of what would work better in your opinion.

How I'm supposed to provide something other than in comment #0 without becoming development team?

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Stefan Plewako [:stef] from comment #2)
> How I'm supposed to provide something other than in comment #0 without
> becoming development team?

You can ask to developers in the bug to explain where this string is used, since the comment is not helpful or plainly confusing. The development team doesn't have infinite resources, and doesn't always understand how a good localization comment should look like; the least that we can do is a) assume good intentions and b) try to help them.

Comment 4

[Jeff Beatty [:gueroJeff]]

(In reply to Stefan Plewako [:stef] from comment #2)
> (In reply to Francesco Lodolo [:flod] from comment #1)
> > Current comment: "Show an input.mozilla.org page where people can submit
> > feedback"
> > 
> > Would "Menu item in settings used to open input.mozilla.org where people can
> > submit feedback" work better?
> 
> How would I know? From bug 1191866? Not really. From
> https://github.com/mozilla/firefox-ios/pull/873? Not really. If it is list
> item than fine, if it is a link than absolutely not.
> 
> > As a general approach, it would be really helpful to propose an alternative
> > of what would work better in your opinion.
> 
> How I'm supposed to provide something other than in comment #0 without
> becoming development team?

Hi Stef,

Usually, when filing any bug, you should identify the expected "behavior." In the case of string comments, that is done by providing an alternative suggestion. That helps the dev team to not get stuck guessing what your expecting to find in a more accurate comment.

Thanks,
Jeff

Comment 5

[Stefan Plewako [:stef]]

(In reply to Francesco Lodolo [:flod] from comment #3)
> You can ask to developers in the bug to explain where this string is used,
> since the comment is not helpful or plainly confusing.

Commenting in a closed bug is not helpful and a wast of time usually. Please stop suggesting that.

> The development team
> doesn't have infinite resources, and doesn't always understand how a good
> localization comment should look like; the least that we can do is a) assume
> good intentions and b) try to help them.

I have no idea what is this about. I pointed quite clearly the problem in this followup bug. 10 months is more than enough to ask about unclear aspects in reported problem.

(In reply to Jeff Beatty [:gueroJeff] from comment #4)
> Usually, when filing any bug, you should identify the expected "behavior."
> In the case of string comments, that is done by providing an alternative
> suggestion. That helps the dev team to not get stuck guessing what your
> expecting to find in a more accurate comment.

Please understand that by not being part of the development team and not having access to the materials that team is using in development (ios bugs and pull requests usually lack all info besides raw code) there is not much else external contributor could do to help in such closed process.

EOT

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Stefan Plewako [:stef] from comment #5)
> Commenting in a closed bug is not helpful and a wast of time usually. Please
> stop suggesting that.
You should really try re-reading your comment, hopefully you'll realize how rude your reply sounds. If that sounds perfectly acceptable to you, then I'm afraid I can't really help.

Asking actionable items in a closed bug is not helpful, asking clarifications before filing follow-up bugs definitely is.

Comment 7

[Jeff Beatty [:gueroJeff]]

(In reply to Stefan Plewako [:stef] from comment #5)
> (In reply to Francesco Lodolo [:flod] from comment #3)
> > You can ask to developers in the bug to explain where this string is used,
> > since the comment is not helpful or plainly confusing.
> 
> Commenting in a closed bug is not helpful and a wast of time usually. Please
> stop suggesting that.
> 
> > The development team
> > doesn't have infinite resources, and doesn't always understand how a good
> > localization comment should look like; the least that we can do is a) assume
> > good intentions and b) try to help them.
> 
> I have no idea what is this about. I pointed quite clearly the problem in
> this followup bug. 10 months is more than enough to ask about unclear
> aspects in reported problem.
> 
> (In reply to Jeff Beatty [:gueroJeff] from comment #4)
> > Usually, when filing any bug, you should identify the expected "behavior."
> > In the case of string comments, that is done by providing an alternative
> > suggestion. That helps the dev team to not get stuck guessing what your
> > expecting to find in a more accurate comment.
> 
> Please understand that by not being part of the development team and not
> having access to the materials that team is using in development (ios bugs
> and pull requests usually lack all info besides raw code) there is not much
> else external contributor could do to help in such closed process.
> 
> EOT

Hi Stef,

Without suggestions for alternative comments, I think we'll have to just close these bugs. Otherwise, we're all stuck trying to guess what you're thinking, and that's not productive for anyone. An alternative option for you is to skip the bug all together and submit a pull request with a new, improved comment.

Could you describe what additional materials you would need in order to provide such suggested alternatives? If there's a way we can be more open, it would be great to know so that we can improve. Thanks for your help.
Jeff

Comment 8

[Stefan Plewako [:stef]]

(In reply to Jeff Beatty [:gueroJeff] from comment #7)
> Could you describe what additional materials you would need in order to
> provide such suggested alternatives? If there's a way we can be more open,
> it would be great to know so that we can improve.

Screenshots in bugs, prototypes, designs, discussions about details and basically anything that makes possible to learn how the string is exactly used (without knowing the code or compiling it)

Comment 9

[Francesco Lodolo [:flod]]

Comments updated as part of 
https://github.com/mozilla/firefox-ios/commit/99ea79a58b307a641a2cde0d94cf6d226ce8212f