1277326 - [meta] [tracking] iOS localization issues for 5.0

Status: RESOLVED FIXED

(Firefox for iOS :: Localization, defect)

Description

[Francesco Lodolo [:flod]]

Meta tracking bug for l10n/i18n issues discovered in Firefox for iOS 5.0

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Improve localization comments

This covers a few of the dependent bugs:

Bug 1235602 - Improve localization for string "Preview of %@"
Bug 1235608 - Improve localization comments for Passcode strings
Bug 1257204 - Improve localization comment for the Delete button in login manager
Bug 1238146 - Improve localization comment for empty Sync panel
Bug 1191974 - Improve localization comment for "Send Feedback"
Bug 1273961 - Improve localization comments for Menu strings

@st3fan
Do you want to double check, or find another suitable reviewer in the team?

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8759086 [details] [review]
Improve localization comments

LGTM

Comment 3

[Francesco Lodolo [:flod]]

Change landed in
https://github.com/mozilla/firefox-ios/commit/99ea79a58b307a641a2cde0d94cf6d226ce8212f

Comment 4

[Stephan Leroux [:sleroux]]

v5.x 68302608335f698138de76b5f21b48c73fd4f9d7

Comment 5

[Francesco Lodolo [:flod]]

One comment slipped out for "Delete" (I fixed one, but not the second)
https://github.com/mozilla-l10n/firefoxios-l10n/blob/19a31929c0ba515aac24a3a584ace177136b0e62/en-US/firefox-ios.xliff#L2043-L2048

I'll take care of it as soon as I have an answer in bug 1238151.

Comment 6

[Francesco Lodolo [:flod]]

Ongoing work in this branch
https://github.com/flodolo/firefox-ios/commits/followup_comments

The first step to make clearer comments would be to stop using "title" as a synonym for "label" or "text". A title is a specific element of the UI, that's really confusing, especially in things like "title for the button".

Comment 7

[Francesco Lodolo [:flod]]

Attachment: Improve other localization comments

r? Brian this time (slowly going through all iOS devs :-)), since it covers the discussion in bug 1238151.

Also improved localization comment for Home page setting, given the question in dev-l10n right after extracting string.

Comment 8

[Brian Nicholson (:bnicholson)]

Comment on attachment 8759780 [details] [review]
Improve other localization comments

Added a comment about sharing UIConstants.CancelString everywhere since it seems like that's really what we want. Besides that, looks fine to me!

Comment 9

[Francesco Lodolo [:flod]]

Thanks Brian, as explained in the PR it's not safe for me to touch real code in .swift file, so I'll merge the changeset as it is. I'd also like this change to be ported to v5.x.

Feel free to file a follow-up to fix that though.

master: 540782100fc1dd0787b632b2850ce7a8c6ac227e

https://github.com/mozilla/firefox-ios/commit/540782100fc1dd0787b632b2850ce7a8c6ac227e

Comment 10

[Stephan Leroux [:sleroux]]

Additional patch v5.x 13429dec7f609d03d5e195bc63de0ec90643b7f7

Comment 11

[Francesco Lodolo [:flod]]

Since 5.0 shipped, closing this one. Pending bug should be moved to a tracker for next release.