1192004 - Let Firefox Account avatars ride the trains in Fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Nick Alexander :nalexander [he/him]]

Avatars are behind a build flag, preffed on only in Nightly for now.  This ticket tracks flipping the switch and letting them ride the trains.

Comment 1

[Nick Alexander :nalexander [he/him]]

Edwin, Kevin: can I get some focused testing for this feature?  I think the following tests are sufficient.

1) create Firefox Account on Desktop; configure avatar image.  (There's UX for this in Desktop Nightly -- go to the Sync preferences and click the avatar image.)
2) install recent Fennec Nightly;
3) connect Fennec to Firefox Account;
4) go to Fennec > Settings > Sync and force a sync;
5) observe avatar image downloaded and displayed.

As a separate test:

6) kill and re-open Fennec;
7) go to Fennec > Settings > Sync;
8) observe avatar image downloaded and displayed.  (May flicker if it re-downloads.)

Now:

9) return to Desktop; change avatar image to a new photo.
10) return to Fennec;
11) go to Fennec > Settings > Sync, force Sync;
12) observe updated avatar image downloaded and displayed.

Comment 2

[Edwin Wong [:edwong]]

Peter - do you have any cycles for this - I'll investigate why the avatar isn't showing on my install of nightly.

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1192004 - Enable Firefox Account avatars in Fennec release builds. r?margaret

Bug 1192004 - Enable Firefox Account avatars in Fennec release builds. r?margaret

Comment 4

[Nick Alexander :nalexander [he/him]]

I got confirmation this was working in #fxa, from Edwin and another tester.  Leaving the flag for kbrosnan so he's aware of this new Fennec functionality.

Comment 5

[Nick Alexander :nalexander [he/him]]

[Tracking Requested - why for this release]: Desktop parity.

Comment 6

[:Margaret Leibovic]

Comment on attachment 8645829 [details]
MozReview Request: Bug 1192004 - Enable Firefox Account avatars in Fennec release builds. r?margaret

https://reviewboard.mozilla.org/r/15551/#review14035

Ship It!

Comment 7

[:Margaret Leibovic]

bbermes, we should probably make sure this is tracked in the product roadmap.

Comment 8

[Barbara Bermes [:barbara] - NI please!]

margaret, this is going out for 42? 

I'm thinking about the dates and all the deadlines for 42.

I just chatted with kar, if there is a concrete driver, and there aren't any string changes + it's easy to uplift to 42 aurora, we could do it for 42.

Comment 9

[Nick Alexander :nalexander [he/him]]

(In reply to Barbara Bermes [:bbermes] from comment #8)
> margaret, this is going out for 42? 
> 
> I'm thinking about the dates and all the deadlines for 42.
> 
> I just chatted with kar, if there is a concrete driver, and there aren't any
> string changes + it's easy to uplift to 42 aurora, we could do it for 42.

Yes, this should track 42.  It's just flipping the flag, which I should have done earlier.

Comment 10

[Nick Alexander :nalexander [he/him]]

url:        https://hg.mozilla.org/integration/fx-team/rev/42037547a8b9b86daaa5a679232930d2c48e168a
changeset:  42037547a8b9b86daaa5a679232930d2c48e168a
user:       Nick Alexander <[e-mail]>
date:       Mon Aug 10 11:07:29 2015 -0700
description:
Bug 1192004 - Enable Firefox Account avatars in Fennec release builds. r=margaret

Comment 11

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8645829 [details]
MozReview Request: Bug 1192004 - Enable Firefox Account avatars in Fennec release builds. r?margaret

Approval Request Comment
[Feature/regressing bug #]: Firefox Account avatar support in Fennec past Nightly.
[User impact if declined]: no avatars!  Fennec will lag Desktop.
[Describe test coverage new/current, TreeHerder]: manual.
[Risks and why]: very low.  This has been on Nightly for most of a cycle. In the failure case, users see the default avatar image.
[String/UUID change made/needed]: none -- everything has already landed and been uplifted.  This is just flipping the flag to enable the feature on Aurora and above.

Comment 12

[Barbara Bermes [:barbara] - NI please!]

done, added card and put it in 42 Aha column - thanks - sounds good.

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/42037547a8b9

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Release Note Request (optional, but appreciated)
[Why is this notable]: We have this in Desktop in 41, now in fennec, in 42.
[Suggested wording]: Ability to set a profile picture for your Firefox Account
[Links (documentation, blog post, etc)]:

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8645829 [details]
MozReview Request: Bug 1192004 - Enable Firefox Account avatars in Fennec release builds. r?margaret

Sure!

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ba6a50587731

Comment 17

[Catalin Suciu [:csuciu]]

Using the steps from comment #1 I'm verifying this as fixed on latest Nightly/Aurora
Tested on N7 (5.1.1) and Note 3 (4.4.2)

Comment 18

[Sylvestre Ledru [:Sylvestre]]

Added to the release notes with "Ability to set a profile picture for a Firefox Account" as wording.

Comment 19

[Nick Alexander :nalexander [he/him]]

This no longer requires kbrosnan's attention.

sylvestre: unfortunately, that's not good working for Fennec.  (It is good wording for desktop.)  On Fennec we don't have an affordance to /set/ the profile picture; we have support for displaying existing profile pictures.  How about:

"View profile pictures associated to Firefox Account in throughout Firefox for Android"

or similar?

Comment 20

[Fabio Rios [:frios]]

(In reply to Nick Alexander :nalexander from comment #19)
> This no longer requires kbrosnan's attention.
> 
> sylvestre: unfortunately, that's not good working for Fennec.  (It is good
> wording for desktop.)  On Fennec we don't have an affordance to /set/ the
> profile picture; we have support for displaying existing profile pictures. 
> How about:
> 
> "View profile pictures associated to Firefox Account in throughout Firefox
> for Android"
> 
> or similar?

Notable as a release note? 

Sounded much cooler when the user could actually do something.

Comment 21

[Sylvestre Ledru [:Sylvestre]]

As Fabio suggested, I removed it. It is not super interesting for now...