Closed Bug 1192208 Opened 10 years ago Closed 10 years ago

Ripple effect on click when in a tab sharing session with shared pointers.

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: RT, Assigned: mancas)

References

Details

(Whiteboard: [pointer])

User Story

As a Hello user in a tab sharing session with shared pointers, I want to see a ripple effect on local and remote click, so that I am aware of click events.

Acceptance criteria:
* When the local user left clicks a ripple effect is shown (1 sec click animation)
* When the remote user left clicks a ripple effect is shown (1 sec click animation)

Visual assets: http://i.sevaan.com/image/222E1E310Y0o

Attachments

(3 files)

Demo
77 bytes, text/plain
Details
[loop] fcampo:test-ripple > mozilla:master
40 bytes, text/x-github-pull-request
dcritchley
: review+
Details | Review
ripple_s.mov
6.36 MB, video/quicktime
Pau
: ui-review+
Pau
: ui-review+
Details
No description provided.
User Story: (updated)
Depends on: 1186905
Vicky, can you please provide visual assets for ripple effect on click?
Flags: needinfo?(vpg)
Rank: 28
Priority: -- → P2
Rank: 28 → 25
Flags: needinfo?(vicky.bugzilla)
User Story: (updated)
Rank: 25 → 29
Whiteboard: [websharing, pointer]
Rank: 29 → 28
Whiteboard: [websharing, pointer] → [pointer]
Assignee: nobody → b.mcb
Attached file Demo —
Blocks: 1248602
Rank: 28 → 19
Priority: P2 → P1
Comment on attachment 8720828 [details] [review] [loop] fcampo:test-ripple > mozilla:master No volunteers, so choosing reviewers with the shortest queue ;)
Attachment #8720828 - Flags: review?(mdeboer)
Attachment #8720828 - Flags: review?(edilee)
Attachment #8720828 - Flags: review?(dcritchley)
Attachment #8720828 - Flags: review?(standard8)
Attachment #8720828 - Flags: review?(mdeboer)
Comment on attachment 8720828 [details] [review] [loop] fcampo:test-ripple > mozilla:master +r after comments addressed in github
Attachment #8720828 - Flags: review?(standard8)
Attachment #8720828 - Flags: review?(edilee)
Attachment #8720828 - Flags: review?(dcritchley)
Attachment #8720828 - Flags: review+
Attached video ripple_s.mov —
Attachment #8723615 - Flags: ui-review?(sfranks)
Attachment #8723615 - Flags: ui-review?(b.pmm)
Attachment #8723615 - Flags: ui-review?(b.pmm) → ui-review+
Attachment #8723615 - Flags: ui-review?(sfranks) → ui-review+
Looks awesome. Pretty exciting to see it in action.
Depends on: 1252088
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: