1252088 - Ripple click effect needs more unit tests

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

I was assessing releasing bug 1192208 in 1.1 and realised that it landed with very few unit tests. This reduced my confidence in pushing it out for a release slightly earlier.

We should cover this deficit. At a minimum we need to review & add tests for:

- https://github.com/mozilla/loop/commit/ffa38d3b682c8f1ea3a793dcfd6db7691789348b
- https://github.com/mozilla/loop/commit/f8a84b1dfb3341637569d465882354bcfd58f924

At a quick glance, this amounts to:

- In the first cset: 
-- tests for remoteCursorStore.js & views.jsx changes in the first cset
- In the second cset:
-- tests for views.jsx changes
-- test for handling of _onRemoteCursorPositionChange (i.e. send event, does it get forwarded)

I'm reasonably happy for the bootstrap changes to be covered by other tests in a separate bug - as we need to get testing ifra in place for those wrt shared pointers.

Comment 1

[GitHub Autolander Bot]

Attachment: [loop] mancas:bug1252088 > mozilla:master

Comment 2

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8726115 [details] [review]
[loop] mancas:bug1252088 > mozilla:master

I left a comment in the PR about the tests

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8726115 [details] [review]
[loop] mancas:bug1252088 > mozilla:master

Looking good, I think there's just one small test to add still, but correct me if you think I'm wrong.

Comment 4

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8726115 [details] [review]
[loop] mancas:bug1252088 > mozilla:master

I left a link in github to the test you're looking for. Please let me know if that test is enough or not.

Thanks!

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8726115 [details] [review]
[loop] mancas:bug1252088 > mozilla:master

Thanks for pointing me in the direction of that test. Not sure how I missed it before.

Comment 6

[Manuel Casas Barrado [:mancas]]

Landed in master: https://github.com/mozilla/loop/commit/988da57cc3f1836e3a389fc656863d9b810bfa5e