1192329 - Change JS shell to default to the standard version of JS (not 1.7+)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

As reported in bug 1146532:

    js> var yield;
    typein:1:4 SyntaxError: yield is a reserved identifier:

Nonsense. The js shell should default to standard, Web-compatible JS.

The version() shell builtin is still there for testing legacy features.

Comment 1

[Morgan Phillips [:mrrrgn]]

Snagging this ^.^

Comment 2

[Daniel Ehrenberg]

+1 I encountered this when working on let in V8. I mistakenly thought SpiderMonkey reserved let as a keyword for a while. I am using the easy workaround of writing a web page for it, but it'd be great if the js repl were fixed.

Comment 3

[Jason Orendorff [:jorendorff]]

Start by changing JSVERSION_LATEST to JSVERSION_DEFAULT throughout js/src/shell/js.cpp.

If there's an interesting part, it'll involve fixing busted tests. Broad-spectrum restoration of the old gross version for particular directories of tests is OK: the goal of this bug is to fix the shell for people using it interactively.

Comment 4

[Claude Pache]

This is a dupe of Bug 1173883...

Comment 5

[Tom S. (please needinfo tschuster)]

Not really. Web console is not the same as the JS shell.

Comment 6

[Morgan Phillips [:mrrrgn]]

Attachment: smshell.1.diff

Comment 7

[Morgan Phillips [:mrrrgn]]

Attachment: smshell.2.diff

Comment 8

[Morgan Phillips [:mrrrgn]]

Sorry for the long turnaround time here. The changes to JSVERSION_DEFAULT in shell/js.cpp didn't break tests because the shell tests were already calling "version(0)" before running. I went ahead and removed that since it's unnecessary now.

Comment 9

[Morgan Phillips [:mrrrgn]]

A try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=31295dd54fc5

Comment 10

[Jason Orendorff [:jorendorff]]

Comment on attachment 8677863 [details] [diff] [review]
smshell.1.diff

Review of attachment 8677863 [details] [diff] [review]:
-----------------------------------------------------------------

Great! Glad this turned out to be easy for once.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a0ccab2a6e28
https://hg.mozilla.org/integration/mozilla-inbound/rev/cefec636b2d5

Comment 12

[Morgan Phillips [:mrrrgn]]

Attachment: smshell.3.diff

This fixes the asm tests by explicitly setting a version.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc0945ec65c6

Comment 14

[Jason Orendorff [:jorendorff]]

Comment on attachment 8678298 [details] [diff] [review]
smshell.3.diff

I already gave this review on IRC, but it doesn't hurt to have it here too.

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a0ccab2a6e28
https://hg.mozilla.org/mozilla-central/rev/cefec636b2d5
https://hg.mozilla.org/mozilla-central/rev/cc0945ec65c6

Comment 16

[Florian Scholz (Open Web Docs)]

Added a note to
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Introduction_to_the_JavaScript_shell and
https://developer.mozilla.org/en-US/Firefox/Releases/44#JavaScript

Comment 17

[Morgan Phillips [:mrrrgn]]

(In reply to Florian Scholz [:fscholz] (MDN) from comment #16)
> Added a note to
> https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/
> Introduction_to_the_JavaScript_shell and
> https://developer.mozilla.org/en-US/Firefox/Releases/44#JavaScript

Ah, thank you! /me Takes note to always remember docs for the future. :)