1192347 - Don't show Search Suggest Opt-in until user types a query

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Stephen Horlander [:shorlander]]

The aggressive display of the notification is a left-over from when it was opt-out. Now that it is opt-in we should only show it when you start typing and see results.

Comment 1

[Drew Willcoxon :adw]

Attachment: patch

Dave, I understand if you'd prefer Marco review this, but it's a fairly simple change that I'd like to land ASAP.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfc14f270a6b

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

I suggested a possible improvement to the UX of this feature in bug 1192362 comment 6. Maybe it'll come useful :)

Comment 3

[Drew Willcoxon :adw]

The oth failures from comment 1 are due to https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=d6ff8fa48095.  (Here's a newer try push with a fresher tree with that commit backed out: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec2fffa6d079)

Think it's safe to land.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3807d60e0de4

Comment 5

[Marco Bonardo [:mak]]

thank you for doing this!

Just a side note, I think the gBrowser.selectedBrowser._urlbarFocused trick is no more needed now and we could remove it?

Comment 6

[Marco Bonardo [:mak]]

ehr sorry, drew is pto, I'll file a separate bug.

Comment 7

[Marco Bonardo [:mak]]

filed bug 1192503

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3807d60e0de4

Comment 9

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using Aurora 42.0a2 2015-08-18 across platforms.