Closed Bug 1192347 Opened 4 years ago Closed 4 years ago
Don't show Search Suggest Opt-in until user types a query
The aggressive display of the notification is a left-over from when it was opt-out. Now that it is opt-in we should only show it when you start typing and see results.
Dave, I understand if you'd prefer Marco review this, but it's a fairly simple change that I'd like to land ASAP. https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfc14f270a6b
Attachment #8645127 - Flags: review?(dtownsend)
I suggested a possible improvement to the UX of this feature in bug 1192362 comment 6. Maybe it'll come useful :)
Attachment #8645127 - Flags: review?(dtownsend) → review+
The oth failures from comment 1 are due to https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=d6ff8fa48095. (Here's a newer try push with a fresher tree with that commit backed out: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec2fffa6d079) Think it's safe to land.
thank you for doing this! Just a side note, I think the gBrowser.selectedBrowser._urlbarFocused trick is no more needed now and we could remove it?
ehr sorry, drew is pto, I'll file a separate bug.
filed bug 1192503
Verified as fixed using Aurora 42.0a2 2015-08-18 across platforms.
You need to log in before you can comment on or make changes to this bug.