Don't show Search Suggest Opt-in until user types a query

VERIFIED FIXED in Firefox 42

Status

()

Firefox
Search
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: shorlander, Assigned: adw)

Tracking

(Blocks: 2 bugs)

Trunk
Firefox 42
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite +

Firefox Tracking Flags

(firefox42 verified)

Details

(Whiteboard: [suggestions][fxsearch])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The aggressive display of the notification is a left-over from when it was opt-out. Now that it is opt-in we should only show it when you start typing and see results.
(Assignee)

Updated

2 years ago
Assignee: nobody → adw
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Created attachment 8645127 [details] [diff] [review]
patch

Dave, I understand if you'd prefer Marco review this, but it's a fairly simple change that I'd like to land ASAP.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfc14f270a6b
Attachment #8645127 - Flags: review?(dtownsend)
I suggested a possible improvement to the UX of this feature in bug 1192362 comment 6. Maybe it'll come useful :)
Attachment #8645127 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 3

2 years ago
The oth failures from comment 1 are due to https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=d6ff8fa48095.  (Here's a newer try push with a fresher tree with that commit backed out: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec2fffa6d079)

Think it's safe to land.

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/3807d60e0de4
Blocks: 1192362
Blocks: 958204
Flags: firefox-backlog+
thank you for doing this!

Just a side note, I think the gBrowser.selectedBrowser._urlbarFocused trick is no more needed now and we could remove it?
Flags: needinfo?(adw)
ehr sorry, drew is pto, I'll file a separate bug.
Flags: needinfo?(adw)
filed bug 1192503
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/3807d60e0de4
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox42: affected → fixed
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Depends on: 1192503
Verified as fixed using Aurora 42.0a2 2015-08-18 across platforms.
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
You need to log in before you can comment on or make changes to this bug.