958204 - [meta][Theme] Search Suggestions

Status: RESOLVED FIXED

(Firefox :: Search, task, P5)

Description

[Marco Mucci [:MarcoM]]

1.  Goal:
* As a Firefox Desktop User I want search suggestions as I type in the URL bar so that I can more accurately search from the URL bar. 

2.  Acceptance Criteria (AC): 
* Several search suggestions from the default search provider appear with history suggestions as a user types.
* Suggestions are mixed in with history items.

3.  Notes/Supporting Documentation: 
* Fennec wrestled with bug 769145 requiring users to opt-in for suggestions.

Comment 1

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Mockup: Search suggestions added to bottom of URL bar

Comment 2

[Madhava Enros [:madhava]]

Can we review the Fennec designs and see if we want to have a common design? One benefit of the Fennec design (horizontal tiles in one row) means that we can put these at the top, where they're visible as you type, without pushing frecency results down more than one row.

Comment 3

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Marco, I have a few questions related to this feature:
1. Is this feature going to be implemented for both Android and Desktop, and both under this bug?
2. What is the targeted version for this to be released?
3. Is there any general documentation for this? E.g. wiki, designs, a trello board

Since this seems to be already in progress we could use having a QA start to look over this (or two QA if this is for both Android and Desktop).

Comment 4

[Marco Bonardo [:mak]]

(In reply to Florin Mezei, QA (:FlorinMezei) from comment #3)
> Marco, I have a few questions related to this feature:
> 1. Is this feature going to be implemented for both Android and Desktop, and
> both under this bug?

This is only for desktop.

> 2. What is the targeted version for this to be released?

42

> 3. Is there any general documentation for this? E.g. wiki, designs, a trello
> board

Kev has a user story page describing the feature, try pinging him.
Most of the designs are attached to bugs or were discussed in person, you can refer to bug 959564 for the interaction, but note we are not implementing the new oneline design for entries in the awesomebar popup, yet. The design in this bug is outdated (I will now mark it as obsolete)

> Since this seems to be already in progress we could use having a QA start to
> look over this (or two QA if this is for both Android and Desktop).

Sounds like a good idea, this bug is the meta tracker for the implementation, you can check the dependencies.

Also, Marco Mucci is not following this, the program manager for the feature is :shell, the product manager is :kev.

Comment 5

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Thanks Marco for the quick response and useful info. Adding Petruta as the QA Contact. I'm also setting the 42 Target Milestone and adding the feature keyword for proper tracking.

Comment 6

[:shell escalante]

i think this is the right user story document https://docs.google.com/document/d/1de2o8Osl_z98BBfkt243i-dHdcKmQB15xJ9rShkwk3Q/edit (kev correct me if there's a newer one)

The top image is the "opt-in" dialog that was decided on... http://cl.ly/image/0I3x2T0N1w20/o

Comment 7

[Fabio Rios [:frios]]

Is this still planned for 42? Haven't seen anything in release notes?

Comment 8

[Marco Bonardo [:mak]]

(In reply to Fabio Rios [:frios] from comment #7)
> Is this still planned for 42? Haven't seen anything in release notes?

it will be released in 43.

Comment 9

[Fabio Rios [:frios]]

(In reply to Marco Bonardo [::mak] from comment #8)
> (In reply to Fabio Rios [:frios] from comment #7)
> > Is this still planned for 42? Haven't seen anything in release notes?
> 
> it will be released in 43.

Noted. Thanks Marco.

Comment 10

[lthomecz]

Can the search suggestions be turned off via about:config?

Comment 11

[Marco Bonardo [:mak]]

why do you want to use about:config when there's a visible option in Options / Search (that maps to browser.urlbar.suggest.searches)

Comment 12

[lthomecz]

Indeed, that turns off the Search suggestions, the same as if you opt-out in the dialog, i assume.
I might have phrased it a little bit shortly, sorry.
I meant that after the opt-out or disabling via settings, there still is the "search with <XXX>" field in the results listing - taking a lot of space.
My question then would be: Can i revert to the old behaviour after opt-out/disabling autosuggestions, without the searchfield?
If i want to search, i can just press Enter.
Use case is that i usually just enter some short string, then scroll with the mouse or just click on the first result - which now is the search instead of the website.

Comment 13

[Marco Bonardo [:mak]]

(In reply to lthomecz from comment #12)
> I meant that after the opt-out or disabling via settings, there still is the
> "search with <XXX>" field in the results listing - taking a lot of space.

It's unrelated to search suggestions.

> If i want to search, i can just press Enter.

yes, that additional line is just showing what the Enter action will be. the search beavior is indeed the same as before.

> Use case is that i usually just enter some short string, then scroll with
> the mouse or just click on the first result - which now is the search
> instead of the website.

if you're used to down with the keyboard, the behavior is the same, since the first entry is preselected. I guess with the mouse you may have to retarget the first times...
I suggest to get used to moving through results with the keyboard, it's far more efficient (this is just a friendly suggestion, not an answer to your feedback).

Comment 14

[:shell escalante]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 15

[lthomecz]

(In reply to Marco Bonardo [::mak] from comment #13)
> with <XXX>" field in the results listing - taking a lot of space.
> 
> It's unrelated to search suggestions.
>

I just got the update with the opt-out dialog and assumed it came with the search suggestions.
 
> if you're used to down with the keyboard, the behavior is the same, since
> the first entry is preselected. I guess with the mouse you may have to
> retarget the first times...
> I suggest to get used to moving through results with the keyboard, it's far
> more efficient (this is just a friendly suggestion, not an answer to your
> feedback).

After some time using the new design you just blend out the additional line, yes. I was just surprised after the update, and found nothing about that anywhere else.
Sry for disturbing, thanks for the info.

Comment 16

[Marco Bonardo [:mak]]

no worries, glad to help.

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Marco (or shell) can you suggest wording for a release note if some aspect of this project should have one? 
What Firefox version(s) should have the note? Applicable for Firefox for Android too? Thanks!

Comment 18

[Kev Needham [:kev]]

Hey Liz,

Wording should be "Search suggestions can be displayed in the Awesome Bar." Applicable in Firefox 43 and beyond, desktop only, as Fennec has a single search surface and has had suggests available for a while. In both cases the user needs to opt-in for their use.

Comment 19

[Kev Needham [:kev]]

Sorry, here's the proper format:

[Why is this notable]: Adds search suggestions to the Awesome Bar, allowing users to more easily complete common searches that incorporate terms they've typed in.
[Suggested wording]: Search suggestions can be displayed in the Awesome Bar. Requires opt-in.
[Links (documentation, blog post, etc)]: Needs an update, which I'll file tomorrow. Will be https://support.mozilla.org/en-US/kb/awesome-bar-search-firefox-bookmarks-history-tabs

Comment 20

[Liz Henry (:lizzard) (relman/hg->git project)]

Great. Thanks Kevin. Noted and I will add the link now.

Comment 21

[Mark Banner (:standard8)]

It looks like this project was finished back in 43, but the bug never closed, so doing that now.