1192391 - Namespace pollution tests don't consider Cu.import() calls

Status: RESOLVED DUPLICATE of bug 1191752

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Wladimir Palant]

Validator currently doesn't flag calls like the following:

  Components.utils.import("resource://gre/modules/Services.jsm");

In a script loaded from an overlay this will create the global variable Services, without any namespacing. Correct call would be:

  ({my_addon_namespace.Services} = Components.utils.import("resource://gre/modules/Services.jsm", {}));

I'm not sure whether bug 1191752 is about the same thing, somebody forgot to explain the context there.

Comment 1

[Wladimir Palant]

Note that Components.utils.import("resource://gre/modules/Services.jsm", my_addon_namespace) would also be correct. It's only problematic (adding variables to global namespace) if the second parameter is missing.