The back and forward button icons for dark Dev Edition theme in Windows aren't inverted

VERIFIED FIXED in Firefox 42

Status

()

Firefox
Theme
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

unspecified
Firefox 42
Points:
---

Firefox Tracking Flags

(firefox42 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Created attachment 8645159 [details]
back-button-inverted.png

See screenshot.  This is due to Bug 1165360, which was due to Bug 1165360.
(Assignee)

Comment 1

3 years ago
Created attachment 8645162 [details]
MozReview Request: Bug 1192397 - Invert the back and forward button icon for dark Windows Dev Edition theme;r=MattN

Bug 1192397 - Invert the back and forward button icon for dark Windows Dev Edition theme;r=MattN
Attachment #8645162 - Flags: review?(MattN+bmo)
(Assignee)

Comment 2

3 years ago
Couldn't figure out yet how to properly fix this (Bug 1166083), because the width of the back button icon is set to auto and the size of the 2x image used in list-style-image seems to inflate it.  Couldn't find an equivalent to background-size for that.

Also, I used [brighttext] instead of :root[devtoolstheme="dark"] just to be consistent with how the toolbar icons are set.  I could switch that if you think it'd be more clear.
(In reply to Brian Grinstead [:bgrins] from comment #2)
> Couldn't figure out yet how to properly fix this (Bug 1166083), because the
> width of the back button icon is set to auto and the size of the 2x image
> used in list-style-image seems to inflate it.  Couldn't find an equivalent
> to background-size for that.

#back-button > .toolbarbutton-icon {
  width: NNpx;
}

Or does that not work for some reason?
Flags: needinfo?(bgrinstead)
(Assignee)

Comment 4

3 years ago
(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to Brian Grinstead [:bgrins] from comment #2)
> > Couldn't figure out yet how to properly fix this (Bug 1166083), because the
> > width of the back button icon is set to auto and the size of the 2x image
> > used in list-style-image seems to inflate it.  Couldn't find an equivalent
> > to background-size for that.
> 
> #back-button > .toolbarbutton-icon {
>   width: NNpx;
> }
> 
> Or does that not work for some reason?

We set it to width: auto / height: auto in the original work (Bug 1053434).  I can't remember if setting it to a hardcoded width/height caused issues across different versions of Windows or what.  I've got Bug 1166083 opened to properly fix this.
Flags: needinfo?(bgrinstead)
(Assignee)

Updated

3 years ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment on attachment 8645162 [details]
MozReview Request: Bug 1192397 - Invert the back and forward button icon for dark Windows Dev Edition theme;r=MattN

r=me to make it not look terrible for now, and leaving the rest of the work for the other bug.
Attachment #8645162 - Flags: review?(MattN+bmo) → review+
(Assignee)

Comment 6

3 years ago
(In reply to :Gijs Kruitbosch from comment #5)
> r=me to make it not look terrible for now, and leaving the rest of the work
> for the other bug.

Thanks
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/369e47f08392
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42

Updated

3 years ago
Duplicate of this bug: 1188293
I reproduced this bug on Firefox nightly Version 42.0a1 according to(2015-08-07) 

It's verified and fixed on Latest Developer Edition
Build ID 	20150911004112
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:42.0) Gecko/20100101 Firefox/42.0

Tested OS-- windows8 32bit
QA Whiteboard: [testday-20150911]

Updated

3 years ago
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
You need to log in before you can comment on or make changes to this bug.