Closed
Bug 1192492
Opened 9 years ago
Closed 9 years ago
Support masking of passwords in XUL trees
Categories
(Core :: XUL, enhancement, P1)
Core
XUL
Tracking
()
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Whiteboard: [fxprivacy])
Attachments
(2 files)
For bug 1121291, we would like to have the password column masked and then unmask individual passwords one-at-a-time of the user's choosing. I couldn't find any way to this with our current <tree> in a way that integrates with the proper OS masking character.
Webkit has `-webkit-text-security: disc|square|…;` which would be a somewhat more flexible approach and not XUL-specific but it also seems more complicated and I'm not sure if we want to expose that to the web.
I realize there is a moratorium on significant XUL features but there aren't other good solutions that I can see (unless someone can throw together a CSS property patch) without rewriting all the tree logic in HTML which isn't really a good use of time. We would also still need to support that new CSS property in tree cells to solve bug 1121291 without a rewrite.
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1192492 - Support masking of passwords in XUL tree columns.
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8645313 [details]
MozReview Request: Bug 1192492 - Support masking of passwords in XUL tree columns. r=Enn
I think the code is ready for review but this is lacking a reftest as I haven't written them before and wanted to make sure this patch would be accepted before doing that work.
Attachment #8645313 -
Flags: feedback?(enndeakin)
Comment 3•9 years ago
|
||
Comment on attachment 8645313 [details]
MozReview Request: Bug 1192492 - Support masking of passwords in XUL tree columns. r=Enn
When editing the password (startEditing), you might want to set the textbox type to password.
Attachment #8645313 -
Flags: feedback?(enndeakin) → feedback+
Updated•9 years ago
|
Blocks: 1193404
Iteration: --- → 43.1 - Aug 24
Flags: qe-verify?
Flags: firefox-backlog+
Priority: -- → P1
Whiteboard: [fxprivacy]
Assignee | ||
Comment 4•9 years ago
|
||
Thanks Neil,
(In reply to Neil Deakin from comment #3)
> When editing the password (startEditing), you might want to set the textbox
> type to password.
I implemented the desired behaviour for our use case in bug 1121291. See https://www.lucidchart.com/documents/edit/87ab1cc8-e708-49d3-8b91-6e2e6da346fb/9
Since this is how we need it to work and we don't want to be adding new generalized XUL features I think this is fine for now.
Assignee | ||
Updated•9 years ago
|
Attachment #8645313 -
Attachment description: MozReview Request: Bug 1192492 - Support masking of passwords in XUL tree columns. → MozReview Request: Bug 1192492 - Support masking of passwords in XUL tree columns. r=Enn
Attachment #8645313 -
Flags: feedback+ → review?(enndeakin)
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8645313 [details]
MozReview Request: Bug 1192492 - Support masking of passwords in XUL tree columns. r=Enn
Bug 1192492 - Support masking of passwords in XUL tree columns. r=Enn
Updated•9 years ago
|
Attachment #8645313 -
Flags: review?(enndeakin) → review+
Updated•9 years ago
|
Iteration: 43.1 - Aug 24 → 43.2 - Sep 7
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8645313 [details]
MozReview Request: Bug 1192492 - Support masking of passwords in XUL tree columns. r=Enn
Bug 1192492 - Support masking of passwords in XUL tree columns. r=Enn
Attachment #8645313 -
Flags: review+ → review?(enndeakin)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(MattN+bmo)
Attachment #8645313 -
Flags: review?(enndeakin) → review+
Assignee | ||
Updated•9 years ago
|
Flags: qe-verify? → qe-verify-
Updated•9 years ago
|
Iteration: 43.2 - Sep 7 → 43.3 - Sep 21
Comment 9•9 years ago
|
||
Ugh, you should not use the editor guts like this :( https://hg.mozilla.org/integration/mozilla-inbound/rev/7d8d6fef4cfd#l4.12
Please file a follow-up bug and move that method to nsContentUtils and use it from there. Thanks!
Comment 10•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Updated•9 years ago
|
Flags: needinfo?(MattN+bmo)
Assignee | ||
Comment 11•5 years ago
|
||
(In reply to :ehsan akhgari from comment #9)
Ugh, you should not use the editor guts like this :(
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d8d6fef4cfd#l4.12Please file a follow-up bug and move that method to nsContentUtils and use
it from there. Thanks!
This got fixed by https://hg.mozilla.org/mozilla-central/rev/32c7c4840b1e645bb87b4200eba0b25ea4ebb5c7#l8.35
Flags: needinfo?(MattN+bmo)
You need to log in
before you can comment on or make changes to this bug.
Description
•