1508165 - Remove support for treecol[type="password"]

Status: RESOLVED FIXED

(Core :: XUL, task, P5)

Description

[Tim Nguyen :ntim]

Support was introduced in bug 1192492 specially for bug 1121291, but that bug got backed out in bug 1208145.

So AFAIK, this can be removed.

Comment 1

[Tim Nguyen :ntim]

Matt, can you please confirm that this feature is unused ?

Comment 2

[Matthew N. [:MattN] (PM me if requests are blocking you)]

It's supposed to be used again in bug 1257078 / bug 1209267 but nobody has been working on password manager for years so it hasn't happened yet. https://hg.mozilla.org/mozreview/gecko/rev/d914362e4406679c8f5d96387e94fd5ba6c62c3a from that bug is changing the behaviour.

Comment 3

[Alex Vincent [:WeirdAl]]

I've just confirmed by visual inspection that mozilla-central and comm-central don't use treecol type="password".
https://searchfox.org/comm-central/search?q=type%3D%22password%22&case=false&regexp=false&path=.xul%24

Comment 4

[Matthew N. [:MattN] (PM me if requests are blocking you)]

That is correct. See comment 2 which points out bugs that aren't fixed.

Comment 5

[Alex Vincent [:WeirdAl]]

Attachment: Bug 1508165, remove support for treecol[type=password]. r=MattN

Comment 6

[Cosmin Sabou [:CosminS]]

hg error in cmd: hg push -r tip upstream: pushing to ssh://hg.mozilla.org/integration/autoland searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 5 changes to 5 files remote: remote: ******************************* ERROR ******************************* remote: Changeset c11a77a16d77 alters WebIDL file(s) without DOM peer review: remote: dom/webidl/TreeColumn.webidl remote: remote: Please, request review from either: remote: - Andrea Marchesini (:baku) remote: - Andreas Farre (:farre) remote: - Andrew McCreight (:mccr8) remote: - Bobby Holley (:bholley) remote: - Boris Zbarsky (:bz) remote: - Ehsan Akhgari (:ehsan) remote: - Henri Sivonen (:hsivonen) remote: - Nika Layzell (:mystor) remote: - Olli Pettay (:smaug) remote: - Peter Van der Beken (:peterv) remote: ********************************************************************* remote: remote: transaction abort! remote: rollback completed remote: pretxnchangegroup.mozhooks hook failed abort: push failed on remote

Comment 7

[Alex Vincent [:WeirdAl]]

sigh Sorry about that... I've now asked #webidl to review.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d1d2599d505
remove support for treecol[type=password]. r=MattN,webidl,smaug

Comment 9

[Alex Vincent [:WeirdAl]]

Attachment: e86df78526fb.diff

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/720c1e5a8dd3
build bustage fix for a no-longer-used variable.

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1d1d2599d505
https://hg.mozilla.org/mozilla-central/rev/720c1e5a8dd3