Closed Bug 1508165 Opened 2 years ago Closed 1 year ago

Remove support for treecol[type="password"]

Categories

(Core :: XUL, task, P5)

Product:
Core
Component:
XUL
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: ntim, Assigned: WeirdAl)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1508165, remove support for treecol[type=password]. r=MattN
47 bytes, text/x-phabricator-request
Details | Review
e86df78526fb.diff
891 bytes, patch
Details | Diff | Splinter Review 
Support was introduced in bug 1192492 specially for bug 1121291, but that bug got backed out in bug 1208145.

So AFAIK, this can be removed.
Matt, can you please confirm that this feature is unused ?
Component: XUL Widgets → XUL
Flags: needinfo?(MattN+bmo)
Product: Toolkit → Core
It's supposed to be used again in bug 1257078 / bug 1209267 but nobody has been working on password manager for years so it hasn't happened yet. https://hg.mozilla.org/mozreview/gecko/rev/d914362e4406679c8f5d96387e94fd5ba6c62c3a from that bug is changing the behaviour.
Flags: needinfo?(MattN+bmo)
Priority: -- → P5
Type: enhancement → task

I've just confirmed by visual inspection that mozilla-central and comm-central don't use treecol type="password".
https://searchfox.org/comm-central/search?q=type%3D%22password%22&case=false&regexp=false&path=.xul%24

That is correct. See comment 2 which points out bugs that aren't fixed.

Attachment #9099622 - Attachment description: Bug 1508165, remove support for treecol[type=password]. r=bgrins → Bug 1508165, remove support for treecol[type=password]. r=MattN
Assignee: nobody → ajvincent
Keywords: checkin-needed

hg error in cmd: hg push -r tip upstream: pushing to ssh://hg.mozilla.org/integration/autoland searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 5 changes to 5 files remote: remote: ******************************* ERROR ******************************* remote: Changeset c11a77a16d77 alters WebIDL file(s) without DOM peer review: remote: dom/webidl/TreeColumn.webidl remote: remote: Please, request review from either: remote: - Andrea Marchesini (:baku) remote: - Andreas Farre (:farre) remote: - Andrew McCreight (:mccr8) remote: - Bobby Holley (:bholley) remote: - Boris Zbarsky (:bz) remote: - Ehsan Akhgari (:ehsan) remote: - Henri Sivonen (:hsivonen) remote: - Nika Layzell (:mystor) remote: - Olli Pettay (:smaug) remote: - Peter Van der Beken (:peterv) remote: ********************************************************************* remote: remote: transaction abort! remote: rollback completed remote: pretxnchangegroup.mozhooks hook failed abort: push failed on remote

Flags: needinfo?(ajvincent)
Keywords: checkin-needed

sigh Sorry about that... I've now asked #webidl to review.

Flags: needinfo?(ajvincent)
Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d1d2599d505
remove support for treecol[type=password]. r=MattN,webidl,smaug

Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/720c1e5a8dd3
build bustage fix for a no-longer-used variable.

https://hg.mozilla.org/mozilla-central/rev/1d1d2599d505
https://hg.mozilla.org/mozilla-central/rev/720c1e5a8dd3

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.