Closed Bug 1192812 Opened 9 years ago Closed 9 years ago

add support for parsing firefox for ios user agent

Categories

(Input Graveyard :: Submission, defect, P1)

Product:
Input Graveyard
Component:
Submission
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

References

Details

(Whiteboard: u=user c=feedback p=2 s=input.2015q3) 

Input has a user agent parser that parses user agents for specific product-related things that we can then use when the user submits feedback using that product.

This bug covers updating that to handle Firefox for iOS user agents. From comment #8 in bug #1174883:

"""
https://developer.mozilla.org/en-US/docs/Web/HTTP/Gecko_user_agent_string_reference#Firefox_for_iOS

iPhone:

Mozilla/5.0 (iPhone; CPU iPhone OS 8_3 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) FxiOS/1.0 Mobile/12F69 Safari/600.1.4

iPad:

Mozilla/5.0 (iPad; CPU iPhone OS 8_3 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) FxiOS/1.0 Mobile/12F69 Safari/600.1.4
"""
Making this block the Firefox for iOS bug. Making it a P1 because it needs to get done asap.

I think this is a 2 point bug--probably take a day. There's some fiddly code involved and it's spread out a bit.

Grabbing it to work on today.
Assignee: nobody → willkg
Blocks: 1174883
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: u=user c=feedback p=2 s=input.2015q3
Landed in https://github.com/mozilla/fjord/commit/b71124a66a28d78f44ea458f6a176404b6a6084c

I'm going to push it to -stage then have Robert test it out with an idevice he's got since I don't have one.

If everything is satisfactory, we'll push to -prod.
cc:ing Robert to agreed to help test.
Robert: I've got the changes on -stage now.

Test plan:

1. Using Firefox for iOS, go to https://input.allizom.org/feedback/fxios
                                              ^^^^^^^
2. Fill out the feedback form and submit it

3. Tell Will

I'll then look up the resulting feedback response and make sure the data in the db is good.

Robert: Can you go through that before 2:00pm Pacific Time today and let me know? Any later than that and we'll have to wait until next Monday to push this to -prod.
Adding a needinfo to Robert for help on comment #5.
Flags: needinfo?(rrayborn)
Pushed to prod just now. Hopefully it's fine. I'll look for iOS feedback and verify it when I see it. Given that, removing the ni? for Robert.
Flags: needinfo?(rrayborn)
I have an ipod touch now and tested this out. It's picking up everything except the platform. I'll look into that today.
Landed in master: https://github.com/mozilla/fjord/commit/6ecf4556f095eb189181935961b6f749675500b3

I pushed that to prod, did some testing and then realized I missed inferring the platform.

Fix for that is in PR: https://github.com/mozilla/fjord/pull/642

That landed in https://github.com/mozilla/fjord/commit/d6482c97e7494b35fad0a2f6639fb7136a61431c

Tested that in production and it looks good:

https://input.mozilla.org/en-US/dashboard/response/5560837

Marking this one FIXED.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.