Closed Bug 1193123 Opened 5 years ago Closed 5 years ago

TrackBuffersManager::RemoveFrames sets the removed-intervals "fuzz" twice, one of them must be wrong

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In dom/media/mediasource/TrackBuffersManager.cpp, TrackBuffersManager::RemoveFrames contains two lines where the removed-intervals fuzz is set:
|removedIntervals.SetFuzz(TimeUnit::FromMicroseconds(maxSampleDuration));|
|removedIntervals.SetFuzz(TimeUnit::FromMicroseconds(maxSampleDuration/2));|

To match InsertFrames, the 2nd one is preferred (to allow a maximum gap of 1 frame).
Version: 1.0 Branch → unspecified
Removed redundant&wrong SetFuzz in RemoveFrames.
Attachment #8646757 - Flags: review?(jyavenard)
Attachment #8646757 - Flags: review?(jyavenard) → review+
https://hg.mozilla.org/mozilla-central/rev/5bff51ff1723
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Blocks: 1197083
Backed out for a youtube playback regression. See Bug 1199573.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.