1193123 - TrackBuffersManager::RemoveFrames sets the removed-intervals "fuzz" twice, one of them must be wrong

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

In dom/media/mediasource/TrackBuffersManager.cpp, TrackBuffersManager::RemoveFrames contains two lines where the removed-intervals fuzz is set:
|removedIntervals.SetFuzz(TimeUnit::FromMicroseconds(maxSampleDuration));|
|removedIntervals.SetFuzz(TimeUnit::FromMicroseconds(maxSampleDuration/2));|

To match InsertFrames, the 2nd one is preferred (to allow a maximum gap of 1 frame).

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1193123-remove-redundant-setfuzz.patch

Removed redundant&wrong SetFuzz in RemoveFrames.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3749f1987ea7

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5bff51ff1723

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5bff51ff1723

Comment 5

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c64e11bca05f

Comment 6

[Ralph Giles (:rillian)]

Backed out for a youtube playback regression. See Bug 1199573.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c

Comment 7

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/93a21f5df6d5