1197083 - Uplift all MSE changes made in Nightly/43 to 42 branch

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Jean-Yves Avenard [:jya]]

This is a bug to handle backporting of all changes made recently on 43 related to MSE to the 42 branch.

The decision was made to enable MSE for all platforms in 42. There has been fixes made since 42 was tagged that are required for MSE to properly work.

This bug will track all of the bugs that need uplifting in order to facilitate uplift approval.

Comment 1

[Jean-Yves Avenard [:jya]]

changed title to mozilla's coding style :)

Comment 2

[Jean-Yves Avenard [:jya]]

Removing 1192675 due to bug 1196558

Comment 3

[Jean-Yves Avenard [:jya]]

Note: I will not be applying "Bug 1197075: P3. Decode frames ahead of MDSM requesting them. r=edwin" only keeping the revert of bug 1197051.

Comment 4

[Jean-Yves Avenard [:jya]]

that should be all of them for now... (including two currently waiting on inbount)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a328601136f

Comment 5

[Jean-Yves Avenard [:jya]]

Ralph, all green on the try push with everything linked to MSE+WebM...

I had to rebase a few patches here and there, but most applied properly.

I'm off soon, if you want to take those over.

Comment 6

[Ralph Giles (:rillian)]

Attachment: mse-uplift42a.hg

Requesting Aurora uplift of all the patches from the comment #4 push. This is an hg bundle of rebased onto the current aurora tree.

Approval Request Comment
[Feature/regressing bug #]:

These are all bugfixes for the MSE feature.
See also https://hg.mozilla.org/try/pushloghtml?changeset=6a328601136f for a view of the changes, down through commit a52595c15ed0, Bug 1180935.

Involves:

Bug 1009795
Bug 1180935
Bug 1185827
Bug 1188313
Bug 1188871
Bug 1190776
Bug 1190970
Bug 1192675
Bug 1193123
Bug 1193142
Bug 1194188
Bug 1194197
Bug 1195071
Bug 1195073
Bug 1196353
Bug 1196558
Bug 1197051
Bug 1197075
Bug 1197125
Bug 1197977
Bug 1198094
Bug 1199032
Bug 1199193

[User impact if declined]:

Less robust playback of video using the MSE feature, most notably with Youtube.

[Describe test coverage new/current, TreeHerder]:

All have landed on m-c, most over the last three weeks. Passing mochi and web platform tests, manual developer testing.

[Risks and why]:

Be believe risk is acceptable. These are generally small changes to polish up the implementation in Aurora to match the more robust code in nightly.

[String/UUID change made/needed]: None.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8654317 [details]
mse-uplift42a.hg

You guys have the blanket approval on these uplifts. Bug 1009795 in the uplift request is unrelated to this list of patches, it was a typo. Aurora42+

Comment 8

[Ralph Giles (:rillian)]

Thanks for the quick turn around. Here's the push:

https://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?changeset=e0eaf1f5b1d0
https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&revision=e0eaf1f5b1d0

Comment 9

[(Away)]

Media team, please keep an eye on crash-stats for fallout from this push.

The explosiveness reports will likely be the most useful (adjust the dates as appropriate): https://crash-analysis.mozilla.com/rkaiser/2015-08-27/2015-08-27.firefox.42.explosiveness.html

You might also want to sanity-check with https://crash-stats.mozilla.com/topcrasher/products/Firefox/versions/42.0a2/date_range_type/build?days=3 and https://crash-analysis.mozilla.com/rkaiser/crash-report-tools/score/?version=42.0a2&limit=30.

Comment 10

[Jean-Yves Avenard [:jya]]

Ralph, do not push anything past 1195073 it has introduced a regression causing stalls in youtube

Comment 11

[Jean-Yves Avenard [:jya]]

How embarrassing, why no one found that bug 10 days ago :(

Ralph, until bug 1199573 lands:

bug 1195073, 1197977, 1199032, 1190776 preferably out.

This changeset is the real culprit:
https://hg.mozilla.org/releases/mozilla-aurora/rev/e24897436eaa

Comment 12

[Ralph Giles (:rillian)]

Oops. Embarrassingly we found a regression while I was pushing. I've backed the whole stack out until we've addressed this issue. See bug 1199573.

https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c
https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&revision=5bb661db5c6c

Comment 13

[Ralph Giles (:rillian)]

I've pushed up through bug 1195071 from the patch stack on jya's recommendation.

https://treeherder.mozilla.org/#/jobs?repo=mozilla-aurora&revision=a9d79eb7e02a

Would like to land the rest once we have approval for the regression fixes.

Comment 14

[Ralph Giles (:rillian)]

Here's a green try push with the new bugs.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3da108998b5f

Comment 15

[Ralph Giles (:rillian)]

I had trouble rebasing and didn't have something I felt confident landing today. If someone else wants to take this over the weekend, feel free; otherwise I'll go through them manually on Tuesday.

Comment 16

[Jean-Yves Avenard [:jya]]

I can't think of anything needing rebasing with the patch stack I provided.. And the three extra bugs since will apply nicely too...

Comment 17

[Jean-Yves Avenard [:jya]]

We need to push the rest of the patch stack (bug 1195073 in particular) now that everything is fixed.
Otherwise bug 1199573, 1199878, 1199879 won't apply.

Comment 18

[Jean-Yves Avenard [:jya]]

With the current sec bug going on with XiphExtraData I think we should not uplift bug 1196353 for the time being.

Comment 19

[Jean-Yves Avenard [:jya]]

try run with all the remaining changes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1cb61ce02483

Comment 20

[Chris Peterson [:cpeterson]]

Jean-Yves, can we close this bug? Are there any MSE fixes that still need to be uplifted to Beta 42?

Comment 21

[Chris Mills [:cmills]]

I'm ddc'ing this bug — we've got Firefox 42 listed as the minimum (enabled by default) supporting version for all the MSE features. And there's a note in the relevant release notes too:

https://developer.mozilla.org/en-US/Firefox/Releases/42#Miscellaneous