1193227 - Mulet OS X and B2G Desktop OS X package test binaries unnecessarily

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Mulet OS X and B2G Desktop OS X builds from automation, such as the ones in the nightly[1] directory, include many test binaries and files such as "jsapi-tests", "Test<Name>", etc.

Other platforms (win32, linux64) do not include these files in their corresponding builds.

This causes the Mac builds to be 30 - 40 MB larger in compressed archive size than their relatives for other platforms.

[1]: https://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central/

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:mshal, I see that you worked on some packaging and automation tasks for Mulet.  Do you know why this issue is happening?

Comment 2

[Mike Hommey [:glandium]]

Does mulet use a package manifest?

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Mike Hommey [:glandium] from comment #2)
> Does mulet use a package manifest?

Yes, I believe so.  It appears to use the Firefox one.  Mulet's build.mk[1] includes /browser/build.mk.  /browser/installer/Makefile.in references MOZ_MULET[2], so it would seem likely the Firefox installer and package manifest path are used by Mulet.

[1]: https://dxr.allizom.org/mozilla-central/source/b2g/dev/build.mk
[2]: https://dxr.allizom.org/mozilla-central/source/browser/installer/Makefile.in?offset=100#15

Comment 4

[Michael Shal [:mshal]]

It looks like the tests are being included because of this line:

https://dxr.mozilla.org/mozilla-central/source/b2g/installer/package-manifest.in#35

It's inside the #if XP_MACOSX which is why it only happens on those platforms, and since it's in the b2g manifest we don't see it on Firefox desktop.

:spohl, is the @RESPATH@ line intentional? Why do we want both that (which seems to include everything) and all of the specific @RESPATH@/path/to/file lines in the rest of the manifest?

Comment 5

[Stephen A Pohl [:spohl]]

It looks like this should have been changed to @BINPATH@ (instead of @RESPATH@). However, the fact that everything seems to be running normally despite this error makes me think that this line could be removed completely. We may already be packaging all the files under MacOS individually.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Exclude tests from Mac B2G / Mulet packages

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c3d6ec9abe4

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Exclude tests from Mac B2G / Mulet packages v2

Had to also define LPROJ_ROOT for b2g.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27c6106f8e91

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Results:

* Simulator XPI: 141 MB -> 96 MB: 45 MB saved
* Mulet DMG: 162 MB -> 73 MB: 89 MB saved

\o/

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/053d760eb1cf

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/053d760eb1cf

Comment 11

[Evelyn Hung]

I found Simulator on MacOS breaks after this commit, should we backout here?

Comment 12

[Evelyn Hung]

(In reply to Evelyn Hung [:evelyn] from comment #11)
> I found Simulator on MacOS breaks after this commit, should we backout here?

by "breaks" I mean WebIDE couldn't launch the installed xpi.

I followed the instruction here to build the xpi:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Developing_Gaia/Running_custom_builds_in_WebIDE#Building_a_custom_b2g_binary

Comment 13

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Evelyn Hung [:evelyn] from comment #11)
> I found Simulator on MacOS breaks after this commit, should we backout here?

Sorry for the trouble.  I can reproduce.  I'll either post a fix or back this out by the end of the day.

Comment 14

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Evelyn Hung [:evelyn] from comment #11)
> I found Simulator on MacOS breaks after this commit, should we backout here?

I'll resolve this in bug 1201672.