Closed Bug 1193365 Opened 4 years ago Closed 4 years ago

Nightly spams lots of output to terminal about PushService.jsm, PushServiceWebSocket.jsm, PushDB.jsm (now that dom.push.debug is enabled)

Categories

(Core :: DOM: Push Notifications, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: dholbert, Assigned: nsm)

References

Details

(Keywords: regression)

Attachments

(1 file)

STR:
 1. Start Firefox with a fresh profile, e.g. run this:
      mkdir /tmp/foo1; firefox -profile /tmp/foo1 -no-remote
 2. Watch your terminal.

ACTUAL RESULTS:
A few addons.xpi logging messages, followed by this new output:
{
-*- PushService.jsm: init()
-*- PushService.jsm: new state: 2 old state: 0
-*- PushService.jsm: init()
-*- PushService.jsm: changeServerURL
-*- PushService.jsm: startService
-*- PushServiceWebSocket.jsm: init()
-*- PushService.jsm: startObservers
-*- PushService.jsm: changeStateConnectionEnabledEvent: true
-*- PushService.jsm: changeStateOfflineEvent: false
-*- PushDB.jsm: getAllUnexpired()
-*- PushDB.jsm: getAllByPushQuota()
-*- PushService.jsm: new state: 5 old state: 2
-*- PushService.jsm: receiveMessage(): Push:RegisterEventNotificationListener
-*- PushService.jsm: Adding child listener
}

EXPECTED RESULTS: No such logging (by default, in nightly builds) unless I opted in to see it with a pref.

It looks like this logging is controlled by the pref dom.push.debug, which was recently enabled in bug 1153499, with the other Push-related prefs.

:nsm, do we really need to have this "debug" pref enabled by default? (in opt nightly builds)
(Note that Nightly builds are generally pretty silent in terms of logging/terminal-spew, which is why this stood out to me.)
Assignee: nobody → nsm.nikhil
Flags: needinfo?(nsm.nikhil)
Comment on attachment 8646544 [details]
MozReview Request: Bug 1193365 - Disable push debug. r?kitcambridge

https://reviewboard.mozilla.org/r/15795/#review14075

Ship It!
Attachment #8646544 - Flags: review?(kcambridge) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4fd08002000bf48aaa6b0113566ea55b83c39f6c
changeset:  4fd08002000bf48aaa6b0113566ea55b83c39f6c
user:       Nikhil Marathe <nsm.nikhil@gmail.com>
date:       Tue Aug 11 12:53:14 2015 -0700
description:
Bug 1193365 - Disable push debug. r=kitcambridge
https://hg.mozilla.org/mozilla-central/rev/4fd08002000b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Looks like this affects DevEdition 42 -- e.g. my current DevEdition version, which is 42.0a2 (2015-08-17).

(Looks like bug 1153499 landed before the aurora merge, vs. the fix on this bug here landed after the merge.)

nsm, can you request backport approval to reduce default-terminalspew on DevEdition?
Flags: needinfo?(nsm.nikhil)
Comment on attachment 8646544 [details]
MozReview Request: Bug 1193365 - Disable push debug. r?kitcambridge

Approval Request Comment
[Feature/regressing bug #]: Bug 1153499
[User impact if declined]: A lot of unnecessary logging information is printed on the console by default. This is an annoyance to developers and interferes with investigating other issues. There is no end-user impact.
[Describe test coverage new/current, TreeHerder]: None, this just switches off logging.
[Risks and why]: None
[String/UUID change made/needed]: None
Flags: needinfo?(nsm.nikhil)
Attachment #8646544 - Flags: approval-mozilla-aurora?
Comment on attachment 8646544 [details]
MozReview Request: Bug 1193365 - Disable push debug. r?kitcambridge

Less debug messages is better, taking it.
Attachment #8646544 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.