Closed Bug 1193377 Opened 9 years ago Closed 9 years ago

Remove SCHEDULER_COALESCE_THRESHOLD_MS from TelemetrySession.jsm

Categories

(Toolkit :: Telemetry, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox42 --- wontfix
firefox43 --- fixed

People

(Reporter: gfritzsche, Assigned: aaronraimist, Mentored)

References

Details

(Whiteboard: [lang=js] [good first bug])

Attachments

(1 file)

We removed the coalescing logic in bug 1187339, but apparently missed removing that constant:
https://dxr.mozilla.org/mozilla-central/rev/d6ea652c579992daa9041cc9718bb7c6abefbc91/toolkit/components/telemetry/TelemetrySession.jsm#96

To confirm that nothing breaks, run the unit tests for Telemetry:
mach xpcshell-test toolkit/components/telemetry/tests/unit
Bug 1193377 - Remove SCHEDULER_COALESCE_THRESHOLD_MS from TelemetrySession.jsm; r?gfritzsche
Attachment #8646723 - Flags: review?(gfritzsche)
Assignee: nobody → aaronraimist
Comment on attachment 8646723 [details]
MozReview Request: Bug 1193377 - Remove SCHEDULER_COALESCE_THRESHOLD_MS from TelemetrySession.jsm; r?gfritzsche

https://reviewboard.mozilla.org/r/15861/#review14121

Thanks, this looks good.
Attachment #8646723 - Flags: review?(gfritzsche) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9ae8dca42f4b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: