1193416 - principal.baseDomain returns ipv6 address without enclosing []

Status: NEW

(Core :: DOM: Core & HTML, defect)

Description

[Nika Layzell [:nika] (ooo, ni? for response)]

This is necessary with ipv6 URIs due to ports being ambiguous without it.

I'm not sure if we want this because nsIURI.host doesn't surround the ipv6 address in []s, and it feels like baseDomain should act the same way, but it may make sense to include them in this case.

Comment 1

[(no longer active)]

(In reply to Michael Layzell [:mystor] from comment #0)
> This is necessary with ipv6 URIs due to ports being ambiguous without it.
> 
> I'm not sure if we want this because nsIURI.host doesn't surround the ipv6
> address in []s, and it feels like baseDomain should act the same way, but it
> may make sense to include them in this case.

Let's ask Bobby!

Comment 2

[Bobby Holley (:bholley)]

Does this means that nsIURI.host is effectively ambiguous? Is that a bug? Is there someone more knowledgeable about this subject that could weigh in?

Comment 3

[Nika Layzell [:nika] (ooo, ni? for response)]

(In reply to Bobby Holley (Mostly Out This Week) from comment #2)
> Does this means that nsIURI.host is effectively ambiguous? Is that a bug? Is
> there someone more knowledgeable about this subject that could weigh in?

Based on my understanding, nsIURI.host isn't ambiguous, nsIURI.host + ":" + nsIURI.port is ambiguous (I believe that that may be one of the reasons that nsIURI.hostPort exists, which does handle the brackets I believe - perhaps principal.origin should use that instead).

Comment 4

[Bobby Holley (:bholley)]

Is this effectively subsumed by bug 1195415?

Comment 5

[Nika Layzell [:nika] (ooo, ni? for response)]

(In reply to Bobby Holley (:bholley) from comment #4)
> Is this effectively subsumed by bug 1195415?

I think that this is something separate, as it handles the .origin property, not the .baseDomain property, but I also feel like this should probably be WONTFIX, as the behavior of baseDomain should match nsIURI.host, which currently doesn't include the []s (bug 1195459 comment 1 has an explanation as to why).