Closed
Bug 1195415
Opened 6 years ago
Closed 6 years ago
Use nsIURI.hostPort instead of manually writing host/port logic in nsPrincipal.origin logic
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
References
Details
Attachments
(1 file, 1 obsolete file)
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8648960 -
Flags: review?(bobbyholley)
Comment 2•6 years ago
|
||
Comment on attachment 8648960 [details] [diff] [review] Add asciiHostPort field to nsIURI, and use it in the implementation of nsPrincipal::GetOriginForURI Review of attachment 8648960 [details] [diff] [review]: ----------------------------------------------------------------- ::: netwerk/base/nsSimpleURI.cpp @@ +529,5 @@ > > NS_IMETHODIMP > +nsSimpleURI::GetAsciiHostPort(nsACString &result) > +{ > + return NS_ERROR_FAILURE; Maybe add a comment in GetPort() indicating that we need to fix that method we should fix this one too? ::: netwerk/base/nsStandardURL.cpp @@ +1107,5 @@ > + result = Hostport(); > + return NS_OK; > + } > + > + // this doesn't fail This comment is probably infer-able from the expression that follows it. ::: netwerk/test/unit/test_bug1195415.js @@ +1,1 @@ > +// Test for bug 1195415 This is awesome. Can you check .origin for these cases too while you're at it? Or did that happen for the other bug?
Attachment #8648960 -
Flags: review?(bobbyholley) → review+
Assignee | ||
Comment 3•6 years ago
|
||
This is an updated version of the patch which actually updates the UUIDs, and acknowledges the hack in nsBinaryStream.
Attachment #8648960 -
Attachment is obsolete: true
Attachment #8649422 -
Flags: review?(bobbyholley)
Updated•6 years ago
|
Attachment #8649422 -
Flags: review?(bobbyholley) → review+
Comment 5•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/75ba313634f3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox43:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•