1195415 - Use nsIURI.hostPort instead of manually writing host/port logic in nsPrincipal.origin logic

Status: RESOLVED FIXED

Description

[:Nika Layzell (ni? for response)]

See bug 1192666 comment 11.

Comment 1

[:Nika Layzell (ni? for response)]

Attachment: Add asciiHostPort field to nsIURI, and use it in the implementation of nsPrincipal::GetOriginForURI

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 8648960 [details] [diff] [review]
Add asciiHostPort field to nsIURI, and use it in the implementation of nsPrincipal::GetOriginForURI

Review of attachment 8648960 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/nsSimpleURI.cpp
@@ +529,5 @@
>  
>  NS_IMETHODIMP
> +nsSimpleURI::GetAsciiHostPort(nsACString &result)
> +{
> +    return NS_ERROR_FAILURE;

Maybe add a comment in GetPort() indicating that we need to fix that method we should fix this one too?

::: netwerk/base/nsStandardURL.cpp
@@ +1107,5 @@
> +        result = Hostport();
> +        return NS_OK;
> +    }
> +
> +    // this doesn't fail

This comment is probably infer-able from the expression that follows it.

::: netwerk/test/unit/test_bug1195415.js
@@ +1,1 @@
> +// Test for bug 1195415

This is awesome. Can you check .origin for these cases too while you're at it? Or did that happen for the other bug?

Comment 3

[:Nika Layzell (ni? for response)]

Attachment: Add asciiHostPort field to nsIURI, and use it in the implementation of nsPrincipal::GetOriginForURI

This is an updated version of the patch which actually updates the UUIDs, and acknowledges the hack in nsBinaryStream.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/75ba313634f3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/75ba313634f3