1193594 - Attempt to upload a new version of a search plugin results in an error.

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Kris Maglione [:kmag]]

Search plugins don't have IDs. Or versions, as such. Our upload process for them is basically a complete hack. The ValidationAnnotator doesn't expect this, so it searches for a matching add-on with a null `guid`, and gets back thousands of results.

Comment 1

[Kris Maglione [:kmag]]

https://github.com/mozilla/olympia/pull/655

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/898acff52a20b53cd584e960c3f35bf03feb8c0a
Bug 1193594: Don't try to find a matching add-on for search plugins (which have no ID) during upload.

https://github.com/mozilla/olympia/commit/9658fa47ceef0c6f484e40a6e82d87ea2aa3a687
Merge pull request #655 from kmaglione/search-plugin-validation

Bug 1193594: Don't try to find a matching add-on for search plugins (…which have no ID) during upload.

Comment 3

[Madalin Cotetiu]

I have uploaded a search engine, then approved, but I'm not sure how i can upload a update. When trying to upload a new version from the dev hub I'm getting this error: http://screencast.com/t/D0EzdLTR

Can you please provide some steps on how we can test this issue?

Comment 4

[Kris Maglione [:kmag]]

Unfortunately, it's only possible to upload a new version of a search plugin once a day, since they just use the current date as their version. You should be able to upload a new version of an older, existing plugin, or just try again with that one tomorrow.

Comment 5

[Madalin Cotetiu]

I have successfully uploaded/approved an update for a search engine.
Closing bug.