119362 - PK11_ImportSymKey should be able to enable multiple operations

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement, P1)

Description

[Jamie Nicolson]

We don't know when we imnport a symmetric key what it will be used for, so I
want to enable it for all operations.

Comment 1

[Wan-Teh Chang]

Set priority to P1 for NSS 3.4.

Comment 2

[Robert Relyea]

Attachment: Proposed patch to create a PK11_ImportSymKeyWithFlags()

Basically move the Flags->template utility function above the SymKey function,
Convert the existing ImportsymKey function to an internal ImportSymkey function
which imports by template.
Create a new ImportSymKey function which calls the new internal ImportSymkey
function
Cerate a new ImportSymKeyWithFlags which calls the new internal ImportSymkey
funciton

Comment 3

[Robert Relyea]

This patch is checked in. I'll close it when Jamie verifies it functions as needed.

Comment 4

[Wan-Teh Chang]

Comment on attachment 67527 [details] [diff] [review]
Proposed patch to create a PK11_ImportSymKeyWithFlags()

r=wtc.

Nit: the assertion

  PR_ASSERT(templateCount+1 <= sizeof(keyTemplate)/sizeof(CK_ATTRIBUTE));

can be simplified to

  PR_ASSERT(templateCount < sizeof(keyTemplate)/sizeof(CK_ATTRIBUTE));

Comment 5

[Robert Relyea]

reopen if functions do not work.