Closed Bug 1193830 Opened 4 years ago Closed 4 years ago

Clicking on the icon to mute then unmute (or unmute then mute) without moving the mouse off the icon switches tabs

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 43
Tracking Status
firefox42 + verified
firefox43 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

Clicking on the icon to mute then unmute (or unmute then mute) without moving the mouse off the icon switches tabs.

We shouldn't switch tabs if the audio icon is being clicked. I think this is the result of the `_overPlayingIcon` becoming false when the button is clicked, and it not being true when the icon is clicked a second time causing the tab to get switched to.
Attached patch PatchSplinter Review
I ran browser/base/content/test/general/browser_tabAudioIcon.js locally.
Browser Chrome Test Summary
        Passed: 86
        Failed: 0
        Todo: 0
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8647017 - Flags: review?(gijskruitbosch+bugs)
[Tracking Requested - why for this release]:
Tab audio icons are shipping in 42, and I want to make sure this doesn't get forgotten.
Duplicate of this bug: 1192974
Comment on attachment 8647017 [details] [diff] [review]
Patch

Review of attachment 8647017 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8647017 - Flags: review?(gijskruitbosch+bugs) → review+
Backed out for bustage:

https://hg.mozilla.org/integration/fx-team/rev/0ab25f8c278f

TEST-UNEXPECTED-FAIL | unknown test url | uncaught exception - TypeError: soundPlayingIcon is null at chrome://browser/content/tabbrowser.xml:5880

(and similar other failures)
https://hg.mozilla.org/mozilla-central/rev/879d3f7ab245
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Jared, do you want to uplift this to Aurora?
Flags: needinfo?(jaws)
Comment on attachment 8647017 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: icon for tab audio
[User impact if declined]: various bugs related to the icon not responding to clicks or tabs becoming unselectable
[Describe test coverage new/current, TreeHerder]: automated tests cover tab audio indicator
[Risks and why]: none expected, removes some manual state tracking
[String/UUID change made/needed]: none
Flags: needinfo?(jaws)
Attachment #8647017 - Flags: approval-mozilla-aurora?
New feature, tracking it.
Comment on attachment 8647017 [details] [diff] [review]
Patch

Want the new feature polished.
Attachment #8647017 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Aurora 42.0a2 (buildID: 20150818004007) and Nightly 43.0a1 (buildID: 20150818030209).
Status: RESOLVED → VERIFIED
Duplicate of this bug: 1190770
You need to log in before you can comment on or make changes to this bug.