Closed Bug 1193974 Opened 4 years ago Closed 4 years ago

Remove new_tablet prefix from ids, resources, etc.

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(3 files)

We did every file in bug 1150742 – let's get rid of the actual in-file stuff now.
Bug 1193974 - Remove new from tablet_* colors. r=mhaigh

Refactor automated w/ Intellij.
Attachment #8650190 - Flags: review?(mhaigh)
Bug 1193974 - Remove new from tablet_* dimens. r=mhaigh

We could remove tablet_* and move these values to the values-large
configuration but it's scope creeping for not much gain. The
attributes are prepended with tablet_* so they should be easy to
fix in the future should we choose to.

Refactoring automated w/ Intellij.
Attachment #8650191 - Flags: review?(mhaigh)
Btw, if this is going to bitrot you, I can wait to land this, Martyn.
Comment on attachment 8650190 [details]
MozReview Request: Bug 1193974 - Remove new from tablet_* colors. r=mhaigh

https://reviewboard.mozilla.org/r/16571/#review14889

Ship It!
Attachment #8650190 - Flags: review?(mhaigh) → review+
Attachment #8650191 - Flags: review?(mhaigh) → review+
Comment on attachment 8650191 [details]
MozReview Request: Bug 1193974 - Remove new from tablet_* dimens. r=mhaigh

https://reviewboard.mozilla.org/r/16573/#review14891

Ship It!
Attachment #8650192 - Flags: review?(mhaigh) → review+
Comment on attachment 8650192 [details]
MozReview Request: Bug 1193974 - Remove new from tablet_tab_strip id. r=mhaigh

https://reviewboard.mozilla.org/r/16575/#review14893

Ship It!
url:        https://hg.mozilla.org/integration/fx-team/rev/bac57019853ca1228cf0a1dca9b53019e01e1623
changeset:  bac57019853ca1228cf0a1dca9b53019e01e1623
user:       Michael Comella <michael.l.comella@gmail.com>
date:       Wed Aug 19 15:59:43 2015 -0700
description:
Bug 1193974 - Remove new from tablet_* colors. r=mhaigh

Refactor automated w/ Intellij.

url:        https://hg.mozilla.org/integration/fx-team/rev/4819bc95cbede50b35710f70f70d83f39cb1f6be
changeset:  4819bc95cbede50b35710f70f70d83f39cb1f6be
user:       Michael Comella <michael.l.comella@gmail.com>
date:       Wed Aug 19 16:13:08 2015 -0700
description:
Bug 1193974 - Remove new from tablet_* dimens. r=mhaigh

We could remove tablet_* and move these values to the values-large
configuration but it's scope creeping for not much gain. The
attributes are prepended with tablet_* so they should be easy to
fix in the future should we choose to.

Refactoring automated w/ Intellij.

url:        https://hg.mozilla.org/integration/fx-team/rev/03cd5896911b3d50233de7c9ae44be4fbeb4ff2b
changeset:  03cd5896911b3d50233de7c9ae44be4fbeb4ff2b
user:       Michael Comella <michael.l.comella@gmail.com>
date:       Wed Aug 19 16:15:30 2015 -0700
description:
Bug 1193974 - Remove new from tablet_tab_strip id. r=mhaigh
You need to log in before you can comment on or make changes to this bug.