Closed Bug 1150742 Opened 10 years ago Closed 9 years ago

Rename new_tablet files in resources/ dir

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox43 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(23 files)

MozReview Request: Bug 1150742 - Move new_tablet_action_bar_button -> browser_toolbar_action_bar_button. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Removed unused new_tablet_tab_close. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Rename new_tablet_tabs_counter -> tabs_counter. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Rename new_tablet_tabs_count_foreground -> tab_count_foreground. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - new_tablet_tabs_counter -> tabs_counter. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new_tablet prefix from color resources. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Add note in layout.xml explaining what the @null references are. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Move once-used forward button style to use in layout. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Move new_tablet_ic_menu_forward -> ic_menu_forward. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new_tablet_ from ic_menu_back. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new_tablet from ic_menu_reload. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Rename new_tablet_nav_back -> tabs_panel_nav_back. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new_tablet from tabs_panel_back_button. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new_tablet from tab_strip_button. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new_tablet from url_bar_nav_button. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new from tablet_tab_close. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new_tablet from tab_item_close_button. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new from tablet_menu. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new_tablet from tab_new_dark. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new_tablet from tab_strip_add_tab. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new_tablet from tab_strip_divider. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new_tablet from tab_strip. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
MozReview Request: Bug 1150742 - Remove new from tablet_tabs_item_cell. r=mhaigh
40 bytes, text/x-review-board-request
mhaigh
: review+
Details
Bug 1106935 removed the major branches in the code for the new/old tablet divide. This bug is to fix up the resources which is primarily: * Removing the "new_tablet_*" prefix from dimens, layouts, etc. * Removing the ".NewTablet" suffix on various styles
Margaret mentioned on irc that this is confusing to users unfamiliar with the code.
Assignee: nobody → michael.l.comella
Bug 1150742 - Move new_tablet_action_bar_button -> browser_toolbar_action_bar_button. r=mhaigh drawable/action_bar_button is used on tablets in some layouts (e.g. tab_history_item_row) so we can't shadow it in drawable-large-.../action_bar_button.
Attachment #8646682 - Flags: review?(mhaigh)
Bug 1150742 - Removed unused new_tablet_tab_close. r=mhaigh There were some of these in the drawable-large-* directories and this file is only used in large+ configs, so it is unused.
Attachment #8646683 - Flags: review?(mhaigh)
Bug 1150742 - Rename new_tablet_tabs_count_foreground -> tab_count_foreground. r=mhaigh The new name shadows the non-large config.
Attachment #8646685 - Flags: review?(mhaigh)
Bug 1150742 - new_tablet_tabs_counter -> tabs_counter. r=mhaigh This shadows the non-large config.
Attachment #8646686 - Flags: review?(mhaigh)
Bug 1150742 - Add note in layout.xml explaining what the @null references are. r=mhaigh We could do this in many more places, but this is a start.
Attachment #8646688 - Flags: review?(mhaigh)
Bug 1150742 - Move once-used forward button style to use in layout. r=mhaigh When styles are only used once, there is no need to clutter up the styles files for them.
Attachment #8646689 - Flags: review?(mhaigh)
Bug 1150742 - Move new_tablet_ic_menu_forward -> ic_menu_forward. r=mhaigh This involved removing drawable-large-v11/ic_menu_forward.xml, which was a null reference presumably there to save memory when the browser_app menu loaded the forward menu item. Also, the new_tablet_ic_menu_forward null reference for API 9 builds was removed.
Attachment #8646690 - Flags: review?(mhaigh)
Bug 1150742 - Remove new_tablet_ from ic_menu_back. r=mhaigh Similar deal to the previous commit on ic_menu_forward.
Attachment #8646691 - Flags: review?(mhaigh)
Bug 1150742 - Remove new_tablet from ic_menu_reload. r=mhaigh Similar deal to the previous two changesets on back and forward.
Attachment #8646692 - Flags: review?(mhaigh)
Bug 1150742 - Remove new_tablet from tab_strip_button. r=mhaigh Also removed the drawable/ null reference because it was unneeded.
Attachment #8646695 - Flags: review?(mhaigh)
Bug 1150742 - Remove new from tablet_tab_close. r=mhaigh tablet_* is not ideal but there is a collision between phone and tablet assets so I filed bug 1193585 to complete this process.
Attachment #8646697 - Flags: review?(mhaigh)
I'll file follow-ups to handle other new_tablet_* files and ".NewTablet" styles because this is getting long. Note that there are still ~five more files to change. Sorry, Martyn!
Summary: Rename new tablet resources & overwrite old tablet resources → Rename new_tablet files in resources/ dir
Comment on attachment 8646682 [details] MozReview Request: Bug 1150742 - Move new_tablet_action_bar_button -> browser_toolbar_action_bar_button. r=mhaigh https://reviewboard.mozilla.org/r/15493/#review14123 Ship It!
Attachment #8646682 - Flags: review?(mhaigh) → review+
Comment on attachment 8646683 [details] MozReview Request: Bug 1150742 - Removed unused new_tablet_tab_close. r=mhaigh https://reviewboard.mozilla.org/r/15495/#review14125 Ship It!
Attachment #8646683 - Flags: review?(mhaigh) → review+
Attachment #8646684 - Flags: review?(mhaigh) → review+
Comment on attachment 8646684 [details] MozReview Request: Bug 1150742 - Rename new_tablet_tabs_counter -> tabs_counter. r=mhaigh https://reviewboard.mozilla.org/r/15497/#review14127 Ship It! ::: mobile/android/base/resources/layout-large-v11/browser_toolbar.xml:79 (Diff revision 1) > - android:layout="@layout/new_tablet_tabs_counter"/> > + /> For the sake of consistency, we should try and keep the close tag markup at the end of the last line, not the line after.
Comment on attachment 8646685 [details] MozReview Request: Bug 1150742 - Rename new_tablet_tabs_count_foreground -> tab_count_foreground. r=mhaigh https://reviewboard.mozilla.org/r/15499/#review14129 Ship It!
Attachment #8646685 - Flags: review?(mhaigh) → review+
Comment on attachment 8646686 [details] MozReview Request: Bug 1150742 - new_tablet_tabs_counter -> tabs_counter. r=mhaigh https://reviewboard.mozilla.org/r/15501/#review14131 Ship It!
Attachment #8646686 - Flags: review?(mhaigh) → review+
Comment on attachment 8646687 [details] MozReview Request: Bug 1150742 - Remove new_tablet prefix from color resources. r=mhaigh https://reviewboard.mozilla.org/r/15503/#review14133 Ship It!
Attachment #8646687 - Flags: review?(mhaigh) → review+
Comment on attachment 8646688 [details] MozReview Request: Bug 1150742 - Add note in layout.xml explaining what the @null references are. r=mhaigh https://reviewboard.mozilla.org/r/15505/#review14135 Ship It!
Attachment #8646688 - Flags: review?(mhaigh) → review+
Comment on attachment 8646689 [details] MozReview Request: Bug 1150742 - Move once-used forward button style to use in layout. r=mhaigh https://reviewboard.mozilla.org/r/15833/#review14137 Ship It! ::: mobile/android/base/resources/layout-large-v11/browser_toolbar.xml:57 (Diff revision 1) > + /> Move this to the line above
Attachment #8646689 - Flags: review?(mhaigh) → review+
Comment on attachment 8646690 [details] MozReview Request: Bug 1150742 - Move new_tablet_ic_menu_forward -> ic_menu_forward. r=mhaigh https://reviewboard.mozilla.org/r/15835/#review14141 Ship It!
Attachment #8646690 - Flags: review?(mhaigh) → review+
Comment on attachment 8646691 [details] MozReview Request: Bug 1150742 - Remove new_tablet_ from ic_menu_back. r=mhaigh https://reviewboard.mozilla.org/r/15837/#review14143 Ship It!
Attachment #8646691 - Flags: review?(mhaigh) → review+
Comment on attachment 8646692 [details] MozReview Request: Bug 1150742 - Remove new_tablet from ic_menu_reload. r=mhaigh https://reviewboard.mozilla.org/r/15839/#review14145 Ship It!
Attachment #8646692 - Flags: review?(mhaigh) → review+
Comment on attachment 8646693 [details] MozReview Request: Bug 1150742 - Rename new_tablet_nav_back -> tabs_panel_nav_back. r=mhaigh https://reviewboard.mozilla.org/r/15841/#review14147 Ship It!
Attachment #8646693 - Flags: review?(mhaigh) → review+
Attachment #8646694 - Flags: review?(mhaigh) → review+
Comment on attachment 8646694 [details] MozReview Request: Bug 1150742 - Remove new_tablet from tabs_panel_back_button. r=mhaigh https://reviewboard.mozilla.org/r/15843/#review14149 Ship It!
Comment on attachment 8646695 [details] MozReview Request: Bug 1150742 - Remove new_tablet from tab_strip_button. r=mhaigh https://reviewboard.mozilla.org/r/15845/#review14151 Ship It!
Attachment #8646695 - Flags: review?(mhaigh) → review+
Attachment #8646696 - Flags: review?(mhaigh) → review+
Comment on attachment 8646696 [details] MozReview Request: Bug 1150742 - Remove new_tablet from url_bar_nav_button. r=mhaigh https://reviewboard.mozilla.org/r/15847/#review14153 Ship It!
Comment on attachment 8646697 [details] MozReview Request: Bug 1150742 - Remove new from tablet_tab_close. r=mhaigh https://reviewboard.mozilla.org/r/15849/#review14155 Ship It!
Attachment #8646697 - Flags: review?(mhaigh) → review+
Comment on attachment 8646698 [details] MozReview Request: Bug 1150742 - Remove new_tablet from tab_item_close_button. r=mhaigh https://reviewboard.mozilla.org/r/15851/#review14157 Ship It!
Attachment #8646698 - Flags: review?(mhaigh) → review+
Attachment #8646699 - Flags: review?(mhaigh) → review+
Comment on attachment 8646699 [details] MozReview Request: Bug 1150742 - Remove new from tablet_menu. r=mhaigh https://reviewboard.mozilla.org/r/15853/#review14159 Ship It!
https://reviewboard.mozilla.org/r/15497/#review14127 > For the sake of consistency, we should try and keep the close tag markup at the end of the last line, not the line after. I prefer to close on a new line because it prevents excessive blame changes. I'd prefer to move to this style in general, and this seems like a harmless way to start. What do you think?
Flags: needinfo?(mhaigh)
Comment on attachment 8646682 [details] MozReview Request: Bug 1150742 - Move new_tablet_action_bar_button -> browser_toolbar_action_bar_button. r=mhaigh Bug 1150742 - Move new_tablet_action_bar_button -> browser_toolbar_action_bar_button. r=mhaigh drawable/action_bar_button is used on tablets in some layouts (e.g. tab_history_item_row) so we can't shadow it in drawable-large-.../action_bar_button.
Comment on attachment 8646683 [details] MozReview Request: Bug 1150742 - Removed unused new_tablet_tab_close. r=mhaigh Bug 1150742 - Removed unused new_tablet_tab_close. r=mhaigh There were some of these in the drawable-large-* directories and this file is only used in large+ configs, so it is unused.
Comment on attachment 8646684 [details] MozReview Request: Bug 1150742 - Rename new_tablet_tabs_counter -> tabs_counter. r=mhaigh Bug 1150742 - Rename new_tablet_tabs_counter -> tabs_counter. r=mhaigh
Comment on attachment 8646685 [details] MozReview Request: Bug 1150742 - Rename new_tablet_tabs_count_foreground -> tab_count_foreground. r=mhaigh Bug 1150742 - Rename new_tablet_tabs_count_foreground -> tab_count_foreground. r=mhaigh The new name shadows the non-large config.
Comment on attachment 8646686 [details] MozReview Request: Bug 1150742 - new_tablet_tabs_counter -> tabs_counter. r=mhaigh Bug 1150742 - new_tablet_tabs_counter -> tabs_counter. r=mhaigh This shadows the non-large config.
Comment on attachment 8646687 [details] MozReview Request: Bug 1150742 - Remove new_tablet prefix from color resources. r=mhaigh Bug 1150742 - Remove new_tablet prefix from color resources. r=mhaigh
Comment on attachment 8646688 [details] MozReview Request: Bug 1150742 - Add note in layout.xml explaining what the @null references are. r=mhaigh Bug 1150742 - Add note in layout.xml explaining what the @null references are. r=mhaigh We could do this in many more places, but this is a start.
Comment on attachment 8646689 [details] MozReview Request: Bug 1150742 - Move once-used forward button style to use in layout. r=mhaigh Bug 1150742 - Move once-used forward button style to use in layout. r=mhaigh When styles are only used once, there is no need to clutter up the styles files for them.
Comment on attachment 8646690 [details] MozReview Request: Bug 1150742 - Move new_tablet_ic_menu_forward -> ic_menu_forward. r=mhaigh Bug 1150742 - Move new_tablet_ic_menu_forward -> ic_menu_forward. r=mhaigh This involved removing drawable-large-v11/ic_menu_forward.xml, which was a null reference presumably there to save memory when the browser_app menu loaded the forward menu item. Also, the new_tablet_ic_menu_forward null reference for API 9 builds was removed.
Comment on attachment 8646691 [details] MozReview Request: Bug 1150742 - Remove new_tablet_ from ic_menu_back. r=mhaigh Bug 1150742 - Remove new_tablet_ from ic_menu_back. r=mhaigh Similar deal to the previous commit on ic_menu_forward.
Comment on attachment 8646692 [details] MozReview Request: Bug 1150742 - Remove new_tablet from ic_menu_reload. r=mhaigh Bug 1150742 - Remove new_tablet from ic_menu_reload. r=mhaigh Similar deal to the previous two changesets on back and forward.
Comment on attachment 8646693 [details] MozReview Request: Bug 1150742 - Rename new_tablet_nav_back -> tabs_panel_nav_back. r=mhaigh Bug 1150742 - Rename new_tablet_nav_back -> tabs_panel_nav_back. r=mhaigh
Comment on attachment 8646694 [details] MozReview Request: Bug 1150742 - Remove new_tablet from tabs_panel_back_button. r=mhaigh Bug 1150742 - Remove new_tablet from tabs_panel_back_button. r=mhaigh
Comment on attachment 8646695 [details] MozReview Request: Bug 1150742 - Remove new_tablet from tab_strip_button. r=mhaigh Bug 1150742 - Remove new_tablet from tab_strip_button. r=mhaigh Also removed the drawable/ null reference because it was unneeded.
Comment on attachment 8646696 [details] MozReview Request: Bug 1150742 - Remove new_tablet from url_bar_nav_button. r=mhaigh Bug 1150742 - Remove new_tablet from url_bar_nav_button. r=mhaigh
Comment on attachment 8646697 [details] MozReview Request: Bug 1150742 - Remove new from tablet_tab_close. r=mhaigh Bug 1150742 - Remove new from tablet_tab_close. r=mhaigh tablet_* is not ideal but there is a collision between phone and tablet assets so I filed bug 1193585 to complete this process.
Comment on attachment 8646698 [details] MozReview Request: Bug 1150742 - Remove new_tablet from tab_item_close_button. r=mhaigh Bug 1150742 - Remove new_tablet from tab_item_close_button. r=mhaigh
Comment on attachment 8646699 [details] MozReview Request: Bug 1150742 - Remove new from tablet_menu. r=mhaigh Bug 1150742 - Remove new from tablet_menu. r=mhaigh
Bug 1150742 - Remove new_tablet from tab_strip. r=mhaigh This involved renaming the existing tab_strip layout to tab_strip_inner as it was originally contained within the new_tablet_tab_strip layout.
Attachment #8647159 - Flags: review?(mhaigh)
This is the last of the changes.
(In reply to Michael Comella (:mcomella) from comment #20) > I'll file follow-ups to handle other new_tablet_* files bug 1193974. > and ".NewTablet" bug 1193975.
Comment on attachment 8647156 [details] MozReview Request: Bug 1150742 - Remove new_tablet from tab_new_dark. r=mhaigh https://reviewboard.mozilla.org/r/15909/#review14249 Ship It!
Attachment #8647156 - Flags: review?(mhaigh) → review+
Attachment #8647157 - Flags: review?(mhaigh) → review+
Comment on attachment 8647157 [details] MozReview Request: Bug 1150742 - Remove new_tablet from tab_strip_add_tab. r=mhaigh https://reviewboard.mozilla.org/r/15911/#review14251 Ship It!
Comment on attachment 8647158 [details] MozReview Request: Bug 1150742 - Remove new_tablet from tab_strip_divider. r=mhaigh https://reviewboard.mozilla.org/r/15913/#review14253 Ship It!
Attachment #8647158 - Flags: review?(mhaigh) → review+
Comment on attachment 8647159 [details] MozReview Request: Bug 1150742 - Remove new_tablet from tab_strip. r=mhaigh https://reviewboard.mozilla.org/r/15915/#review14255 Ship It!
Attachment #8647159 - Flags: review?(mhaigh) → review+
Comment on attachment 8647160 [details] MozReview Request: Bug 1150742 - Remove new from tablet_tabs_item_cell. r=mhaigh https://reviewboard.mozilla.org/r/15917/#review14257 Ship It!
Attachment #8647160 - Flags: review?(mhaigh) → review+
(In reply to Michael Comella (:mcomella) from comment #39) > https://reviewboard.mozilla.org/r/15497/#review14127 > > > For the sake of consistency, we should try and keep the close tag markup at the end of the last line, not the line after. > > I prefer to close on a new line because it prevents excessive blame changes. > I'd prefer to move to this style in general, and this seems like a harmless > way to start. > > What do you think? I prefer to have it on a new line too, just make sure that each file doesn't have multiple styles
Flags: needinfo?(mhaigh)
https://reviewboard.mozilla.org/r/15497/#review14279 ::: mobile/android/base/resources/layout-large-v11/browser_toolbar.xml:79 (Diff revision 1) > - android:layout="@layout/new_tablet_tabs_counter"/> > + /> > > I prefer to have it on a new line too, just make sure that each file doesn't have multiple styles I reverted this back then – instead of churning the whole file, we should have a discussion with the team and change them all at once. However, the I don't find the inconsistencies make the code any harder to read (unlike with code style) so I'd be fine if the changes happen gradually and inconsistently.
url: https://hg.mozilla.org/integration/fx-team/rev/f0e644734983038823413fc17419569710566a1d changeset: f0e644734983038823413fc17419569710566a1d user: Michael Comella <michael.l.comella@gmail.com> date: Thu Aug 06 16:54:55 2015 -0700 description: Bug 1150742 - Move new_tablet_action_bar_button -> browser_toolbar_action_bar_button. r=mhaigh drawable/action_bar_button is used on tablets in some layouts (e.g. tab_history_item_row) so we can't shadow it in drawable-large-.../action_bar_button. url: https://hg.mozilla.org/integration/fx-team/rev/fe2a7509276ad8b9918d3cbbd0a1e170b8e425b0 changeset: fe2a7509276ad8b9918d3cbbd0a1e170b8e425b0 user: Michael Comella <michael.l.comella@gmail.com> date: Thu Aug 06 16:58:02 2015 -0700 description: Bug 1150742 - Removed unused new_tablet_tab_close. r=mhaigh There were some of these in the drawable-large-* directories and this file is only used in large+ configs, so it is unused. url: https://hg.mozilla.org/integration/fx-team/rev/aaf2ef6f73e44fdc1baeab9f79201454edf80bb5 changeset: aaf2ef6f73e44fdc1baeab9f79201454edf80bb5 user: Michael Comella <michael.l.comella@gmail.com> date: Thu Aug 06 17:04:57 2015 -0700 description: Bug 1150742 - Rename new_tablet_tabs_counter -> tabs_counter. r=mhaigh url: https://hg.mozilla.org/integration/fx-team/rev/0be92c4b033a38444ff6370c3edc90e4db5cc480 changeset: 0be92c4b033a38444ff6370c3edc90e4db5cc480 user: Michael Comella <michael.l.comella@gmail.com> date: Thu Aug 06 17:08:11 2015 -0700 description: Bug 1150742 - Rename new_tablet_tabs_count_foreground -> tab_count_foreground. r=mhaigh The new name shadows the non-large config. url: https://hg.mozilla.org/integration/fx-team/rev/b6e425c6a777507017c4d2f4cd4922b44496a1d8 changeset: b6e425c6a777507017c4d2f4cd4922b44496a1d8 user: Michael Comella <michael.l.comella@gmail.com> date: Thu Aug 06 17:14:51 2015 -0700 description: Bug 1150742 - new_tablet_tabs_counter -> tabs_counter. r=mhaigh This shadows the non-large config. url: https://hg.mozilla.org/integration/fx-team/rev/f70b3993f1047d65e130c82ac222c093989f0da7 changeset: f70b3993f1047d65e130c82ac222c093989f0da7 user: Michael Comella <michael.l.comella@gmail.com> date: Thu Aug 06 17:23:10 2015 -0700 description: Bug 1150742 - Remove new_tablet prefix from color resources. r=mhaigh url: https://hg.mozilla.org/integration/fx-team/rev/cf92c63365bc538804f8fd05eb1866574f998202 changeset: cf92c63365bc538804f8fd05eb1866574f998202 user: Michael Comella <michael.l.comella@gmail.com> date: Thu Aug 06 17:33:13 2015 -0700 description: Bug 1150742 - Add note in layout.xml explaining what the @null references are. r=mhaigh We could do this in many more places, but this is a start. url: https://hg.mozilla.org/integration/fx-team/rev/18518f819dbab607d3d9cb5145622efdba89f481 changeset: 18518f819dbab607d3d9cb5145622efdba89f481 user: Michael Comella <michael.l.comella@gmail.com> date: Tue Aug 11 16:29:25 2015 -0700 description: Bug 1150742 - Move once-used forward button style to use in layout. r=mhaigh When styles are only used once, there is no need to clutter up the styles files for them. url: https://hg.mozilla.org/integration/fx-team/rev/d5a72977964694c27a4ffa4d37d2a21237066158 changeset: d5a72977964694c27a4ffa4d37d2a21237066158 user: Michael Comella <michael.l.comella@gmail.com> date: Tue Aug 11 16:32:22 2015 -0700 description: Bug 1150742 - Move new_tablet_ic_menu_forward -> ic_menu_forward. r=mhaigh This involved removing drawable-large-v11/ic_menu_forward.xml, which was a null reference presumably there to save memory when the browser_app menu loaded the forward menu item. Also, the new_tablet_ic_menu_forward null reference for API 9 builds was removed. url: https://hg.mozilla.org/integration/fx-team/rev/afab05b8c71a763842c171ed12f0f9848f31425f changeset: afab05b8c71a763842c171ed12f0f9848f31425f user: Michael Comella <michael.l.comella@gmail.com> date: Tue Aug 11 16:35:49 2015 -0700 description: Bug 1150742 - Remove new_tablet_ from ic_menu_back. r=mhaigh Similar deal to the previous commit on ic_menu_forward. url: https://hg.mozilla.org/integration/fx-team/rev/60b4ea3f62a2d25db006acc1b451610b833d10bf changeset: 60b4ea3f62a2d25db006acc1b451610b833d10bf user: Michael Comella <michael.l.comella@gmail.com> date: Tue Aug 11 16:40:10 2015 -0700 description: Bug 1150742 - Remove new_tablet from ic_menu_reload. r=mhaigh Similar deal to the previous two changesets on back and forward. url: https://hg.mozilla.org/integration/fx-team/rev/0b3494be4783363e9203d53a25fb9db3cb4d1e74 changeset: 0b3494be4783363e9203d53a25fb9db3cb4d1e74 user: Michael Comella <michael.l.comella@gmail.com> date: Tue Aug 11 17:04:07 2015 -0700 description: Bug 1150742 - Rename new_tablet_nav_back -> tabs_panel_nav_back. r=mhaigh url: https://hg.mozilla.org/integration/fx-team/rev/798133d5d26df4cc0771ace9e1a85e5f27ea3719 changeset: 798133d5d26df4cc0771ace9e1a85e5f27ea3719 user: Michael Comella <michael.l.comella@gmail.com> date: Tue Aug 11 17:07:09 2015 -0700 description: Bug 1150742 - Remove new_tablet from tabs_panel_back_button. r=mhaigh url: https://hg.mozilla.org/integration/fx-team/rev/6e268d8977668c3aaf1e496aa041b441827aaab2 changeset: 6e268d8977668c3aaf1e496aa041b441827aaab2 user: Michael Comella <michael.l.comella@gmail.com> date: Tue Aug 11 17:11:43 2015 -0700 description: Bug 1150742 - Remove new_tablet from tab_strip_button. r=mhaigh Also removed the drawable/ null reference because it was unneeded. url: https://hg.mozilla.org/integration/fx-team/rev/bbd328d0fbc0ee47e799fdc96ff9935c435c0303 changeset: bbd328d0fbc0ee47e799fdc96ff9935c435c0303 user: Michael Comella <michael.l.comella@gmail.com> date: Tue Aug 11 17:24:44 2015 -0700 description: Bug 1150742 - Remove new_tablet from url_bar_nav_button. r=mhaigh url: https://hg.mozilla.org/integration/fx-team/rev/8219c4f711ddaf3dbfcac4b085ffb8a892ee51ea changeset: 8219c4f711ddaf3dbfcac4b085ffb8a892ee51ea user: Michael Comella <michael.l.comella@gmail.com> date: Tue Aug 11 17:33:05 2015 -0700 description: Bug 1150742 - Remove new from tablet_tab_close. r=mhaigh tablet_* is not ideal but there is a collision between phone and tablet assets so I filed bug 1193585 to complete this process. url: https://hg.mozilla.org/integration/fx-team/rev/12af8b4026934f409bb447f8d26615c7cd4cc03c changeset: 12af8b4026934f409bb447f8d26615c7cd4cc03c user: Michael Comella <michael.l.comella@gmail.com> date: Tue Aug 11 17:34:25 2015 -0700 description: Bug 1150742 - Remove new_tablet from tab_item_close_button. r=mhaigh url: https://hg.mozilla.org/integration/fx-team/rev/5b165fcfe5af516f2b6ad2ab072735e6e845982a changeset: 5b165fcfe5af516f2b6ad2ab072735e6e845982a user: Michael Comella <michael.l.comella@gmail.com> date: Tue Aug 11 17:37:41 2015 -0700 description: Bug 1150742 - Remove new from tablet_menu. r=mhaigh url: https://hg.mozilla.org/integration/fx-team/rev/182880435b3a58489e4bd6cd50a8984c6d288ee7 changeset: 182880435b3a58489e4bd6cd50a8984c6d288ee7 user: Michael Comella <michael.l.comella@gmail.com> date: Wed Aug 12 14:04:09 2015 -0700 description: Bug 1150742 - Remove new_tablet from tab_new_dark. r=mhaigh url: https://hg.mozilla.org/integration/fx-team/rev/17f1ec96014e440d9098e7b84c8b1241c26b4bfd changeset: 17f1ec96014e440d9098e7b84c8b1241c26b4bfd user: Michael Comella <michael.l.comella@gmail.com> date: Wed Aug 12 14:06:16 2015 -0700 description: Bug 1150742 - Remove new_tablet from tab_strip_add_tab. r=mhaigh url: https://hg.mozilla.org/integration/fx-team/rev/58951259f8f967eed241f913490ed7573a566d38 changeset: 58951259f8f967eed241f913490ed7573a566d38 user: Michael Comella <michael.l.comella@gmail.com> date: Wed Aug 12 14:08:04 2015 -0700 description: Bug 1150742 - Remove new_tablet from tab_strip_divider. r=mhaigh url: https://hg.mozilla.org/integration/fx-team/rev/ca869c691300df4d18aa8170b53d7c34cf7499f6 changeset: ca869c691300df4d18aa8170b53d7c34cf7499f6 user: Michael Comella <michael.l.comella@gmail.com> date: Wed Aug 12 14:14:33 2015 -0700 description: Bug 1150742 - Remove new_tablet from tab_strip. r=mhaigh This involved renaming the existing tab_strip layout to tab_strip_inner as it was originally contained within the new_tablet_tab_strip layout. url: https://hg.mozilla.org/integration/fx-team/rev/03b4d313d6d61d5ac05b135460e7e1ef86bdafe9 changeset: 03b4d313d6d61d5ac05b135460e7e1ef86bdafe9 user: Michael Comella <michael.l.comella@gmail.com> date: Wed Aug 12 14:18:12 2015 -0700 description: Bug 1150742 - Remove new from tablet_tabs_item_cell. r=mhaigh
https://hg.mozilla.org/mozilla-central/rev/f0e644734983 https://hg.mozilla.org/mozilla-central/rev/fe2a7509276a https://hg.mozilla.org/mozilla-central/rev/aaf2ef6f73e4 https://hg.mozilla.org/mozilla-central/rev/0be92c4b033a https://hg.mozilla.org/mozilla-central/rev/b6e425c6a777 https://hg.mozilla.org/mozilla-central/rev/f70b3993f104 https://hg.mozilla.org/mozilla-central/rev/cf92c63365bc https://hg.mozilla.org/mozilla-central/rev/18518f819dba https://hg.mozilla.org/mozilla-central/rev/d5a729779646 https://hg.mozilla.org/mozilla-central/rev/afab05b8c71a https://hg.mozilla.org/mozilla-central/rev/60b4ea3f62a2 https://hg.mozilla.org/mozilla-central/rev/0b3494be4783 https://hg.mozilla.org/mozilla-central/rev/798133d5d26d https://hg.mozilla.org/mozilla-central/rev/6e268d897766 https://hg.mozilla.org/mozilla-central/rev/bbd328d0fbc0 https://hg.mozilla.org/mozilla-central/rev/8219c4f711dd https://hg.mozilla.org/mozilla-central/rev/12af8b402693 https://hg.mozilla.org/mozilla-central/rev/5b165fcfe5af https://hg.mozilla.org/mozilla-central/rev/182880435b3a https://hg.mozilla.org/mozilla-central/rev/17f1ec96014e https://hg.mozilla.org/mozilla-central/rev/58951259f8f9 https://hg.mozilla.org/mozilla-central/rev/ca869c691300 https://hg.mozilla.org/mozilla-central/rev/03b4d313d6d6
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: