1194044 - Default browser settings missing in Firefox 42 & 43

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Markus Popp]

Attachment: Screenshot of preferences page where default browser settings used to be.

In Firefox 42.0 and 43.0 there are no longer any options to make Firefox the default browser and to check if Firefox is the default browser in the General panel of the Preferences. I also couldn't find them anywhere else.

I observed this in the Linux64 versions of Firefox, running on Xubuntu 15.04. This may or may not affect other platforms too.

There was a conversation on Twitter about this issue prior to me filing this bug report: https://twitter.com/mpopp75/status/631595763437584384

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]: Unable to make default browser, regression since Firefox42

Comment 2

[Alice0775 White]

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1ee54e043b9b&tochange=939320b957c5

Regressed by: 939320b957c5	Mike Hommey — Bug 1186003 - Switch automated builds to Gtk+3. r=mshal

Comment 3

[Mike Hommey [:glandium]]

Attachment: Set HAVE_SHELL_SERVICE when preprocessing in-content prefs on Gtk+3 builds

This is the trivial fix for this.

Comment 4

[Karl Tomlinson (:karlt)]

Comment on attachment 8653839 [details] [diff] [review]
Set HAVE_SHELL_SERVICE when preprocessing in-content prefs on Gtk+3 builds

There was I assuming we'd finally fixed the nagging :)

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/93052c1a0e48

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8653839 [details] [diff] [review]
Set HAVE_SHELL_SERVICE when preprocessing in-content prefs on Gtk+3 builds

Approval Request Comment
[Feature/regressing bug #]: Regression from the combination of bug 879760 and bug 1186003.
[User impact if declined]: In-content preferences don't have the items to set Firefox as default browser (non in-content prefs do, however, but they're not enabled by default)
[Risks and why]: Very low. The patch is a simple thing that was forgotten in bug 879760. browser/components/preferences/moz.build had this change done for non in-content prefs, which is why it still works. This makes in-content prefs on-par with that.
[String/UUID change made/needed]: None

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Important regression, tracking.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/93052c1a0e48

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/88ef22723df6