+++ This bug was initially created as a clone of Bug #627699 +++ GTK+ 3.0 and GNOME 3 are approaching and we should get Firefox ready for them. This bug is about browser directory.
Whiteboard: [leave open for remaining patches][check linux try build before requesting checkin] → [check linux try build before requesting checkin]
Created attachment 758566 [details] [diff] [review] patch Benjamin, can you please check this one? Thanks!
Attachment #758566 - Flags: review?(benjamin)
Comment on attachment 758566 [details] [diff] [review] patch Not really.
Attachment #758566 - Flags: review?(benjamin) → review?(mh+mozilla)
Created attachment 760332 [details] [diff] [review] v2 Better one. Mike is away so let's ask Karlt for review. Try run for this patch - https://tbpl.mozilla.org/?tree=Try&rev=85cc0612ddc5
Comment on attachment 760332 [details] [diff] [review] v2 >-elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gtk2': >+elif CONFIG['MOZ_ENABLE_GTK']: I think MOZ_WIDGET_GTK is better, assuming that works.
Attachment #760332 - Flags: review?(karlt) → review+
Created attachment 760951 [details] [diff] [review] browser patch for check-in Thanks. An updated patch for check-in.
Attachment #760951 - Flags: review+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
What's wrong with this picture? diff --git a/browser/base/content/test/Makefile.in b/browser/base/content/test/Makefile.in --- a/browser/base/content/test/Makefile.in +++ b/browser/base/content/test/Makefile.in # test_contextmenu.html is disabled on Linux due to bug 513558 -ifneq (gtk2,$(MOZ_WIDGET_TOOLKIT)) +ifdef MOZ_WIDGET_GTK
Yes, thanks for the fix!
You need to log in before you can comment on or make changes to this bug.