Closed
Bug 879760
Opened 12 years ago
Closed 12 years ago
Port GTK2 to GTK3 - browser dir
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: stransky, Assigned: stransky)
References
Details
(Whiteboard: [check linux try build before requesting checkin])
Attachments
(2 files, 1 obsolete file)
|
16.35 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
|
16.35 KB,
patch
|
stransky
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #627699 +++
GTK+ 3.0 and GNOME 3 are approaching and we should get Firefox ready for them. This bug is about browser directory.
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [leave open for remaining patches][check linux try build before requesting checkin] → [check linux try build before requesting checkin]
|
|
Assignee | |
Comment 1•12 years ago
|
||
Benjamin, can you please check this one? Thanks!
Attachment #758566 -
Flags: review?(benjamin)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 758566 [details] [diff] [review]
patch
Not really.
Attachment #758566 -
Flags: review?(benjamin) → review?(mh+mozilla)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Better one. Mike is away so let's ask Karlt for review. Try run for this patch - https://tbpl.mozilla.org/?tree=Try&rev=85cc0612ddc5
Attachment #758566 -
Attachment is obsolete: true
Attachment #758566 -
Flags: review?(mh+mozilla)
Attachment #760332 -
Flags: review?(karlt)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 760332 [details] [diff] [review]
v2
>-elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gtk2':
>+elif CONFIG['MOZ_ENABLE_GTK']:
I think MOZ_WIDGET_GTK is better, assuming that works.
Attachment #760332 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Thanks. An updated patch for check-in.
Attachment #760951 -
Flags: review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 6•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
|
||
Comment 8•12 years ago
|
||
What's wrong with this picture?
diff --git a/browser/base/content/test/Makefile.in b/browser/base/content/test/Makefile.in
--- a/browser/base/content/test/Makefile.in
+++ b/browser/base/content/test/Makefile.in
# test_contextmenu.html is disabled on Linux due to bug 513558
-ifneq (gtk2,$(MOZ_WIDGET_TOOLKIT))
+ifdef MOZ_WIDGET_GTK
|
|
||
Comment 9•12 years ago
|
||
|
|
Assignee | |
Comment 10•12 years ago
|
||
Yes, thanks for the fix!
|
||
Comment 11•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•