Port GTK2 to GTK3 - browser dir

RESOLVED FIXED in mozilla24

Status

()

Core
Widget: Gtk
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: stransky, Assigned: stransky)

Tracking

Trunk
mozilla24
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [check linux try build before requesting checkin])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #627699 +++

GTK+ 3.0 and GNOME 3 are approaching and we should get Firefox ready for them. This bug is about browser directory.
(Assignee)

Updated

5 years ago
Whiteboard: [leave open for remaining patches][check linux try build before requesting checkin] → [check linux try build before requesting checkin]
(Assignee)

Comment 1

5 years ago
Created attachment 758566 [details] [diff] [review]
patch

Benjamin, can you please check this one? Thanks!
Attachment #758566 - Flags: review?(benjamin)

Comment 2

5 years ago
Comment on attachment 758566 [details] [diff] [review]
patch

Not really.
Attachment #758566 - Flags: review?(benjamin) → review?(mh+mozilla)
(Assignee)

Comment 3

5 years ago
Created attachment 760332 [details] [diff] [review]
v2

Better one. Mike is away so let's ask Karlt for review. Try run for this patch - https://tbpl.mozilla.org/?tree=Try&rev=85cc0612ddc5
Attachment #758566 - Attachment is obsolete: true
Attachment #758566 - Flags: review?(mh+mozilla)
Attachment #760332 - Flags: review?(karlt)
Comment on attachment 760332 [details] [diff] [review]
v2

>-elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gtk2':
>+elif CONFIG['MOZ_ENABLE_GTK']:

I think MOZ_WIDGET_GTK is better, assuming that works.
Attachment #760332 - Flags: review?(karlt) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 760951 [details] [diff] [review]
browser patch for check-in

Thanks. An updated patch for check-in.
Attachment #760951 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0cb01583448b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24

Updated

5 years ago
See Also: → bug 882036
What's wrong with this picture?

diff --git a/browser/base/content/test/Makefile.in b/browser/base/content/test/Makefile.in
--- a/browser/base/content/test/Makefile.in
+++ b/browser/base/content/test/Makefile.in

 # test_contextmenu.html is disabled on Linux due to bug 513558
-ifneq (gtk2,$(MOZ_WIDGET_TOOLKIT))
+ifdef MOZ_WIDGET_GTK
(Assignee)

Comment 10

5 years ago
Yes, thanks for the fix!

Updated

4 years ago
Blocks: 1034064

Updated

4 years ago
No longer blocks: 1034064
Depends on: 1194044
You need to log in before you can comment on or make changes to this bug.