Closed Bug 1194420 Opened 9 years ago Closed 9 years ago

[taskclsuter-vcs] Tar operations should be done serially

Categories

(Taskcluster :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: garndt, Assigned: garndt)

References

Details

Attachments

(1 file)

54 bytes, text/x-github-pull-request
jonasfj
: review+
Details | Review
Currently taskcluster-vcs will attempt to extract all the repo tarballs in parallel causing interesting race conditions.  Tarballs that are extracting to the same parent directories should not be done in parallel
Attached file tc-vcs PR 22
So I've ran this a bunch of times with no errors from tar any longer.  It does take abouta  minute longer, but that's a small price to pay for it to be correct.

Also removed the handling of removing corrupted tarballs, this really should be handled by purging worker caches and so far I have yet to see this be an issue.  Perhaps we will see some errors now and be able to attack the root cause.
Attachment #8647688 - Flags: review?(jopsen)
Blocks: 1189830
Comment on attachment 8647688 [details] [review]
tc-vcs PR 22

See comments, I think this sound.
But we could potentially do faster.
Attachment #8647688 - Flags: review?(jopsen) → review+
See Also: → 1194463
Merged https://github.com/taskcluster/taskcluster-vcs/commit/b04c6b5b759acd8a0bbe46d92a4eb0b79e1910fa
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 1182491
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: