1194725 - [HiDPI] Nested toolbar buttons (zoom in, zoom out, copy, cut, paste) are oversized when moved to a toolbar other than the navigation toolbar

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Alexander]

Attachment: ff-toolbar-zoom-buttons.png

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150812163655

Steps to reproduce:

I want the buttons in toolbars to be small. But zoom buttons stay big (see attached screenshot). This problem has cropped up after updating to 40.0.2.

Comment 1

[Alexander]

UPD: The problem shows up only when placing zoom buttons in the menubar. When placing them in the toolbar, they do change size.

Comment 2

[Loic]

Theme issue maybe.

Could you test:
1) in safe mode:
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode
2) with a fresh profile:
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles

Comment 3

[Alexander]

Attachment: ff-buttons.png

Comment 4

[Alexander]

>Theme issue maybe.

It preserves with different themes. I suspect it is related to the "Classic Theme Restorer" add-on. I even forgot I was using it. In safe mode there is not even an option to choose small or normal buttons (see the 2nd attached image). So perhaps I should report this to the add-on author.

Comment 5

[Loic]

So try with a fresh profile without addon, it's easy to know if the culprit is Classic Theme Restorer.

Comment 6

[Alexander]

Attachment: ff-clean-profile.png

When using a clean profile the zoom controls and the "downloads" button, for example, do have different size (see "ff-clean-profile.png" file). Don't know if it qualify as a bug, though IMO all buttons should have the same size.

Comment 7

[Aris]

This issue is not related to Classic Theme Restorer add-on.

- create a clean profile (do not install any add-ons)
- make menubar and bookmarks toolbar visible
- move zoom controls or copy/cut/paste controls to any toolbar but navigation toolbar

This issue is only visible on hidpi modes, so make sure you have set Windows dpi settings to 125% or higher to reproduce this.

http://i.imgur.com/IE5edrJ.png

Comment 8

[Loic]

Regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8f57f60ee58a&tochange=fec90cbfbaad

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked as it's a recent regression.

Comment 10

[arni2033]

This was reported earlier in bug 1155874, but I failed to recognize that it's HiDPI issue

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

While this is a valid issue, I don't think this is a release blocker. We will have to wontfix this for 41.

Comment 13

[Dão Gottwald [:dao]]

Attachment: patch

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8657434 [details] [diff] [review]
patch

Review of attachment 8657434 [details] [diff] [review]:
-----------------------------------------------------------------

Nice find.

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/3cb1b3b2a6ec

Comment 16

[Dão Gottwald [:dao]]

Actually I think we should still try to uplift this to beta...

Comment 17

[Dão Gottwald [:dao]]

Comment on attachment 8657434 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1147702
[User impact if declined]: oversized zoom, cut, copy and paste buttons when moving them to a toolbar other than the navigation toolbar with high DPI
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: no new code, just fixing broken CSS selectors, low risk
[String/UUID change made/needed]:

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8657434 [details] [diff] [review]
patch

The patch looks simple enough, let's uplift to Beta41 and Aurora42.

Comment 19

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e6e4a9df2689

Comment 20

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bfe82db4bd75

Comment 21

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3cb1b3b2a6ec

Comment 22

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 43.0a1 (2015-09-06) using Windows 7 64-bit.

Verified fixed on Firefox 43.0a1 (2015-09-08), Firefox 42.0a2 (2015-09-08) and Firefox 41 Beta 8(20150907144446) under Windows 7 64-bit with 125% dpi.