Closed Bug 1194860 Opened 5 years ago Closed 4 months ago

Remove dom/imptests/ as redundant

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox43 --- wontfix
firefox71 --- fixed

People

(Reporter: hsivonen, Assigned: Ms2ger)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

The test under dom/imptests/html/dom/ now also exist under testing/web-platform/tests/dom/. It's wasteful to have both and the latter is easier to update from upstream. Let's remove the former.
Is my conclusion above correct?
Flags: needinfo?(james)
Flags: needinfo?(Ms2ger)
Until recently, the testing/web-platform tests didn't run on debug builds, unlike the imptests ones. I believe they're still not running on ASAN; if that's going to happen soon, I think I'd like to wait for that.
Flags: needinfo?(Ms2ger)
I've just merged m-c to cedar so we can see how asan looks. I suspect there might be some timeouts. If that's all it is I can try increasing the timeout multiplier for that case, or something.
Flags: needinfo?(james)
Summary: Remove dom/imptests/html/dom/ as redundant → Remove dom/imptests/ as redundant
Depends on: 1205291
Depends on: 787203
Depends on: 1294427
No longer depends on: 1294427
Can we do this now?  If not, can we add a line at the top of the README that says something like "OBSOLETE!  Stay out of here! Check out testing/web-platform and the documentation at https://developer.mozilla.org/en-US/docs/Mozilla/QA/web-platform-tests"?

I got faked out by the duplicate copies of the test infrastructure in here and the helpful README that made me think its testharnessreport.js was something that actually mattered.
Flags: needinfo?(james)
WPT are not running on ASAN yet. We should enable WPT on ASAN first.
I think asan (should be easy) and android (harder) are the known blockers here.
Flags: needinfo?(james)
For dependencies for tracking, I've found the following in Testing::web-platform-tests and added:
- Bug 1257604: Give ASAN longer timeouts
- Bug 1323620: Introduce web-platform-test for Fennec
Depends on: 1257604, 1323620
FWIW, I was running ASAN WPT on Ash for awhile and they were quite timeout-prone even after jgraham landed an upstream change to increase their timeouts.
Duplicate of this bug: 1063632
Duplicate of this bug: 1425529
Priority: -- → P3
Component: DOM → DOM: Core & HTML
Type: defect → enhancement

This leaves the testharness files, because they are used in mochitest-chrome
tests in dom/animation/test.

Duplicate of this bug: 1089034
Duplicate of this bug: 995642
Duplicate of this bug: 1226336
Duplicate of this bug: 939369
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9be4b75aee0a
Backed out changeset 73cbc0f61053 for causing lint failure in /builds/worker/checkouts/gecko/dom/imptests/testharness.js CLOSED TREE

NI for the backout comment

Flags: needinfo?(htsai) → needinfo?(Ms2ger)

Fixed patch is up for review.

Flags: needinfo?(Ms2ger)
Flags: needinfo?(htsai)
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4c5c8d78d5f
Backed out changeset 8fb923925923 for causing perma mda3 failures in dom/media/webaudio/test/test_convolverNodeChannelInterpretationChanges.html CLOSED TREE

These tests all have equivalents in the WebGL CTS (dom/canvas/test/webgl-conf), fwiw!

There are more failures (mostly timeouts) caused by the push that was backed out:

Here is the push where you can see the most of them: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=cdfbf9c0a9f1caad870e9fb59f9c1b76a7d0cb41&failure_classification_id=2&selectedJob=271158952

While we are in soft freeze cycle, can we please hold off the patch re-land after that? Thanks.

Flags: needinfo?(htsai)

While we are in soft freeze cycle, can we please hold off the patch re-land after that? Thanks.

Sorry we missed this comment before relanding. Hopefully it isn't a problem to keep this, but if it is we can back out again.

(In reply to James Graham [:jgraham] from comment #28)

While we are in soft freeze cycle, can we please hold off the patch re-land after that? Thanks.

Sorry we missed this comment before relanding. Hopefully it isn't a problem to keep this, but if it is we can back out again.

No worries. I was thinking about not to (potentially) impact RelEng work for channel merge, especially it got backed out twice that showed some concerns. If try results look good, it's not a problem to keep this. Hope this time we get everything right.

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Assignee: nobody → Ms2ger
You need to log in before you can comment on or make changes to this bug.