Closed Bug 1194860 Opened 5 years ago Closed 4 months ago
Remove dom/imptests/ as redundant
The test under dom/imptests/html/dom/ now also exist under testing/web-platform/tests/dom/. It's wasteful to have both and the latter is easier to update from upstream. Let's remove the former.
Is my conclusion above correct?
Until recently, the testing/web-platform tests didn't run on debug builds, unlike the imptests ones. I believe they're still not running on ASAN; if that's going to happen soon, I think I'd like to wait for that.
I've just merged m-c to cedar so we can see how asan looks. I suspect there might be some timeouts. If that's all it is I can try increasing the timeout multiplier for that case, or something.
Summary: Remove dom/imptests/html/dom/ as redundant → Remove dom/imptests/ as redundant
Can we do this now? If not, can we add a line at the top of the README that says something like "OBSOLETE! Stay out of here! Check out testing/web-platform and the documentation at https://developer.mozilla.org/en-US/docs/Mozilla/QA/web-platform-tests"? I got faked out by the duplicate copies of the test infrastructure in here and the helpful README that made me think its testharnessreport.js was something that actually mattered.
WPT are not running on ASAN yet. We should enable WPT on ASAN first.
I think asan (should be easy) and android (harder) are the known blockers here.
For dependencies for tracking, I've found the following in Testing::web-platform-tests and added: - Bug 1257604: Give ASAN longer timeouts - Bug 1323620: Introduce web-platform-test for Fennec
FWIW, I was running ASAN WPT on Ash for awhile and they were quite timeout-prone even after jgraham landed an upstream change to increase their timeouts.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/73cbc0f61053 Remove dom/imptests; r=jgraham
Backout by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/9be4b75aee0a Backed out changeset 73cbc0f61053 for causing lint failure in /builds/worker/checkouts/gecko/dom/imptests/testharness.js CLOSED TREE
Flags: needinfo?(htsai) → needinfo?(Ms2ger)
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/8fb923925923 Remove dom/imptests; r=jgraham
Backout by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/b4c5c8d78d5f Backed out changeset 8fb923925923 for causing perma mda3 failures in dom/media/webaudio/test/test_convolverNodeChannelInterpretationChanges.html CLOSED TREE
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/36642bee6267 Remove dom/imptests; r=jgraham
Assignee: nobody → Ms2ger
You need to log in before you can comment on or make changes to this bug.