1194860 - Remove dom/imptests/ as redundant

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Henri Sivonen (:hsivonen)]

The test under dom/imptests/html/dom/ now also exist under testing/web-platform/tests/dom/. It's wasteful to have both and the latter is easier to update from upstream. Let's remove the former.

Comment 1

[Henri Sivonen (:hsivonen)]

Is my conclusion above correct?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Until recently, the testing/web-platform tests didn't run on debug builds, unlike the imptests ones. I believe they're still not running on ASAN; if that's going to happen soon, I think I'd like to wait for that.

Comment 3

[James Graham [:jgraham]]

I've just merged m-c to cedar so we can see how asan looks. I suspect there might be some timeouts. If that's all it is I can try increasing the timeout multiplier for that case, or something.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Can we do this now?  If not, can we add a line at the top of the README that says something like "OBSOLETE!  Stay out of here! Check out testing/web-platform and the documentation at https://developer.mozilla.org/en-US/docs/Mozilla/QA/web-platform-tests"?

I got faked out by the duplicate copies of the test infrastructure in here and the helpful README that made me think its testharnessreport.js was something that actually mattered.

Comment 5

[Masatoshi Kimura [:emk]]

WPT are not running on ASAN yet. We should enable WPT on ASAN first.

Comment 6

[James Graham [:jgraham]]

I think asan (should be easy) and android (harder) are the known blockers here.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

For dependencies for tracking, I've found the following in Testing::web-platform-tests and added:
- Bug 1257604: Give ASAN longer timeouts
- Bug 1323620: Introduce web-platform-test for Fennec

Comment 8

[Ryan VanderMeulen [:RyanVM]]

FWIW, I was running ASAN WPT on Ash for awhile and they were quite timeout-prone even after jgraham landed an upstream change to increase their timeouts.

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Bug 1194860 - Remove dom/imptests; r?jgraham

This leaves the testharness files, because they are used in mochitest-chrome
tests in dom/animation/test.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73cbc0f61053
Remove dom/imptests; r=jgraham

Comment 17

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 73cbc0f61053 (Bug 1194860) for causing lint failure in /builds/worker/checkouts/gecko/dom/imptests/testharness.js CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=271133715

https://treeherder.mozilla.org/logviewer.html#?job_id=271133715&repo=autoland

Comment 18

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9be4b75aee0a
Backed out changeset 73cbc0f61053 for causing lint failure in /builds/worker/checkouts/gecko/dom/imptests/testharness.js CLOSED TREE

Comment 19

[Hsin-Yi Tsai (she/her) (REO Fx 129) [:hsinyi]]

NI for the backout comment

Comment 20

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Fixed patch is up for review.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fb923925923
Remove dom/imptests; r=jgraham

Comment 22

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 8fb923925923 (Bug 1194860) for causing perma mda3 failures in dom/media/webaudio/test/test_convolverNodeChannelInterpretationChanges.html CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=271157638

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271157638&repo=autoland&lineNumber=15162

Comment 23

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4c5c8d78d5f
Backed out changeset 8fb923925923 for causing perma mda3 failures in dom/media/webaudio/test/test_convolverNodeChannelInterpretationChanges.html CLOSED TREE

Comment 24

[Kelsey Gilbert [:jgilbert]]

These tests all have equivalents in the WebGL CTS (dom/canvas/test/webgl-conf), fwiw!

Comment 25

[Alexandru Michis [:malexandru]]

There are more failures (mostly timeouts) caused by the push that was backed out:

• test_document-timeline.html: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271158886&repo=autoland&lineNumber=4178
• test_bug1259588.html, test_Object.prototype_props.html, test_ImageData_ctor.html, test_TextDecoder.html, test_error_events.html:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271158943&repo=autoland&lineNumber=1819
• test_bug1293174_implicit_pointer_capture_for_touch_1.html, test_bug1293174_implicit_pointer_capture_for_touch_2.html, test_bug1303704.html, test_bug1315862.html, test_form_named_getter_dynamic.html, test_bug780993.html:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271158951&repo=autoland&lineNumber=1596
• test_performance_server_timing_plain_http.html, test_performance_server_timing.html, test_promise_and_timeout_ordering.html:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271158897&repo=autoland&lineNumber=2341
• test_WebKitCSSMatrix.html, test_keySync.html:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271158875&repo=autoland&lineNumber=6756
• test_bug1436040.html: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271158862&repo=autoland&lineNumber=5707
• test_image_crossorigin_data_url.html, test_scroll_space_no_range_overflow_scroll.html, test_readonly.html, test_bug1307853.html:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271158960&repo=autoland&lineNumber=6132
• test_animations_variable_changes.html: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271158952&repo=autoland&lineNumber=2033

Here is the push where you can see the most of them: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=cdfbf9c0a9f1caad870e9fb59f9c1b76a7d0cb41&failure_classification_id=2&selectedJob=271158952

Comment 26

[Hsin-Yi Tsai (she/her) (REO Fx 129) [:hsinyi]]

While we are in soft freeze cycle, can we please hold off the patch re-land after that? Thanks.

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36642bee6267
Remove dom/imptests; r=jgraham

Comment 28

[James Graham [:jgraham]]

While we are in soft freeze cycle, can we please hold off the patch re-land after that? Thanks.

Sorry we missed this comment before relanding. Hopefully it isn't a problem to keep this, but if it is we can back out again.

Comment 29

[Hsin-Yi Tsai (she/her) (REO Fx 129) [:hsinyi]]

(In reply to James Graham [:jgraham] from comment #28)

While we are in soft freeze cycle, can we please hold off the patch re-land after that? Thanks.

Sorry we missed this comment before relanding. Hopefully it isn't a problem to keep this, but if it is we can back out again.

No worries. I was thinking about not to (potentially) impact RelEng work for channel merge, especially it got backed out twice that showed some concerns. If try results look good, it's not a problem to keep this. Hope this time we get everything right.

Comment 30

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/36642bee6267