1194884 - WebM playback only decodes half of the frames

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[António Novo]

Attachment: after_playback_stats.png

User Agent: Mozilla/5.0 (masking-agent; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20150813030208

Steps to reproduce:

Open and play a WebM file and its equivalent MP4 (container), examnple:
http://techslides.com/demos/sample-videos/small.webm
and
http://techslides.com/demos/sample-videos/small.mp4


Actual results:

While the MP4 file plays-back as it should, the WebM lacks _exactly_ half of its frames (not decoded nor painted).
Play-back is still done correctly, no sound or temporal problems arise, but the apparent lack of decent frame rate can be seen.


Expected results:

Playback of WebM files should decode all frames needed to play-back the file the best it can (on the target machine).



Contrary to bug 571386, where frames are dropped somewhat randomly (maybe according to load?) exactly half of the frames on the video file are not decoded.

Also, according to layers.acceleration.draw-fps, both tabs/layers lock in at 75FPS while playing both files (75Hz screen refresh rate). CPU load remains the same in both cases.

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

I can see the dropping frams in "Show Statics". 
https://hg.mozilla.org/mozilla-central/rev/4e883591bb5dff021c108d3e30198a99547eed1e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0 ID:20150814030208


Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=bdb808a2dd66&tochange=195776f0148b

Regressed by: Bug 1185792

Comment 2

[Alice0775 White]

Attachment: statistics before/after landing the Bug 1185792

Comment 3

[Jean-Yves Avenard [:jya]]

Jan, can you have a look?  seems to be what's causing bug 762774

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: [webm] P1. Use MediaResourceIndex. r=j^

Remove duplicated code.
Also some fixes with log types.

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: [webm] P2. Retrieve all VPX decoded frames from decoder. r=j^

Comment 6

[Jean-Yves Avenard [:jya]]

turned out to be an easy one...

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8ce7726fa5a
https://hg.mozilla.org/integration/mozilla-inbound/rev/959cc9cb112f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e8ce7726fa5a
https://hg.mozilla.org/mozilla-central/rev/959cc9cb112f

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking since this is a regression. 
Jean-Yves, want to nominate this for uplift?

Comment 10

[Jean-Yves Avenard [:jya]]

Yes.

I have a long list to uplift for aurora and beta.

Comment 11

[Jean-Yves Avenard [:jya]]

Comment on attachment 8648397 [details] [diff] [review]
[webm] P2. Retrieve all VPX decoded frames from decoder. r=j^

Approval Request Comment
[Feature/regressing bug #]: 1185792
[User impact if declined]: webm videos will play with 50% dropped frames
[Describe test coverage new/current, TreeHerder]: in central, local test. confirmed issue fixed by users.
[Risks and why]: Very low, this is now using the same logic as the previous WebMReader VPx decoder.
[String/UUID change made/needed]: None

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/91624ae2b989
https://hg.mozilla.org/releases/mozilla-aurora/rev/2bac25974183