Closed Bug 1194948 Opened 6 years ago Closed 6 years ago

Build gfx/ipc in unified mode and mark as FAIL_ON_WARNINGS

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

No description provided.
Attachment #8648349 - Flags: review?(bgirard)
Comment on attachment 8648349 [details] [diff] [review]
gfx-ipc-FAIL_ON_WARNINGS.patch

Review of attachment 8648349 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this! Looks good as long as the new unified files don't indirectly include problematic headers (which was window.h IIRC). Direct includes looked fine.
Attachment #8648349 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/a4a4b0409e7b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.