Closed
Bug 1194948
Opened 9 years ago
Closed 9 years ago
Build gfx/ipc in unified mode and mark as FAIL_ON_WARNINGS
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
3.49 KB,
patch
|
BenWa
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8648349 -
Flags: review?(bgirard)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8648349 [details] [diff] [review]
gfx-ipc-FAIL_ON_WARNINGS.patch
Review of attachment 8648349 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for doing this! Looks good as long as the new unified files don't indirectly include problematic headers (which was window.h IIRC). Direct includes looked fine.
Attachment #8648349 -
Flags: review?(bgirard) → review+
|
||
Comment 3•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•