Closed Bug 1194986 Opened 9 years ago Closed 9 years ago

Clicking outside hamburger icon on button does not close menu

Categories

(Firefox :: Toolbars and Customization, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 45
Tracking Status
firefox43 --- affected
firefox45 --- verified

People

(Reporter: ato, Assigned: Gijs)

Details

Attachments

(2 files)

Attached image hamburger.png
When clicking to open the hamburger menu, it's impossible to close it if you click outside the visible icon area on the button.

This is visualised in the attached screenshot, where clicking any area of the button to the left of the first line, or to the right of the second, will close the menu but immediately open it again.

Clicking on the hamburger icon itself will close the menu as expected.
I can reproduce this on Linux, but not on OS X or Windows.

I suspect this will end up being a XUL toolkit bug.

Neil, do you have time to look into what's going wrong here?

Also, Andreas, do you know if this used to work in the past (on Linux) ?
Component: Theme → Toolbars and Customization
Flags: needinfo?(enndeakin)
Flags: needinfo?(ato)
(In reply to :Gijs Kruitbosch from comment #1)
> Also, Andreas, do you know if this used to work in the past (on Linux) ?

I don’t know, no.
Flags: needinfo?(ato)
There was the same bug on Windows, but it was fixed about 10 month ago.
(In reply to arni2033 from comment #3)
> There was the same bug on Windows, but it was fixed about 10 month ago.

Do you have a reference to the bug?
Flags: needinfo?(arni2033)
(In reply to Andreas Tolfsen (:ato) from comment #4)
> Do you have a reference to the bug?
   Maybe bug 1044242. But Gijs said there that the bug was fixed as part of bug 987230. That's not true, because when I tested it with mozregression, the bug was already fixed at 2014-06-20 (well, I don't remember the date correctly, but it was 2014-06-** - before any patches from 1044242 landed)
   You could try a build from 2014-05-31 or 2014-07-01 to check if your issue was presented there
>   http://ftp.mozilla.org/pub/firefox/nightly/2014/05/2014-05-31-03-02-04-mozilla-central/
>   http://ftp.mozilla.org/pub/firefox/nightly/2014/07/2014-07-01-03-02-02-mozilla-central/
Flags: needinfo?(arni2033)
(In reply to arni2033 from comment #5)
> (In reply to Andreas Tolfsen (:ato) from comment #4)
> > Do you have a reference to the bug?
>    Maybe bug 1044242. But Gijs said there that the bug was fixed as part of
> bug 987230. That's not true, because when I tested it with mozregression,
> the bug was already fixed at 2014-06-20 (well, I don't remember the date
> correctly, but it was 2014-06-** - before any patches from 1044242 landed)
>    You could try a build from 2014-05-31 or 2014-07-01 to check if your
> issue was presented there
> >   http://ftp.mozilla.org/pub/firefox/nightly/2014/05/2014-05-31-03-02-04-mozilla-central/
> >   http://ftp.mozilla.org/pub/firefox/nightly/2014/07/2014-07-01-03-02-02-mozilla-central/

It looks like this got fixed on Windows by bug 994117. The animation is disabled on Linux, which would explain why that didn't help at all on Linux. It's still strange that bug 987230 didn't fix it. I tried looking into this but gdb is basically useless at doing its job as a debugger (it hangs trying to debug Firefox, then when I kill Firefox complains that it can't load some debug files because "security", and then when I quit it complains that the process that I already killed might now die... makes no sense whatsoever). I'll try some more, but Neil would really be a better person to look into what's going wrong here...
I was stubborn and kept looking.

So it turns out the XUL image that's the anchor has no consumeanchor attribute. That's because when we created the badged button binding, somehow that attribute was missed out in the list of things to inherit. Restoring that attribute fixes it.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(enndeakin)
(It's still not clear to me why this works on platforms that do have the animation (ie OSX/Windows) when the menu button is a badged menu button, but never mind that. This is at least the correct fix without the animation.)
Bug 1194986 - fix consumeanchor inheritance on badged and menu-button buttons, r?jaws
Attachment #8683283 - Flags: review?(jaws)
Attachment #8683283 - Flags: review?(jaws) → review+
Comment on attachment 8683283 [details]
MozReview Request: Bug 1194986 - fix consumeanchor inheritance on badged and menu-button buttons, r?jaws

https://reviewboard.mozilla.org/r/24251/#review22235
https://hg.mozilla.org/mozilla-central/rev/765a530eb8cb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Confirming the fix on Ubuntu 14.04 x64 using 2015-11-22 Nightly (45.0a2).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: