Closed
Bug 1195071
Opened 10 years ago
Closed 10 years ago
MediaFormatReader should check the return value of MediaDataDecoder::Input
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: jya, Assigned: jya)
References
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
The MediaFormatReader doesn't check the return value of MediaDataDecoder::Input()
Most MediaDataDecoder always return NS_OK regardless of input ; however the H264Converter could potentially return an error.
The value should be checked.
Plus it's better form.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8648452 -
Flags: review?(cpearce)
|
||
Updated•10 years ago
|
Attachment #8648452 -
Flags: review?(cpearce) → review+
|
||
Comment 3•10 years ago
|
||
Assignee: nobody → jyavenard
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
|
||
Comment 4•10 years ago
|
||
status-firefox42:
--- → fixed
|
|
||
Comment 5•10 years ago
|
||
Backed out for a youtube playback regression. See Bug 1199573.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Updated•10 years ago
|
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•