If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

MediaFormatReader should check the return value of MediaDataDecoder::Input

RESOLVED FIXED in Firefox 42

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

Trunk
mozilla43
Points:
---

Firefox Tracking Flags

(firefox42 fixed, firefox43 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The MediaFormatReader doesn't check the return value of MediaDataDecoder::Input()

Most MediaDataDecoder always return NS_OK regardless of input ; however the H264Converter could potentially return an error.

The value should be checked.

Plus it's better form.
(Assignee)

Comment 1

2 years ago
Created attachment 8648452 [details] [diff] [review]
Check for MediaDataDecoder::Input error.
Attachment #8648452 - Flags: review?(cpearce)
Attachment #8648452 - Flags: review?(cpearce) → review+

Comment 2

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fc3ec170fb2
https://hg.mozilla.org/mozilla-central/rev/6fc3ec170fb2
Assignee: nobody → jyavenard
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
(Assignee)

Updated

2 years ago
Blocks: 1197083
https://hg.mozilla.org/releases/mozilla-aurora/rev/89ec7fc554b9
status-firefox42: --- → fixed
Backed out for a youtube playback regression. See Bug 1199573.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
status-firefox42: fixed → affected
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-aurora/rev/a9d79eb7e02a
status-firefox42: affected → fixed
You need to log in before you can comment on or make changes to this bug.